From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ImV2ESrNFWrnxh0AWB0awg (envelope-from ) for ; Tue, 26 May 2026 12:41:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RpRjux1k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 355121E0A3; Tue, 26 May 2026 12:41:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 67B571E024 for ; Tue, 26 May 2026 12:41:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 011D54BA23F8 for ; Tue, 26 May 2026 16:41:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 011D54BA23F8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RpRjux1k Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7D98A4BA2E26 for ; Tue, 26 May 2026 16:40:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D98A4BA2E26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D98A4BA2E26 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779813641; cv=none; b=Y4mCMCsJ4JL2DIhamvRwbSRsE+dCX1DupxL65RZvrztI0vbV60HflhWtp3swDZMVIchJO9XX0ExrJHKNrVCKW38AS6qdaOtwW4ubjT7ZTKFdIghwlCnkWlklBQfL9wrbQ6zJve3RDtAuLMdYdrh1WhimDL1Y2q5NZH3Mnar6UtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779813641; c=relaxed/simple; bh=pbFCgbCXMKR6OGr9Sbep/dDynAM43azrZ01x91qh8Jc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Y6m3WGJ6uEo55CQdVCwXpnvIebtOT6iVh0yuHP7XtgLrwW5yQSodg1yIGb953h2AuR0i/3CxWP0Z3ks1hp9yi4CffJ3TtZi8JDgPUq9fHUgsk3U2Rh4tUJ4G4sx25kUGqD25TlsD7aNj6pvlb0fI6hiB0ovBz6J1Gf5YRS5xoqk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RpRjux1k DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D98A4BA2E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779813641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qK3aMHgsxEUOUQbBTGGDCrciWaP/pg863bGOeOW1oZA=; b=RpRjux1kdxmQg/bVPFPLW0sBDsT4/AMIYQDWQdSpHcZ7zW6hyaMbzBZOOqtbNmWEutLolu XjfVLZ+POqvR9XQSIT5lW//iRtRMOv8UgxHgA86Yl4I+3cykVjSzOoZxjBvhmKyf0iaBtR L6uTqEEc6YwsjnEtl7ZGW7hE+EYTe1I= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-TKj2zRomNDK76MdaJAsM6w-1; Tue, 26 May 2026 12:40:37 -0400 X-MC-Unique: TKj2zRomNDK76MdaJAsM6w-1 X-Mimecast-MFC-AGG-ID: TKj2zRomNDK76MdaJAsM6w_1779813637 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8b1f39c5827so235631366d6.1 for ; Tue, 26 May 2026 09:40:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779813637; x=1780418437; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qK3aMHgsxEUOUQbBTGGDCrciWaP/pg863bGOeOW1oZA=; b=iOphYFaDn3QxNJdOerW7VOszhzCRPuqcr/cCmpSoMp3zzRPSB9kvzcZcYGKRMgEogV 9YA+sfCP0ZEuoAKIUbd+0RqlaUlWqm/VQJtKTmzUEwG7Y3J2sqi7mkBHyAFdU7w2oNUf j1B4G9DmIXvkjspTSpRqFvRY8m9QwnTeTK7xB0zVrX+BgMQmZ7Jh61HWeO8sK2T8mfZb UKR4P+nFs1OjE9XC0WHNM3IP0O238IqgqaH/yld2eu3PGpcQ6CDPLHXq8pTTfPK6iF/J OV9w4CxVWaCeIRqbnnPknGKjytbrxMKnrryXKQwMLM3mirejWyAMy1UXofRJa7LYNg8Z Cthw== X-Forwarded-Encrypted: i=1; AFNElJ/0nrmAj0pXnoPBlOJmg1gxT0TuKb1khug/PxdDVIhnAm5mE3z+1jhqpeQhYpYC51e0WRyK920K6Pa/TQ==@sourceware.org X-Gm-Message-State: AOJu0Yzyd+/lsWxi+YySOFRIuWSI9LAoCzF4Zgb3dIdU9d6f97Kwu+y3 KWdAAQa7pF8uQ1cVSkEts7SCN4RTqAczLgH503pCNaptfhuucM46zo3ABiZs+89N4rvjTZgaFTo OSLl2Jjfr0pDHhkTblRGMM28pbkRZ47vL37YodTCC88IUiZVkYezJe9vL8zHs9FNWG/92ZRc= X-Gm-Gg: Acq92OGdD09e8dO3TKNW6l+xC367+/srmWQOvKuyjPtJz66X9r4wYPlvKOy8Gq+IY87 ssVaNb2S3Sss5DoRX21cQcu4FEtCBa3Cc8z5sE/sXreOeGOpagyH/Owz8IPXgBHHlaNCjGiXOTg AuKkoPQh9XO/vkUso/gzmHMmrUO4Ea59NhZEp+FGscr/7bGGHDUetGQinEJjoWsHWhjJH32zKmr t48WnAiK5fPb/WbyNqn9I3VvR/Id7QRHFW7+XUFhhOKpl/q4NQ/FwAQ0PqOIMQj4G/M3mbpN4Gs 9bHjLzeXhoRMzXQSzMHps2YJtA2nziGOjtIFrbjBziorXNl54uIWQtjTzRn6DIjKgG7kuinTtWL CYHtqK5yl8ixwq9xN81fq2uA6ssTK2XfB2336wzcG+A3t+yRHC7v34ytekHMq1V4xyw2cfSWjVh /durI= X-Received: by 2002:a05:620a:1a1c:b0:910:4e35:cf02 with SMTP id af79cd13be357-914b49ca211mr2872134085a.37.1779813636556; Tue, 26 May 2026 09:40:36 -0700 (PDT) X-Received: by 2002:a05:620a:1a1c:b0:910:4e35:cf02 with SMTP id af79cd13be357-914b49ca211mr2872127485a.37.1779813635861; Tue, 26 May 2026 09:40:35 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:2d5d:7adb:2b6:a50e? ([2804:14d:8084:993e:2d5d:7adb:2b6:a50e]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f87d1a27sm254296285a.28.2026.05.26.09.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 09:40:35 -0700 (PDT) Message-ID: <71d7aab3-d7df-4b18-abfe-8fbe240f7d65@redhat.com> Date: Tue, 26 May 2026 13:40:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] gdb/aarch64: Test record/replay support for CSSC To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: luis.machado.foss@gmail.com, thiago.bauermann@linaro.org References: <20260512231707.18123-1-Ezra.Sitorus@arm.com> <20260512231707.18123-3-Ezra.Sitorus@arm.com> From: Guinevere Larsen In-Reply-To: <20260512231707.18123-3-Ezra.Sitorus@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zBK4hRmEaFHADGUxm5eXmsAdO5pjzWPS75_AS6f4CJI_1779813637 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/12/26 8:17 PM, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > GDB can handle AArch64's CSSC instructions but there were no tests > ensuring that and ensuring no regressions would creep in. This commit > adds some tests for these instructions. This was tested on > aarch64-none-linux-gnu on QEMU with CSSC support. > --- Hi Ezra! This patch looks pretty good to me! Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen It/she > gdb/testsuite/gdb.reverse/aarch64-cssc.c | 88 +++++++++++++ > gdb/testsuite/gdb.reverse/aarch64-cssc.exp | 139 +++++++++++++++++++++ > gdb/testsuite/lib/gdb.exp | 52 ++++++++ > 3 files changed, 279 insertions(+) > create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c > create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp > > diff --git a/gdb/testsuite/gdb.reverse/aarch64-cssc.c b/gdb/testsuite/gdb.reverse/aarch64-cssc.c > new file mode 100644 > index 00000000..67ccb68e > --- /dev/null > +++ b/gdb/testsuite/gdb.reverse/aarch64-cssc.c > @@ -0,0 +1,88 @@ > +/* This test program is part of GDB, the GNU debugger. > + > + Copyright 2024-2026 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > + > +#define PREPARE_REGS(X, Y, Z) \ > + __asm__ volatile ("mov x19, %0\n" : : "r"(X): "x19"); \ > + __asm__ volatile ("mov x20, %0\n" : : "r"(Y): "x20"); \ > + __asm__ volatile ("mov x21, %0\n" : : "r"(Z): "x21"); > + > +int > +main (void) > +{ > + const uint64_t a = 0x0123456789abcdef; > + const uint64_t b = 0xfedbca9876543210; > + const uint64_t c = 0xdeadbeefc001face; > + > + PREPARE_REGS (a, b, c); > + /* Before abs. */ > + __asm__ volatile ("abs x19, x21\n" ::: "x19"); > + /* After abs. */ > + > + PREPARE_REGS (a, b, c); > + /* Before cnt. */ > + __asm__ volatile ("cnt x19, x20\n" : :: "x19"); > + /* After cnt. */ > + > + PREPARE_REGS (a, b, c); > + /* Before ctz. */ > + __asm__ volatile ("ctz x19, x20\n" : :: "x19"); > + /* After ctz. */ > + > + PREPARE_REGS (a, b, c); > + /* Before smax-1. */ > + __asm__ volatile ("smax x19, x20, #10\n" : :: "x19"); > + /* After smax-1. */ > + > + PREPARE_REGS (a, b, c); > + /* Before smax-2. */ > + __asm__ volatile ("smax x19, x20, x21\n" : :: "x19"); > + /* After smax-2. */ > + > + PREPARE_REGS (a, b, c); > + /* Before smin-1. */ > + __asm__ volatile ("smin x19, x20, #10\n" : :: "x19"); > + /* After smin-1. */ > + > + PREPARE_REGS (a, b, c); > + /* Before smin-2. */ > + __asm__ volatile ("smin x19, x20, x21\n" : :: "x19"); > + /* After smin-2. */ > + > + PREPARE_REGS (a, b, c); > + /* Before umax-1. */ > + __asm__ volatile ("umax x19, x20, #10\n" : :: "x19"); > + /* After umax-1. */ > + > + PREPARE_REGS (a, b, c); > + /* Before umax-2. */ > + __asm__ volatile ("umax x19, x20, x21\n" : :: "x19"); > + /* After umax-2. */ > + > + PREPARE_REGS (a, b, c); > + /* Before umin-1. */ > + __asm__ volatile ("umin x19, x20, #10\n" : :: "x19"); > + /* After umin-1. */ > + > + PREPARE_REGS (a, b, c); > + /* Before umin-2. */ > + __asm__ volatile ("umin x19, x20, x21\n" : :: "x19"); > + /* After umin-2. */ > + > + return 0; > +} > diff --git a/gdb/testsuite/gdb.reverse/aarch64-cssc.exp b/gdb/testsuite/gdb.reverse/aarch64-cssc.exp > new file mode 100644 > index 00000000..1e2980a6 > --- /dev/null > +++ b/gdb/testsuite/gdb.reverse/aarch64-cssc.exp > @@ -0,0 +1,139 @@ > +# Copyright 2024-2026 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test instruction record for AArch64 FEAT_CSSC instructions. > +# Based on gdb.reverse/aarch64-mops.exp > +# > +# The basic flow of the record tests are: > +# 1) Stop before executing the instructions of interest. Record > +# the initial value of the registers that the instruction will > +# change, i.e. the destination register. > +# 2) Execute the instructions. Record the new value of the > +# registers that changed. > +# 3) Reverse the direction of the execution and execute back to > +# just before the instructions of interest. Record the final > +# value of the registers of interest. > +# 4) Check that the initial and new values of the registers are > +# different, i.e. the instruction changed the registers as expected. > +# 5) Check that the initial and final values of the registers are > +# the same, i.e. GDB record restored the registers to their > +# original values. > + > +require allow_aarch64_cssc_tests > +standard_testfile > + > +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ > + [list debug additional_flags=-march=armv8-a+cssc]] } { > + return > +} > + > +if {![runto_main]} { > + return > +} > + > +gdb_test_no_output "record full" > + > +proc test_single_asm { name } { > + with_test_prefix $name { > + set before_seq [gdb_get_line_number "Before ${name}"] > + set after_seq [gdb_get_line_number "After ${name}"] > + set regs { x19 x20 x21 } > + > + set insn [lindex [split $name "-"] 0] > + > + gdb_test "break $before_seq" \ > + "Breakpoint ${::decimal} at ${::hex}: file .*/aarch64-cssc.c, line ${::decimal}\\." \ > + "$insn: break before instruction sequence" > + gdb_continue_to_breakpoint "$insn: about to execute instruction sequence" \ > + [multi_line ".*/aarch64-cssc.c:${::decimal}" \ > + "${::decimal}\[ \t\]+__asm__ volatile \\(\"${insn} .*\".*"] > + > + # Depending on the compiler, the line number information may put GDB a few > + # instructions before the beginning of the asm statement. > + arrive_at_instruction $insn > + # Add a breakpoint that we're sure is at the prologue instruction. > + gdb_test "break *\$pc" \ > + "Breakpoint ${::decimal} at ${::hex}: file .*/aarch64-cssc.c, line ${::decimal}\\." \ > + "$insn: break at prologue instruction" > + > + # Record the initial register values. > + foreach r $regs { > + set ${r}_initial [capture_command_output "info register $r" ""] > + } > + > + gdb_test "break $after_seq" \ > + "Breakpoint ${::decimal} at ${::hex}: file .*/aarch64-cssc.c, line ${::decimal}\\." \ > + "$insn: break after instruction sequence" > + gdb_continue_to_breakpoint "$insn: executed instruction sequence" \ > + [multi_line ".*/aarch64-cssc.c:${::decimal}" ".*"] > + > + # Record the new register values. > + foreach r $regs { > + set ${r}_new [capture_command_output "info register $r" ""] > + } > + > + # Execute in reverse to before the instruction sequence. > + gdb_test_no_output "set exec-direction reverse" > + > + gdb_continue_to_breakpoint "reversed execution of instruction sequence" \ > + [multi_line ".*/aarch64-cssc.c:${::decimal}" \ > + "${::decimal}\[ \t\]+__asm__ volatile \\(\"${insn} .*\".*"] > + > + # Record the final register values. > + foreach r $regs { > + set ${r}_final [capture_command_output "info register $r" ""] > + } > + > + foreach v { x19 x20 x21 } { > + gdb_assert ![string compare [set ${v}_initial] [set ${v}_final]] \ > + "$insn: check $v initial value versus $v final value" > + } > + > + gdb_assert [string compare [set x19_initial] [set x19_new]] \ > + "$insn: check x19 initial value versus x19 new value" > + > + foreach v { x20 x21 } { > + gdb_assert ![string compare [set ${v}_initial] [set ${v}_new]] \ > + "$insn: check $v initial value versus $v new value" > + } > + > + # Restore forward execution and go to end of recording. > + gdb_test_no_output "set exec-direction forward" > + gdb_test "record goto end" \ > + [multi_line \ > + "Go forward to insn number ${::decimal}" \ > + "#0 main \\(\\) at .*/aarch64-cssc.c:${::decimal}" \ > + ".*"] > + } > +} > + > +set cases { > + { abs } > + { cnt } > + { ctz } > + { smax-1 } > + { smax-2 } > + { smin-1 } > + { smin-2 } > + { umax-1 } > + { umax-2 } > + { umin-1 } > + { umin-2 } > +} > + > +foreach c $cases { > + lassign $c insn > + test_single_asm $insn > +} > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 3f3197cb..9d5c0e5a 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5350,6 +5350,58 @@ gdb_caching_proc allow_aarch64_lrcpc3_tests {} { > return $allow_lrcpc3_tests > } > > +# Run a test on the target to see if it supports the AArch64 CSSC feature. > +# Return 1 if so, 0 if it does not. Note this causes a restart of GDB. > + > +gdb_caching_proc allow_aarch64_cssc_tests {} { > + global srcdir subdir gdb_prompt inferior_exited_re > + > + set me "allow_aarch64_cssc_tests" > + > + if { ![is_aarch64_target]} { > + return 0 > + } > + > + set compile_flags "{additional_flags=-march=armv8-a+cssc}" > + > + # Compile a test program reading CSSC. > + set src { > + int main() { > + asm volatile ("abs x0, x1" ::: "x0"); > + return 0; > + } > + } > + > + if {![gdb_simple_compile $me $src executable $compile_flags]} { > + return 0 > + } > + > + # Compilation succeeded so now run it via gdb. > + clean_restart > + gdb_load $obj > + gdb_run_cmd > + > + gdb_expect { > + -re ".*Illegal instruction.*${gdb_prompt} $" { > + verbose -log "\n$me cssc support not detected" > + set allow_cssc_tests 0 > + } > + -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { > + verbose -log "\n$me: cssc support detected" > + set allow_cssc_tests 1 > + } > + default { > + warning "\n$me: default case taken" > + set allow_cssc_tests 0 > + } > + } > + gdb_exit > + remote_file build delete $obj > + > + verbose "$me: returning $allow_cssc_tests" 2 > + return $allow_cssc_tests > +} > + > # Run a test on the target to see if it supports AArch64 MOPS (Memory > # Operations) extensions. Return 1 if so, 0 if it does not. Note this > # causes a restart of GDB.