From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VQpaA/5A22ovpw8AWB0awg (envelope-from ) for ; Fri, 23 Oct 2026 07:11:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE852378002; Fri, 23 Oct 2026 07:11:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68CDF378002 for ; Fri, 23 Oct 2026 07:11:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDE014BA23C2 for ; Fri, 23 Oct 2026 11:11:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDE014BA23C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D552C4BA2E20 for ; Fri, 23 Oct 2026 11:11:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D552C4BA2E20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D552C4BA2E20 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792753889; cv=none; b=XkXjKPMBPe51dF5Sdyf7Uf8HPW53a8uocqFx9Vag9HNXixEyYd7jICff2dSKQaojZfD4F/BDzMyl185EOAPltQ5cuOLFBKCt2I/YZTy8zfgWSbbsWehbwgWBFuyzY86GKeYbeyyigf68cjYiSQv+4v10A2+h1SX7Oz+RLyuyfSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792753889; c=relaxed/simple; bh=bUB+FkbXAdo4QN6Fo3pJKR53POoWbT9cIkM96MjfriU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=sPjAE1tInathxQHyifQvOqfvPOnJpzGcWZrwf3un6QgMVycEpUr1hT37RgPSyjHvGCJTYX5XtknwqHTopWHC396K9iWuXOHwGwTsK0yxHI1WgMt7wDoxpKkWxtCWzOJ3HkidnR0+2QCZ4GWEAbT8vBad/9DW8CJlVihQRy48lvs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07WR3dbQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UohSIji4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D552C4BA2E20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5EC93220F5; Fri, 23 Oct 2026 11:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792753887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvQ+Kk9MWzxKl1tmA/2rG82idBo7ICTFsK7hB2eLZ1c=; b=07WR3dbQLaPH44BZ4mLL8afblmDBRi/zAhvTqxePCWco5/rfue9aHDs9cGbCNNhxClzu0e UpTZ1rA+wHRcuSbl7UVNxz4uXonMWxNnfnZUCgZ6TuhvznV76p1eV5c63hvCvkPxxAQsa1 AISQwqay3Wed91GapsD5GdJ+8P9dhDQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792753887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvQ+Kk9MWzxKl1tmA/2rG82idBo7ICTFsK7hB2eLZ1c=; b=UohSIji4uWQX+1uroK7XI5ogWsDtwuYvTNIJD/GUeD7PLBRXs0VXQotfDsrGw8DlAjOLjq 8KM977pg5KFIFECA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=07WR3dbQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UohSIji4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792753887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvQ+Kk9MWzxKl1tmA/2rG82idBo7ICTFsK7hB2eLZ1c=; b=07WR3dbQLaPH44BZ4mLL8afblmDBRi/zAhvTqxePCWco5/rfue9aHDs9cGbCNNhxClzu0e UpTZ1rA+wHRcuSbl7UVNxz4uXonMWxNnfnZUCgZ6TuhvznV76p1eV5c63hvCvkPxxAQsa1 AISQwqay3Wed91GapsD5GdJ+8P9dhDQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792753887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvQ+Kk9MWzxKl1tmA/2rG82idBo7ICTFsK7hB2eLZ1c=; b=UohSIji4uWQX+1uroK7XI5ogWsDtwuYvTNIJD/GUeD7PLBRXs0VXQotfDsrGw8DlAjOLjq 8KM977pg5KFIFECA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2687F133F6; Fri, 23 Oct 2026 11:11:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OyK2Ot5A22r1NQAAD6G6ig (envelope-from ); Fri, 23 Oct 2026 11:11:27 +0000 Message-ID: <71d772a5-5ff8-4363-9ca1-8a1df30a11c1@suse.de> Date: Fri, 23 Oct 2026 13:11:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Use try instead of catch To: Keith Seitz , gdb-patches@sourceware.org References: <20260925140116.1985238-1-tdevries@suse.de> <20260925140116.1985238-3-tdevries@suse.de> <4d525a62-ba57-48fa-8bfa-7840c575a425@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <4d525a62-ba57-48fa-8bfa-7840c575a425@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5EC93220F5 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-13.50 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/22/26 4:22 PM, Keith Seitz wrote: > Hi, > > On 9/25/26 7:01 AM, Tom de Vries wrote: >> Use try instead of catch in a few places in lib/gdb.exp. > > I think this series looks good, but I did want to point out > one little thing. > >> --- >>   gdb/testsuite/lib/gdb.exp | 230 +++++++++++++++++++++++--------------- >>   1 file changed, 139 insertions(+), 91 deletions(-) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 2cfdbdda09d..3496ddd4132 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -12380,7 +12425,10 @@ gdb_caching_proc have_startup_shell {} { >>   proc dwz_version { } { >>       set dwz_program "dwz" >> -    set res [catch {exec $dwz_program --version} output] >> +    try { >> +    set output [exec $dwz_program --version] >> +    } trap CHILDSTATUS {output} { >> +    } >>       # Don't check the exit value of 'dwz' process as 'dwz' doesn't >>       # exit immediately after displaying the version number, and for > > This is a subtle behavioral change. In the case where dwz does not exist > on the system, `dwz_version' used to return {}. With this change, it now > will propogate an error. IIUC this will cause issues with any test on > such a host that does "require dwz_version N". That will now issue an > error instead of eliciting the usual UNSUPPORTED from dejagnu. > Hi Keith, thanks for the review. The Linaro CI did run into this problem, so I've already addressed this in a v2. Thanks, - Tom > Reviewed-By: Keith Seitz > > Keith >