From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109238 invoked by alias); 10 Aug 2018 10:41:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109228 invoked by uid 89); 10 Aug 2018 10:41:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 10:41:48 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DCE707B2B1; Fri, 10 Aug 2018 10:41:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5916B2026D65; Fri, 10 Aug 2018 10:41:46 +0000 (UTC) Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command To: Jan Vrany , gdb-patches@sourceware.org References: <877ekz6ze7.fsf@tromey.com> <20180810082953.8426-1-jan.vrany@fit.cvut.cz> <57cf8fb8-fcd5-048f-d757-3ce20bddad11@redhat.com> From: Pedro Alves Message-ID: <71a83e5b-0662-e269-5b94-be7fc2ce5687@redhat.com> Date: Fri, 10 Aug 2018 10:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00268.txt.bz2 On 08/10/2018 11:28 AM, Jan Vrany wrote: > On Fri, 2018-08-10 at 10:47 +0100, Pedro Alves wrote: >> On 08/10/2018 09:29 AM, Jan Vrany wrote: >>> @@ -33095,6 +33101,9 @@ records, produced when trying to execute an undefined @sc{gdb/mi} command >>> @item exec-run-start-option >>> Indicates that the @code{-exec-run} command supports the @option{--start} >>> option (@pxref{GDB/MI Program Execution}). >>> +@item data-disassemble-a-option >>> +Indicates that the @code{-data-disassemble} command supports the @option{-a} >>> +option (@pxref{GDB/MI Data Manipulation}). >>> @end ftable >> >> I'm curious about how you intend to use this new -list-features feature. >> Are you enabling/disabling some UI element depending on presence of the >> feature? I.e., something that you wouldn't be able to do by just >> trying the "-data-disassemble -a" command and looking for error? > > Yes. Basically I have a menu item on frame that opens another window with > disassembly of the coresponding function (showing current instruction, > (basic) blocks and alike). > > For programs with debug information, I can do that even without -a option. > For programs without debug information, I need -a option and - to make the > frontend robust w.r.t UX - I disable the menu item. > > I can indeed just try and catch the error, but this seems to be too heavyweight. > It would mean to disassemble function whenever user switches frames in the > UI or in CLI. I can cache the result, but still. This new feature just makes > it trivial and fast enough (no MI roundtrip to enable/disable menu item) Ahah, thanks. (IMHO, that's useful info that include in a submission that proposes a -list-features addition.) > > That being said, I do not insist on having this feature. I'm close to the point > of just saying "you need to use my patched GDB, anyway. At least for "now" and > hope that my patches will eventually make it into official GDB release. Not a big > deal for me, not at all. > > So, if you (meaning you maintainers) prefer not having this feature, I'll just remove > it. Absolutely no problem! Just let me know. I was really just curious. And TBC, I was just talking about the -list-features entry, not the actual whole "-a" feature added by the patch, which I agree is useful. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,9 @@ > > *** Changes since GDB 8.1 > > +* The '-data-disassemble' MI command now accepts the '-a' option to disassemble > + the whole function surrounding given program counter value or function name. This should be moved to the "since 8.2" section. Thanks, Pedro Alves