On 08.09.2020 15:49, Joel Brobecker wrote: >> I think that's reasonable. I just finished taking a look, I did review it >> as best as I could. There's not much risk in merging it, and the sooner this >> is available upstream, the better, so I think we should just go ahead with it. >> >> Of course, the more pair of eyes on the code the better, so if somebody else >> wants to take a look, go ahead. >> >> I would also consider including the gdbserver support for ARC, with the same >> logic. But I don't think that has to block the branch creation, we can easily >> cherry-pick it. > > I'm not opposed to these going into GDB 10 on the basis that they > are isolated pieces of code that can't affect the rest. On the other > hand, if those can be safely pushed at the last minute, they should > also be cherry-pickable on the branch, so given the very large delay > the branching has already suffered, I would not delay branching > for this new feature further. We can simply cherry-pick those later. > Would that be acceptable? > Personally, I consider the patchset to be ready to merge, but it depends on the reviewers with approval privilege.