From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130022 invoked by alias); 14 Nov 2017 14:18:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129998 invoked by uid 89); 14 Nov 2017 14:18:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=didn, workflow X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0073.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 14:18:16 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0104.eurprd08.prod.outlook.com (10.160.211.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.12; Tue, 14 Nov 2017 14:18:12 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::2891:52f2:59:8e54]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::2891:52f2:59:8e54%16]) with mapi id 15.20.0218.015; Tue, 14 Nov 2017 14:18:12 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Better make rules for IPA objects Date: Tue, 14 Nov 2017 14:18:00 -0000 Message-ID: <71C283C9-6737-420D-8835-4A2C549FDA6C@arm.com> References: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com> <86lgj9t8mi.fsf@gmail.com> In-Reply-To: <86lgj9t8mi.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0104;6:ZdmTGWJm+uhL6mT5goj13bWcnNErcrhAih4D3gMBt/KEm/gdsiyPOIviH7Qaoh+gGeT8Y6uyvZj8Df3qys6+aETsKwwXSCII3JOzofS8ifebZLCOHHG2xE7sTODlYrBq5NJwJ5Poe7gRE9Y3lqiIMuxUPlLHFbYTIHVK6oTV1b3QKdzQeEC7AlL/lf/fyW++z2ZxE7f518HeWvzTWMx831436GLQLq1wfmPK4KBY5R7TmGd1ENV/BuUnvw+wAuSIyOKC2PfJR199V/2G2svD9NPSyjA9mPlre1gnqLFPG+zucsWpbDff6T3UHFYtngCna7FpwE2TkVukeZWdBF0X6UbnlZvrs7fnhSBVSmdsu78=;5:DhNbt0nPF+MCWufIZVJu3LF0cEGt0OHZ1rT4qlLjKXDFK89p0QzxVIMHZ1EKBTKEJOw5z4n7eSMDQKurEoSudglgnH+DJ9EEaSn9l0Qj4k0vzHBvNF6tU2tskYe+kMcoIg7iw1szFyQsYku3kgjB58jPMS+VUQevuoeDGWLjK2E=;24:q6mrq+xaHxluyGcN0X2TYYoCoxVzD6UnEJSsSva33CkxL0Qg4IWyii+gIQLLEuusOhVr5pCT3RUB+lvnyTkNU2hKAgW4r44caoRsEWyZFNI=;7:SkeUhJfHwJpN/Y2hfqGkoPySjylAmelnj0qCbiTt6EQGYI27zwS6uzBZ/qt/2B+Qktju3iMDoczNqpPDPL6T/+xbr3rULxJhCesB2g0uhF5fb59viq/D0W7kGBNWErHkBMhOLiRQWghuFQxHoDu5/CB0JDXZZAU5RC88bA+COkDy8wk+kX7lspvhud6oV00fdRYvHruYc+hgIWX7F7AUUd9S72JsPbHvPdI55bHSR+40P4n1cos8zqgvuEeQF0Qw x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 4ff49b3b-c7bd-4fb7-68ca-08d52b6a89f7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:AM3PR08MB0104; x-ms-traffictypediagnostic: AM3PR08MB0104: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(271806183753584); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0104;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0104; x-forefront-prvs: 04916EA04C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(24454002)(53936002)(8936002)(102836003)(6116002)(6486002)(101416001)(6306002)(3846002)(6436002)(14454004)(86362001)(2906002)(81166006)(6506006)(4326008)(25786009)(5250100002)(81156014)(66066001)(3660700001)(54906003)(68736007)(6512007)(3280700002)(229853002)(33656002)(6246003)(2900100001)(8676002)(305945005)(1411001)(5660300001)(53546010)(39060400002)(7736002)(82746002)(478600001)(50986999)(6916009)(316002)(189998001)(2950100002)(76176999)(54356999)(106356001)(36756003)(99286004)(105586002)(83716003)(97736004)(72206003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0104;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5455BAD3C8FDB14C80585A00A5542117@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff49b3b-c7bd-4fb7-68ca-08d52b6a89f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2017 14:18:12.1826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0104 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00253.txt.bz2 DQo+IE9uIDE0IE5vdiAyMDE3LCBhdCAxMToxNCwgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+IC0lLWlwYS5vOiAu Li9jb21tb24vJS5jDQo+PiArY29tbW9uLyUtaXBhLm86IC4uL2NvbW1vbi8l LmMNCj4+IAkkKElQQUdFTlRfQ09NUElMRSkgJDwNCj4+IAkkKFBPU1RDT01Q SUxFKQ0KPiANCj4gV2UgZG9uJ3QgaGF2ZSBjb21tb24vIGRpcmVjdG9yeSBp biBHREJzZXJ2ZXIgYnVpbGQgdHJlZSwgc28NCj4gY29tbW9uLyUtaXBhLm8g aXMgdXNlbGVzcy4gIFNlY29uZGx5LCB0aGlzICIlLWlwYS5vOiAuLi9jb21t b24vJS5jIg0KPiBpcyByZW1vdmVkLCBjb21tb24vKi5jIGZpbGVzIGNhbid0 IGJlIGJ1aWx0IGZvciBJUEEuICBQbGVhc2UgcmVtb3ZlIHRoaXMNCj4gY2hh bmdlLg0KPiANCj4gV2l0aCB5b3VyIHBhdGNoIGFwcGxpZWQsIGZhaWwgdG8g YnVpbGQgbGliaW5wcm9jdHJhY2Uuc28gb24geDg2XzY0LWxpbnV4Lg0KPiAN Cj4gZysrIC1zdGQ9Z251KysxMSAtc2hhcmVkIC1mUElDIC1XbCwtLXNvbmFt ZT1saWJpbnByb2N0cmFjZS5zbyAtV2wsLS1uby11bmRlZmluZWQgLWcgLU8y ICAgIC1JLiAtSS4uLy4uLy4uL2JpbnV0aWxzLWdkYi9nZGIvZ2Ric2VydmVy IC1JLi4vLi4vLi4vYmludXRpbHMtZ2RiL2dkYi9nZGJzZXJ2ZXIvLi4vY29t bW9uIC1JLi4vLi4vLi4vYmludXRpbHMtZ2RiL2dkYi9nZGJzZXJ2ZXIvLi4v cmVnZm9ybWF0cyAtSS4uLy4uLy4uL2JpbnV0aWxzLWdkYi9nZGIvZ2Ric2Vy dmVyLy4uIC1JLi4vLi4vLi4vYmludXRpbHMtZ2RiL2dkYi9nZGJzZXJ2ZXIv Li4vLi4vaW5jbHVkZSAtSS4uLy4uLy4uL2JpbnV0aWxzLWdkYi9nZGIvZ2Ri c2VydmVyLy4uL2dudWxpYi9pbXBvcnQgLUlidWlsZC1nbnVsaWItZ2Ric2Vy dmVyL2ltcG9ydCAgLVdhbGwgLVdwb2ludGVyLWFyaXRoIC1Xbm8tdW51c2Vk IC1XdW51c2VkLXZhbHVlIC1XdW51c2VkLWZ1bmN0aW9uIC1Xbm8tc3dpdGNo IC1Xbm8tY2hhci1zdWJzY3JpcHRzIC1XZW1wdHktYm9keSAtV3VudXNlZC1i dXQtc2V0LXBhcmFtZXRlciAtV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlIC1X bm8tc2lnbi1jb21wYXJlIC1Xbm8tbmFycm93aW5nIC1Xbm8tZXJyb3I9bWF5 YmUtdW5pbml0aWFsaXplZCAtV2Zvcm1hdC1ub25saXRlcmFsIC1XZXJyb3Ig LURHREJTRVJWRVIgXA0KPiAtc3RhdGljLWxpYnN0ZGMrKyAtc3RhdGljLWxp YmdjYyAgLVdsLC0tZHluYW1pYy1saXN0PS4uLy4uLy4uL2JpbnV0aWxzLWdk Yi9nZGIvZ2Ric2VydmVyL3Byb2Mtc2VydmljZS5saXN0IC1vIGxpYmlucHJv Y3RyYWNlLnNvIGF4LWlwYS5vIGNvbW1vbi11dGlscy1pcGEubyBlcnJvcnMt aXBhLm8gZm9ybWF0LWlwYS5vIHByaW50LXV0aWxzLWlwYS5vIHJlZ2NhY2hl LWlwYS5vIHJlbW90ZS11dGlscy1pcGEubyByc3AtbG93LWlwYS5vIHRkZXNj LWlwYS5vIHRyYWNlcG9pbnQtaXBhLm8gdXRpbHMtaXBhLm8gdmVjLWlwYS5v IGxpbnV4LWFtZDY0LWlwYS5vIGxpbnV4LXg4Ni10ZGVzYy1pcGEubyBhcmNo L2FtZDY0LWlwYS5vIC1sZGwgLXB0aHJlYWQNCj4gZysrOiBlcnJvcjogY29t bW9uLXV0aWxzLWlwYS5vOiBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5DQo+ IGcrKzogZXJyb3I6IGVycm9ycy1pcGEubzogTm8gc3VjaCBmaWxlIG9yIGRp cmVjdG9yeQ0KPiBnKys6IGVycm9yOiBmb3JtYXQtaXBhLm86IE5vIHN1Y2gg ZmlsZSBvciBkaXJlY3RvcnkNCj4gZysrOiBlcnJvcjogcHJpbnQtdXRpbHMt aXBhLm86IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnkNCj4gZysrOiBlcnJv cjogcnNwLWxvdy1pcGEubzogTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQ0K PiBnKys6IGVycm9yOiB2ZWMtaXBhLm86IE5vIHN1Y2ggZmlsZSBvciBkaXJl Y3RvcnkNCj4gTWFrZWZpbGU6NDEyOiByZWNpcGUgZm9yIHRhcmdldCAnbGli aW5wcm9jdHJhY2Uuc2/igJkgZmFpbGVkDQo+IA0KDQpUaGUgaWRlYSB3YXMg dGhhdCB0aGUgbmV3IGNvbW1vbiBydWxlIHdhcyBjb21waWxpbmcgdGhlIGZp bGVzIGZyb20NCmdkYnNlcnZlci8uLi9jb21tb24vLCBlLmcuIGdkYnNlcnZl ci8uLi9jb21tb24vY29tbW9uLXV0aWxzLmMuDQouLi5XaGljaCBJ4oCZdmUg bm93IGJyb2tlbi4uLg0KDQpPaywgcmVtb3ZlZCB0aGlzIGNoYW5nZSBmcm9t IHRoZSBuZXcgdmVyc2lvbiBiZWxvdy4NCg0KPiBUaGlzIGFuZCAoaHR0cHM6 Ly9zb3VyY2V3YXJlLm9yZy9tbC9nZGItcGF0Y2hlcy8yMDE3LTEwL21zZzAw ODg4Lmh0bWwpDQo+IHdvcnJ5IG1lIG1vcmUuICBZb3UgbWlzcyBzb21ldGhp bmcgaW1wb3J0YW50IGluIHRoZSBkZXZlbG9wbWVudA0KPiB3b3JrZmxvdyB0 byBtYWtlIHN1cmUgeW91ciBwYXRjaGVzIHBvc3RlZCBhcmUgd2VsbC10ZXN0 ZWQuDQo+IA0KDQpBcG9sb2dpZXMgZm9yIHRoaXMuIFBvc3NpYmx5IEkgZGlk buKAmXQgZG8gYSBjb21wbGV0ZSBtYWtlIGNsZWFuIGhlcmUuDQpCdXQgaXQg d2FzIGdsYXJpbmdseSBvYnZpb3VzIHdoZW4gSSByZWNvbXBpbGVkIGFnYWlu Lg0KDQpBbGFuLg0KDQpnZGJzZXJ2ZXI6DQoJKiBNYWtlZmlsZS5pbjogVXBk YXRlIGFyY2ggcnVsZXMuDQoJKiBjb25maWd1cmUuc3J2OiBFeHBsaWNpdGx5 IG1hcmsgYXJjaC8gIGZpbGVzLg0KDQoNCmRpZmYgLS1naXQgYS9nZGIvZ2Ri c2VydmVyL01ha2VmaWxlLmluIGIvZ2RiL2dkYnNlcnZlci9NYWtlZmlsZS5p bg0KaW5kZXggOGU3MzU2M2IxMDNmNzIwZGRkNWU3NzYwN2MzMTkwYTI5NTk5 MDNmNS4uMWQ1MTgxOTAxNDI3MGU0OGI2YTY3MGUzZGVmYTFkYzQ0OWUzYWJm NSAxMDA2NDQNCi0tLSBhL2dkYi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4NCisr KyBiL2dkYi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4NCkBAIC01NjcsNyArNTY3 LDcgQEAgYXJjaC8lLm86IC4uL2FyY2gvJS5jDQogCSQoSVBBR0VOVF9DT01Q SUxFKSAkPA0KIAkkKFBPU1RDT01QSUxFKQ0KDQotJS1pcGEubzogLi4vYXJj aC8lLmMNCithcmNoLyUtaXBhLm86IC4uL2FyY2gvJS5jDQogCSQoSVBBR0VO VF9DT01QSUxFKSAkPA0KIAkkKFBPU1RDT01QSUxFKQ0KDQpkaWZmIC0tZ2l0 IGEvZ2RiL2dkYnNlcnZlci9jb25maWd1cmUuc3J2IGIvZ2RiL2dkYnNlcnZl ci9jb25maWd1cmUuc3J2DQppbmRleCA1MTVjNmRjOGIzZTU3NTc0Mjg2MTQ5 ZWJkY2EzN2RhMTQ5MjE4YTM1Li44MmMzZGMyMzdjM2ZiNmJhZWIyYTcyY2Q5 ZWQ2NmQ4Yzc1NTZkNzJhIDEwMDY0NA0KLS0tIGEvZ2RiL2dkYnNlcnZlci9j b25maWd1cmUuc3J2DQorKysgYi9nZGIvZ2Ric2VydmVyL2NvbmZpZ3VyZS5z cnYNCkBAIC0xMzMsNyArMTMzLDcgQEAgY2FzZSAiJHt0YXJnZXR9IiBpbg0K IAkJCXNydl9saW51eF90aHJlYWRfZGI9eWVzDQogCQkJc3J2X2xpbnV4X2J0 cmFjZT15ZXMNCiAJCQlpcGFfb2JqPSJsaW51eC1pMzg2LWlwYS5vIGxpbnV4 LXg4Ni10ZGVzYy1pcGEubyINCi0JCQlpcGFfb2JqPSIke2lwYV9vYmp9IGkz ODYtaXBhLm8iDQorCQkJaXBhX29iaj0iJHtpcGFfb2JqfSBhcmNoL2kzODYt aXBhLm8iDQogCQkJOzsNCiAgIGlbMzQ1NjddODYtKi1seW54b3MqKQlzcnZf cmVnb2JqPSIiDQogCQkJc3J2X3RndG9iaj0ibHlueC1sb3cubyBseW54LWkz ODYtbG93Lm8gZm9yay1jaGlsZC5vIGZvcmstaW5mZXJpb3IubyINCkBAIC0z ODMsNyArMzgzLDcgQEAgY2FzZSAiJHt0YXJnZXR9IiBpbg0KIAkJCXNydl9s aW51eF90aHJlYWRfZGI9eWVzDQogCQkJc3J2X2xpbnV4X2J0cmFjZT15ZXMN CiAJCQlpcGFfb2JqPSJsaW51eC1hbWQ2NC1pcGEubyBsaW51eC14ODYtdGRl c2MtaXBhLm8iDQotCQkJaXBhX29iaj0iJHtpcGFfb2JqfSBhbWQ2NC1pcGEu byINCisJCQlpcGFfb2JqPSIke2lwYV9vYmp9IGFyY2gvYW1kNjQtaXBhLm8i DQogCQkJOzsNCiAgIHg4Nl82NC0qLW1pbmd3KikJc3J2X3JlZ29iaj0iIg0K IAkJCXNydl90Z3RvYmo9Ing4Ni1sb3cubyB4ODYtZHJlZ3MubyBpMzg3LWZw Lm8gd2luMzItbG93Lm8gd2luMzItaTM4Ni1sb3cubyINCg0KDQoNCg== >From gdb-patches-return-143382-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Nov 14 15:03:00 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 72500 invoked by alias); 14 Nov 2017 15:03:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 72450 invoked by uid 89); 14 Nov 2017 15:02:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=occasionally, Taken, qi, resending X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 15:02:52 +0000 Received: from svr-orw-mbx-04.mgc.mentorg.com ([147.34.90.204]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1eEcji-0002wB-JU from Paul_Carroll@mentor.com ; Tue, 14 Nov 2017 07:02:50 -0800 Received: from [172.30.88.65] (147.34.91.1) by SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 14 Nov 2017 07:02:47 -0800 Subject: Re: [PATCH] Assertion 'xfered>0' in target.c for remote connection To: Sergio Durigan Junior CC: "gdb-patches@sourceware.org" References: <1155839491.1748621.1509663923992.ref@mail.yahoo.com> <1155839491.1748621.1509663923992@mail.yahoo.com> <87lgjo6oqi.fsf@redhat.com> From: Paul Carroll Message-ID: Date: Tue, 14 Nov 2017 15:03:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87lgjo6oqi.fsf@redhat.com> Content-Type: multipart/mixed; boundary="------------392D72FD8DAC1FB13F9B631D" X-ClientProxiedBy: SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) To SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) X-SW-Source: 2017-11/txt/msg00254.txt.bz2 --------------392D72FD8DAC1FB13F9B631D Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-length: 5361 (Resending, since my previous response lost threading information in the mailing list) On 11/2/2017 10:11 PM, Sergio Durigan Junior wrote: > On Thursday, November 02 2017, pcarroll@codesourcery.com wrote: > >> We have a customer who is using a Corelis gdb server to connect to gdb. >> Occasionally, the gdb server will send a 0-byte block of memory for a read. >> When this happens, gdb gives an assertion from target.c: >> >> internal-error: target_xfer_partial: Assertion `*xfered_len > 0' failed. >> >> This problem is almost identical to that fixed in https://sourceware.org/ml/gdb-patches/2014-02/msg00636.html >> >> In this case, remote.c needs to be modified to return TARGET_XFER_EOF instead of TARGET_XFER_OK or TARGET_XFER_UNAVAILABLE when 0 bytes are transferred. > Thanks for the patch. A few comments below. BTW, your mail client > seems to have messed up with the formatting of the patch, removing TABs > and replacing them with whitespaces. Could you please send the patch > again, but using a client that handles patches better? Yep, resending here.  I don't think I've sent email to the mailing lists for years, so I needed to use a different mail client. >> The proposed fix would be: >> >> diff -rup fsf/gdb/ChangeLog fix/gdb/ChangeLog >> --- fsf/gdb/ChangeLog   2017-11-02 16:13:19.188615000 -0500 >> +++ fix/gdb/ChangeLog   2017-11-02 16:13:21.626754500 -0500 >> @@ -1,3 +1,10 @@ >> +2017-11-02  Paul Carroll  >> + >> +       PR gdb/22388 >> +       * remote.c (remote_write_bytes_aux, remote_read_bytes_1, >> +       remote_read_bytes, remote_write_qxfer, remote_xfer_partial): >> +       Return TARGET_XFER_EOF if size of returned data is 0. >> + > The ChangeLog entries need to be formatted with TABs instead of > whitespaces. But the text looks great. Taken care of in the new patch >> 2017-11-02  Yao Qi  >> >>         * frame.c (do_frame_register_read): Remove aspace. >> diff -rup fsf/gdb/remote.c fix/gdb/remote.c >> --- fsf/gdb/remote.c    2017-11-02 16:06:15.979408800 -0500 >> +++ fix/gdb/remote.c    2017-11-02 15:24:35.536391700 -0500 >> @@ -8264,7 +8264,7 @@ remote_write_bytes_aux (const char *head >>    /* Return UNITS_WRITTEN, not TODO_UNITS, in case escape chars caused us to >>       send fewer units than we'd planned.  */ >>    *xfered_len_units = (ULONGEST) units_written; >> -  return TARGET_XFER_OK; >> +  return (*xfered_len_units != 0) ? TARGET_XFER_OK : TARGET_XFER_EOF; >> } > This one looks correct to me. > >> /* Write memory data directly to the remote machine. >> @@ -8358,7 +8358,7 @@ remote_read_bytes_1 (CORE_ADDR memaddr, >>    decoded_bytes = hex2bin (p, myaddr, todo_units * unit_size); >>    /* Return what we have.  Let higher layers handle partial reads.  */ >>    *xfered_len_units = (ULONGEST) (decoded_bytes / unit_size); >> -  return TARGET_XFER_OK; >> +  return (*xfered_len_units != 0) ? TARGET_XFER_OK : TARGET_XFER_EOF; >> } > Likewise. > >> /* Using the set of read-only target sections of remote, read live >> @@ -8455,13 +8455,14 @@ remote_read_bytes (struct target_ops *op >>               res = remote_xfer_live_readonly_partial (ops, myaddr, memaddr, >>                                                        len, unit_size, xfered_len); >>               if (res == TARGET_XFER_OK) >> -               return TARGET_XFER_OK; >> +               return (*xfered_len != 0) ? TARGET_XFER_OK : TARGET_XFER_EOF; > remote_xfer_live_readonly_partial can only return TARGET_XFER_EOF or > what remote_read_bytes_1 return (which already takes care of the EOF > part), so I don't think you need this part here, although keeping it > wouldn't hurt. I got rid of this in the new patch, since it doesn't add anything, as you noted. >>               else >>                 { >>                   /* No use trying further, we know some memory starting >>                      at MEMADDR isn't available.  */ >>                   *xfered_len = len; >> -                 return TARGET_XFER_UNAVAILABLE; >> +                 return (*xfered_len != 0) ? >> +                   TARGET_XFER_UNAVAILABLE : TARGET_XFER_EOF; >>                 } >>             } >> >> @@ -10386,7 +10387,7 @@ remote_write_qxfer (struct target_ops *o >>    unpack_varlen_hex (rs->buf, &n); >> >>    *xfered_len = n; >> -  return TARGET_XFER_OK; >> +  return (*xfered_len != 0) ? TARGET_XFER_OK : TARGET_XFER_EOF; >> } >> >> /* Read OBJECT_NAME/ANNEX from the remote target using a qXfer packet. >> @@ -10687,7 +10688,7 @@ remote_xfer_partial (struct target_ops * >>    strcpy ((char *) readbuf, rs->buf); >> >>    *xfered_len = strlen ((char *) readbuf); >> -  return TARGET_XFER_OK; >> +  return (*xfered_len != 0) ? TARGET_XFER_OK : TARGET_XFER_EOF; >> } >> >> /* Implementation of to_get_memory_xfer_limit.  */ > The rest looks sane to me, but I'm not a global maintainer and cannot > approve your patch. Meanwhile I'd recommend resending the patch to fix > the formatting errors. > > Cheers, > --------------392D72FD8DAC1FB13F9B631D Content-Type: text/plain; charset="UTF-8"; name="gdb_0_mem_read_patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gdb_0_mem_read_patch" Content-length: 3282 ZGlmZiAtcnVwIGZzZi9nZGIvQ2hhbmdlTG9nIGZpeC9nZGIvQ2hhbmdlTG9n Ci0tLSBmc2YvZ2RiL0NoYW5nZUxvZwkyMDE3LTExLTAyIDE2OjEzOjE5LjE4 ODYxNTAwMCAtMDUwMAorKysgZml4L2dkYi9DaGFuZ2VMb2cJMjAxNy0xMS0w MiAxNjoxMzoyMS42MjY3NTQ1MDAgLTA1MDAKQEAgLTEsMyArMSwxMCBAQAor MjAxNy0xMS0wMiAgUGF1bCBDYXJyb2xsICA8cGNhcnJvbGxAY29kZXNvdXJj ZXJ5LmNvbT4KKworCVBSIGdkYi8yMjM4OAorCSogcmVtb3RlLmMgKHJlbW90 ZV93cml0ZV9ieXRlc19hdXgsIHJlbW90ZV9yZWFkX2J5dGVzXzEsCisJcmVt b3RlX3JlYWRfYnl0ZXMsIHJlbW90ZV93cml0ZV9xeGZlciwgcmVtb3RlX3hm ZXJfcGFydGlhbCk6CisJUmV0dXJuIFRBUkdFVF9YRkVSX0VPRiBpZiBzaXpl IG9mIHJldHVybmVkIGRhdGEgaXMgMC4KKwogMjAxNy0xMS0wMiAgWWFvIFFp ICA8eWFvLnFpQGxpbmFyby5vcmc+CiAKIAkqIGZyYW1lLmMgKGRvX2ZyYW1l X3JlZ2lzdGVyX3JlYWQpOiBSZW1vdmUgYXNwYWNlLgpkaWZmIC1ydXAgZnNm L2dkYi9yZW1vdGUuYyBmaXgvZ2RiL3JlbW90ZS5jCi0tLSBmc2YvZ2RiL3Jl bW90ZS5jCTIwMTctMTEtMDIgMTY6MDY6MTUuOTc5NDA4ODAwIC0wNTAwCisr KyBmaXgvZ2RiL3JlbW90ZS5jCTIwMTctMTEtMDMgMTM6MDE6MDQuOTUzMTM1 MTAwIC0wNTAwCkBAIC04MjY0LDcgKzgyNjQsNyBAQCByZW1vdGVfd3JpdGVf Ynl0ZXNfYXV4IChjb25zdCBjaGFyICpoZWFkCiAgIC8qIFJldHVybiBVTklU U19XUklUVEVOLCBub3QgVE9ET19VTklUUywgaW4gY2FzZSBlc2NhcGUgY2hh cnMgY2F1c2VkIHVzIHRvCiAgICAgIHNlbmQgZmV3ZXIgdW5pdHMgdGhhbiB3 ZSdkIHBsYW5uZWQuICAqLwogICAqeGZlcmVkX2xlbl91bml0cyA9IChVTE9O R0VTVCkgdW5pdHNfd3JpdHRlbjsKLSAgcmV0dXJuIFRBUkdFVF9YRkVSX09L OworICByZXR1cm4gKCp4ZmVyZWRfbGVuX3VuaXRzICE9IDApID8gVEFSR0VU X1hGRVJfT0sgOiBUQVJHRVRfWEZFUl9FT0Y7CiB9CiAKIC8qIFdyaXRlIG1l bW9yeSBkYXRhIGRpcmVjdGx5IHRvIHRoZSByZW1vdGUgbWFjaGluZS4KQEAg LTgzNTgsNyArODM1OCw3IEBAIHJlbW90ZV9yZWFkX2J5dGVzXzEgKENPUkVf QUREUiBtZW1hZGRyLAogICBkZWNvZGVkX2J5dGVzID0gaGV4MmJpbiAocCwg bXlhZGRyLCB0b2RvX3VuaXRzICogdW5pdF9zaXplKTsKICAgLyogUmV0dXJu IHdoYXQgd2UgaGF2ZS4gIExldCBoaWdoZXIgbGF5ZXJzIGhhbmRsZSBwYXJ0 aWFsIHJlYWRzLiAgKi8KICAgKnhmZXJlZF9sZW5fdW5pdHMgPSAoVUxPTkdF U1QpIChkZWNvZGVkX2J5dGVzIC8gdW5pdF9zaXplKTsKLSAgcmV0dXJuIFRB UkdFVF9YRkVSX09LOworICByZXR1cm4gKCp4ZmVyZWRfbGVuX3VuaXRzICE9 IDApID8gVEFSR0VUX1hGRVJfT0sgOiBUQVJHRVRfWEZFUl9FT0Y7CiB9CiAK IC8qIFVzaW5nIHRoZSBzZXQgb2YgcmVhZC1vbmx5IHRhcmdldCBzZWN0aW9u cyBvZiByZW1vdGUsIHJlYWQgbGl2ZQpAQCAtODQ2MSw3ICs4NDYxLDggQEAg cmVtb3RlX3JlYWRfYnl0ZXMgKHN0cnVjdCB0YXJnZXRfb3BzICpvcAogCQkg IC8qIE5vIHVzZSB0cnlpbmcgZnVydGhlciwgd2Uga25vdyBzb21lIG1lbW9y eSBzdGFydGluZwogCQkgICAgIGF0IE1FTUFERFIgaXNuJ3QgYXZhaWxhYmxl LiAgKi8KIAkJICAqeGZlcmVkX2xlbiA9IGxlbjsKLQkJICByZXR1cm4gVEFS R0VUX1hGRVJfVU5BVkFJTEFCTEU7CisJCSAgcmV0dXJuICgqeGZlcmVkX2xl biAhPSAwKSA/CisJCSAgICBUQVJHRVRfWEZFUl9VTkFWQUlMQUJMRSA6IFRB UkdFVF9YRkVSX0VPRjsKIAkJfQogCSAgICB9CiAKQEAgLTEwMzg2LDcgKzEw Mzg3LDcgQEAgcmVtb3RlX3dyaXRlX3F4ZmVyIChzdHJ1Y3QgdGFyZ2V0X29w cyAqbwogICB1bnBhY2tfdmFybGVuX2hleCAocnMtPmJ1ZiwgJm4pOwogCiAg ICp4ZmVyZWRfbGVuID0gbjsKLSAgcmV0dXJuIFRBUkdFVF9YRkVSX09LOwor ICByZXR1cm4gKCp4ZmVyZWRfbGVuICE9IDApID8gVEFSR0VUX1hGRVJfT0sg OiBUQVJHRVRfWEZFUl9FT0Y7CiB9CiAKIC8qIFJlYWQgT0JKRUNUX05BTUUv QU5ORVggZnJvbSB0aGUgcmVtb3RlIHRhcmdldCB1c2luZyBhIHFYZmVyIHBh Y2tldC4KQEAgLTEwNjg3LDcgKzEwNjg4LDcgQEAgcmVtb3RlX3hmZXJfcGFy dGlhbCAoc3RydWN0IHRhcmdldF9vcHMgKgogICBzdHJjcHkgKChjaGFyICop IHJlYWRidWYsIHJzLT5idWYpOwogCiAgICp4ZmVyZWRfbGVuID0gc3RybGVu ICgoY2hhciAqKSByZWFkYnVmKTsKLSAgcmV0dXJuIFRBUkdFVF9YRkVSX09L OworICByZXR1cm4gKCp4ZmVyZWRfbGVuICE9IDApID8gVEFSR0VUX1hGRVJf T0sgOiBUQVJHRVRfWEZFUl9FT0Y7CiB9CiAKIC8qIEltcGxlbWVudGF0aW9u IG9mIHRvX2dldF9tZW1vcnlfeGZlcl9saW1pdC4gICovCg== --------------392D72FD8DAC1FB13F9B631D--