From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6bn4LbM8HWroPi0AWB0awg (envelope-from ) for ; Mon, 01 Jun 2026 04:02:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A70651E0A3; Mon, 01 Jun 2026 04:02:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7C0B31E062 for ; Mon, 01 Jun 2026 04:02:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7E36B4BA2E12 for ; Mon, 1 Jun 2026 08:02:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E36B4BA2E12 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 124CB4BA2E0E for ; Mon, 1 Jun 2026 08:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 124CB4BA2E0E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 124CB4BA2E0E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780300950; cv=none; b=lDdTuun9xbzdoJmayKQhjb177IQ9w1TJ9C2idrEvB7y6iwa4MB2dYqZY8asdGDfr5Y5Q3cxOBCEk8XMb+WCPlAjSvMXNytsFnzETL3JnFDgLUHZYbM1tBYpv8qQRVfDyGdq5w4fPfRAKaj3CwfT6Z0k0VO66Ey7nixm2EZD0pzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780300950; c=relaxed/simple; bh=1/hKUU3fVfoNwzeCYqgcwbaP7qZ7/NW3HSvUgQ6Pmjc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=tenFYwwzgVfM66iXb8t0z0fmtkHRZHRgE6hCI7kmIn8DRIRw2h5YF2ISjoAWuq6CFYu05d3B04DlESbZvwqLuhAm/qd2edMKL8pAzsXrY6+0ukCo7k749Z5YwtpA8LfAYptPUaukHsObk6agohxo+Bluvlrjl+/BMCaJINBfcLg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXwvQ46L; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HtBmSyP3 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 124CB4BA2E0E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 014E266E67; Mon, 1 Jun 2026 08:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780300949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8j8+arhCmjJxpIMIp/8B575FkPA7ZPz0CJIi094c3A=; b=eXwvQ46L4qKl4tkaUjFNyJPLgnYb4ZBjdadHWSaDa/BUpZXm415VlbqsXVnQD4Y9A8GlGs h/EfLnW3gaQdt/68xa67eTuWitb7NgbpwTJ6jlITYpvlwwKgL7Vl8E/Q6bRZIZmbpuAdQO EGNtUwUuNdj+50+D6R8swf21Jc76sqA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780300949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8j8+arhCmjJxpIMIp/8B575FkPA7ZPz0CJIi094c3A=; b=HtBmSyP3FUDY35J87W7aEtSiDuYMg1Wg1TcBTvVFVoKAYOJcTfspjYMsi3ZOaLy8VrtkRz Rg94ER1vWYKQwGDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eXwvQ46L; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HtBmSyP3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780300949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8j8+arhCmjJxpIMIp/8B575FkPA7ZPz0CJIi094c3A=; b=eXwvQ46L4qKl4tkaUjFNyJPLgnYb4ZBjdadHWSaDa/BUpZXm415VlbqsXVnQD4Y9A8GlGs h/EfLnW3gaQdt/68xa67eTuWitb7NgbpwTJ6jlITYpvlwwKgL7Vl8E/Q6bRZIZmbpuAdQO EGNtUwUuNdj+50+D6R8swf21Jc76sqA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780300949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8j8+arhCmjJxpIMIp/8B575FkPA7ZPz0CJIi094c3A=; b=HtBmSyP3FUDY35J87W7aEtSiDuYMg1Wg1TcBTvVFVoKAYOJcTfspjYMsi3ZOaLy8VrtkRz Rg94ER1vWYKQwGDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DF7CF779A7; Mon, 1 Jun 2026 08:02:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id X+M6NZQ8HWpEdgAAD6G6ig (envelope-from ); Mon, 01 Jun 2026 08:02:28 +0000 Message-ID: <7168b9e1-3102-4484-928e-53b5e55ffdf4@suse.de> Date: Mon, 1 Jun 2026 10:02:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/symtab] Add assert in free_cached_comp_units constructor From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260527095715.2481440-1-tdevries@suse.de> <87pl2f5vsy.fsf@tromey.com> <83c3a4ea-9f74-4afe-8963-ce0ec9495a22@suse.de> Content-Language: en-US In-Reply-To: <83c3a4ea-9f74-4afe-8963-ce0ec9495a22@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 014E266E67 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/30/26 2:52 PM, Tom de Vries wrote: > On 5/28/26 6:43 PM, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> Detect this situation using an assert in the free_cached_comp_units >> Tom> constructor. >> >> Seems fine to me. > > Thanks for the review. > > I committed this, but afterwards ran into trouble on x86_64-linux with > test-cases gdb.ada/uninitialized-variable-record.exp and gdb.ada/ > uninitialized_vars.exp on x86_64-linux, so I've reverted this. > I've investigated this, and found that this is due to calls to load_cu in places other than dw2_do_instantiate_symtab. For test-case gdb.ada/uninitialized_vars.exp, it's dwarf2_fetch_die_loc_cu_off. I do wonder if ~free_cached_comp_units is a bit overeager, and should refrain from deleting cached comp units that were present at construction time. Anyway, the assert detected the use-after-free I created, but just doesn't hold in general. Thanks, - Tom > Thanks, > - Tom > >> >> Approved-By: Tom Tromey >> >> Tom >