From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id E9C613858D34
 for <gdb-patches@sourceware.org>; Sun, 19 Jul 2020 15:47:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E9C613858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 864A81E5F9;
 Sun, 19 Jul 2020 11:47:14 -0400 (EDT)
Subject: Re: [PATCH v2] Implement the skip_solib_resolver gdbarch hook for
 FreeBSD architectures.
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
References: <4ae8ff57-66bd-0e26-5bdf-46aabf4699a3@FreeBSD.org>
 <20200717225941.82442-1-jhb@FreeBSD.org>
From: Simon Marchi <simark@simark.ca>
Message-ID: <7167cf8f-aab0-ddf7-30ca-71e02a7fb740@simark.ca>
Date: Sun, 19 Jul 2020 11:47:11 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200717225941.82442-1-jhb@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Jul 2020 15:47:15 -0000

On 2020-07-17 6:59 p.m., John Baldwin wrote:
> The ELF runtime linker on all FreeBSD architectures uses the
> "_rtld_bind" entry point for unresolved PTL entries.  FreeBSD/mips has
> an additional entry point called "_mips_rtld_bind".
> 
> gdb/ChangeLog:
> 
> 	* fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
> 	(fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
> 	* fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
> 	* mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
> 	(mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
> 	method.

Thanks, this LGTM!

Simon