From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4X19JMdEgmnQVyYAWB0awg (envelope-from ) for ; Tue, 03 Feb 2026 13:56:07 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BzRWx5lH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 922401E0BA; Tue, 03 Feb 2026 13:56:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CD7FE1E08D for ; Tue, 03 Feb 2026 13:56:01 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5E5F44BA2E12 for ; Tue, 3 Feb 2026 18:56:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E5F44BA2E12 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BzRWx5lH Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B40F44BA2E0F for ; Tue, 3 Feb 2026 18:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B40F44BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B40F44BA2E0F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770144925; cv=none; b=AJGyKmbBmkKQ8VIVXSc6KF3fya4bGVY9CD0sNIJUtvFbRBQ/wVf3UiJZzYMYHNxBWpLNabgy08AuzstKn/zfALGNMuNUK/yokm4bGWrjtXEsqqI8ZTaBmrL7oC+i/fyfgkkaJhuI9p8hb1WbLpoVS1t0s5D/ocUKPAPuxBF3ZCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770144925; c=relaxed/simple; bh=m/nPS/dEV3L0CIjYb3LKmPTNfnwcJnHk8Jh78hrLhcA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=O3daAsKseOrR3c7nWlFDqJxUVIeAO8O3Nvu8GBTQ11UlhP23ItusA9vz6f7/etjgKjc1I7a/OgWVOsdW77PQEL2OFJCVUWuBMy0o5tZ4ycGQGl5+Wb4I2ZU69CqcP6TdDAsj4M2XubwevImSmYMtLF2frtTe5Y0zVEJran98KiE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B40F44BA2E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770144925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LkVtOjAzvJDs7hc63D97FAUynWU7H9HwcPdggQGQ32o=; b=BzRWx5lHy0imTPkuxE5kGDLeSV513gqgaBmBBqe/htuGq1xaoskqG0FFD0Nk/xdrfZ0OPL i+Ltu6irwOg0geZEc78+kze+dBE96hkDCctlHsrzzT1Bln6Ee6ediWojBToVDMpcG7/K1c tIHCmhRqepyp4ekojK5LQ7Y/qAY40j0= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-g1sLrueMPJKBML8gMDSbjw-1; Tue, 03 Feb 2026 13:55:19 -0500 X-MC-Unique: g1sLrueMPJKBML8gMDSbjw-1 X-Mimecast-MFC-AGG-ID: g1sLrueMPJKBML8gMDSbjw_1770144919 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-794105cd922so77051337b3.0 for ; Tue, 03 Feb 2026 10:55:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770144919; x=1770749719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LkVtOjAzvJDs7hc63D97FAUynWU7H9HwcPdggQGQ32o=; b=V8k1ihDRWemwdXUtCFhfb1M5oUxZVILY1gLqkVuFpb6o8l1Or4+xgQWY1Tjg3YhXfy NS7lQlOXTFlpo0kdhOWUV3aRUufR5k/2FLWaiiPx+3JX+ot5r2NAnPy3BsXrNyeD1mwP XeiFQIkVKmyzC9W+a6ghMlupvkoUSwgXiIpEBlqJVzjaufW3Yh9HFPaYy9IAfMpx3uti vbpCYi3dgBp/0NDS/D98jY2jMsW10zs6SWnXgvOJPxmnG7ohoKTKQhA5bB49kQHeIGeb 08miLdbehnrW+EiiWdF/V3tsasodqgHQt7PvfoYEoSEWHqorJXL37j75BuMNjVkW4BMN uHOQ== X-Gm-Message-State: AOJu0YyEGetiFLHLoeT8K2EqCosUzqN1WVrjXqgzcXt6qHvFfZUAe7/9 kwk/FaJxJn1ua/7+HrRuf/W33DRXTuNDuK8pFYl5OP8iP+r/Llfo3XaCpd9rWz5lIur2+/jMKth EiVSq1ldLHNzxWhdpseeuxBhyyAvJiP6kYck0g5lls9M5Bmo6NsccAGRmjy4BS1U= X-Gm-Gg: AZuq6aLJ+YRbcyQht8TloaOQmgplwYuS7QVh0MujGhSDEQL0tPCfMnPLNo7qtgvs8Vm BF7zfDErca7dJrtDK32BLBLRkck8UL5/aNj6o1KWNPFLzZ0BBNi0ez6aOnHkS3AOGmhGWb6eueu m1ptwTGDOObjrorGSKiqEnI3tJNOBtIl4/1JIFYgmfFSRt/g7QVU8BQ2jwkxSRYP255AR/HPVd2 ndOJSb++RVfa7WZdqyIylGnSmdYJkuJMmzEcgHsET47BGJBFzHBXKITHFTuSudP/3eQZEP59+30 UYyOXMMjBARin6tLr6bo13N4yhlLEJa0rRUsS7EB1Ob+6fDXAsc5ViUWzZMLikQjjQLP2ysD2Bh N/JAo9+anHoPXeX2k+LEUnA== X-Received: by 2002:a53:c5cf:0:b0:644:5419:2e73 with SMTP id 956f58d0204a3-649db4a094emr384377d50.76.1770144919302; Tue, 03 Feb 2026 10:55:19 -0800 (PST) X-Received: by 2002:a53:c5cf:0:b0:644:5419:2e73 with SMTP id 956f58d0204a3-649db4a094emr384368d50.76.1770144918930; Tue, 03 Feb 2026 10:55:18 -0800 (PST) Received: from ?IPV6:2804:14d:8084:a5b1::1002? ([2804:14d:8084:a5b1::1002]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649dc494629sm190035d50.2.2026.02.03.10.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 10:55:18 -0800 (PST) Message-ID: <71556744-0b46-4d56-acb4-11ded5854eb8@redhat.com> Date: Tue, 3 Feb 2026 15:55:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260202203404.708144-1-guinevere@redhat.com> <87sebh7vhh.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87sebh7vhh.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xGKwoR5XuZAiiBeqzOPXF_haJbKJ9Fl-m9QWuVkMBZQ_1770144919 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/3/26 11:27 AM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> - result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE); > Guinevere> + result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE) > Guinevere> + == 0; > > Wrapped expressions like this need the RHS parenthesized. > > thanks, > Tom > I ended up changing it to result = gdb_filename_fnmatch                 (m_file.c_str (), fullname, FNM_NOESCAPE) == 0; I find that much prettier, if it is alright with our coding style -- Cheers, Guinevere Larsen It/she