From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1893 invoked by alias); 16 Oct 2003 15:54:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1752 invoked from network); 16 Oct 2003 15:54:24 -0000 Received: from unknown (HELO bilbo.inter.net.il) (192.114.186.18) by sources.redhat.com with SMTP; 16 Oct 2003 15:54:24 -0000 Received: from zaretski ([80.230.156.210]) by bilbo.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id BQR37402; Thu, 16 Oct 2003 17:53:19 +0200 (IST) Date: Thu, 16 Oct 2003 15:54:00 -0000 From: "Eli Zaretskii" To: Elena Zannoni Message-Id: <7137-Thu16Oct2003174852+0200-eliz@elta.co.il> CC: drow@mvista.com, gdb-patches@sources.redhat.com In-reply-to: <16270.44057.973638.26816@localhost.redhat.com> (message from Elena Zannoni on Thu, 16 Oct 2003 10:32:57 -0400) Subject: Re: RFA: Breakpoint infrastructure cleanups [0/8] Reply-to: Eli Zaretskii References: <3F846B04.2070801@redhat.com> <3F85B4AC.7000000@redhat.com> <20031014013831.GB6118@nevyn.them.org> <3F8C18DD.3020508@redhat.com> <20031014155126.GA10669@nevyn.them.org> <3F8C605E.1060604@redhat.com> <3F8D6181.6070409@redhat.com> <3F8D8FEB.8020305@redhat.com> <16269.39677.813094.890124@localhost.redhat.com> <2719-Thu16Oct2003085405+0200-eliz@elta.co.il> <20031016131144.GA14202@nevyn.them.org> <16270.44057.973638.26816@localhost.redhat.com> X-SW-Source: 2003-10/txt/msg00544.txt.bz2 > From: Elena Zannoni > Date: Thu, 16 Oct 2003 10:32:57 -0400 > > Just occurred to me that maybe the user sometimes would want to set a > breakpoint in just one particular instance of an inlined function, we > should still allow that. How about the following? (gdb) break inline_foo Breakpoint 5 set at inline_foo, which has multiple locations. Say "info breakpoint 5" for more details. (gdb) info break 5 Num Type Enb Address What 5 sw breakpoint y 0x8040222 inlined into foo 5 sw breakpoint y 0x8040822 inlined into bar 5 sw breakpoint y 0x8040852 inlined into boring_loop (gdb) delete 5 *0x8040852 > I.e. should setting the multiple breakpoints > be the default? I think this is the best default, yes. Alternatively, we could show all possible addresses where the requested breakpoint coulod be set and ask the user to select which ones she wants, like this: (gdb) break inline_foo Function inline_foo is inlined into multiple locations: Address Location 0x8040222 inlined into foo 0x8040822 inlined into bar 0x8040852 inlined into boring_loop Please use "break *address" to set breakpoints at one or more of these (gdb) break *0x8040822 *0x8040822