From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44182 invoked by alias); 28 Apr 2017 15:03:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44172 invoked by uid 89); 28 Apr 2017 15:03:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:249 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 15:03:42 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E792FC05AA43; Fri, 28 Apr 2017 15:03:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E792FC05AA43 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E792FC05AA43 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 497EB171AB; Fri, 28 Apr 2017 15:03:43 +0000 (UTC) Subject: Re: [PATCH 2/4] Simplify regcache_dup To: Yao Qi , gdb-patches@sourceware.org References: <1493152106-3246-1-git-send-email-yao.qi@linaro.org> <1493389594-24434-1-git-send-email-yao.qi@linaro.org> <1493389594-24434-3-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <70e09487-4312-e09b-bb51-3e1f168a9d41@redhat.com> Date: Fri, 28 Apr 2017 15:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1493389594-24434-3-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00788.txt.bz2 On 04/28/2017 03:26 PM, Yao Qi wrote: > regcache_dup, in fact, is to create a readonly regcache from a > non-readonly regcache. This patch adds an assert that src is not > readonly. LGTM. Thanks, Pedro Alves