From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83290 invoked by alias); 9 Aug 2017 14:10:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83273 invoked by uid 89); 9 Aug 2017 14:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 14:10:03 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2BC3A4334DE; Wed, 9 Aug 2017 14:10:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2BC3A4334DE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30C7E95A77; Wed, 9 Aug 2017 14:10:00 +0000 (UTC) Subject: Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string) To: Yao Qi References: <20170807201821.25207-1-alexlindsay239@gmail.com> <86k22dyno6.fsf@gmail.com> <2c88c7cb-dca8-7bd7-fe01-ee0c4a9d0e94@redhat.com> <2675604a-4460-81e3-93f3-21e34727fe12@redhat.com> <868tiszwmb.fsf@gmail.com> Cc: Alex Lindsay , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <708316e9-712a-828e-7856-e6808d240cf2@redhat.com> Date: Wed, 09 Aug 2017 14:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <868tiszwmb.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00182.txt.bz2 On 08/09/2017 02:41 PM, Yao Qi wrote: > Pedro Alves writes: > > Patch is good to me. > >> - n = cp_comp_to_string (&newobj, 100); >> + gdb::unique_xmalloc_ptr n = cp_comp_to_string (&newobj, 100); > > Nit, it is too long. Fixed and pushed, thanks. Pedro Alves