From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129092 invoked by alias); 14 Aug 2017 14:02:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129061 invoked by uid 89); 14 Aug 2017 14:02:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:46ef X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 14:02:50 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27D49C0B7708; Mon, 14 Aug 2017 14:02:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 27D49C0B7708 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56847721CD; Mon, 14 Aug 2017 14:02:48 +0000 (UTC) Subject: Re: [RFA 1/2] Fix two regressions in scalar printing To: Tom Tromey References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-2-tom@tromey.com> <22c48f9e-ec2c-850d-91d3-c6a3ea8cdb11@redhat.com> <871spjufnv.fsf@pokyo> <871sow9scp.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <707a03e4-46ef-cea9-f098-cc687b02d31e@redhat.com> Date: Mon, 14 Aug 2017 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <871sow9scp.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00295.txt.bz2 On 07/31/2017 11:03 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Yeah, that seems OK to me GDB-output-wise. "You get what you ask > Pedro> for". > > Here is an updated version of this patch, that (I think) implements what > was discussed in this thread. > > I regtested it on the buildbot. > > Let me know what you think. Sorry for dropping the ball on this. I wanted to be sure that we have tests for the (gdb) p /u -1 $1 = 4294967295 (gdb) p /d (unsigned long long) -1 $2 = -1 etc. issues discussed earlier. Do you know whether there's some tests for that already somewhere, but might have simply been missed before for running both patches together? > +# Regression test for PR gdb/21675 > +proc test_radices {} { > + gdb_test "print/o 16777211" " = 077777773" > + gdb_test "print/d 1.5" " = 1\[^.\]" > + gdb_test "print/u 1.5" " = 1\[^.\]" What's the reason for the "\[^.\]" part of the regexes? What's that trying to match? Why not simply " = 1" ? > +} > + > proc test_print_all_chars {} { > global gdb_prompt Thanks, Pedro Alves