From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3854 invoked by alias); 29 Sep 2009 16:12:37 -0000 Received: (qmail 3841 invoked by uid 22791); 29 Sep 2009 16:12:34 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-gx0-f210.google.com (HELO mail-gx0-f210.google.com) (209.85.217.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 16:12:30 +0000 Received: by gxk2 with SMTP id 2so3651850gxk.4 for ; Tue, 29 Sep 2009 09:12:28 -0700 (PDT) Received: by 10.151.87.1 with SMTP id p1mr10435691ybl.116.1254240748718; Tue, 29 Sep 2009 09:12:28 -0700 (PDT) Received: from xpjpn (pool-71-111-147-240.ptldor.dsl-w.verizon.net [71.111.147.240]) by mx.google.com with ESMTPS id 14sm56290gxk.6.2009.09.29.09.12.26 (version=SSLv3 cipher=RC4-MD5); Tue, 29 Sep 2009 09:12:27 -0700 (PDT) From: Caz Yokoyama To: "'Joel Brobecker'" Cc: "'Pedro Alves'" , References: <20090923004802.GA20859@adacore.com> <9ECED0F0DCF04CC185B027503876430D@xpjpn> <20090925160627.GB5077@adacore.com> <66E35EA6599040F894D040E4F50389D0@xpjpn> <535d47e30909260627n662135a1hf6d1a0bb33368b3a@mail.gmail.com> <20090929015830.GJ9003@adacore.com> <1724490614004CEB9EE1A091A151E05B@xpjpn> <20090929042226.GK9003@adacore.com> <2C14068798BA41219F3603CDD24C8BC0@xpjpn> <20090929051929.GL9003@adacore.com> Subject: RE: symbolic debug of loadable modules with kgdb light Date: Tue, 29 Sep 2009 16:12:00 -0000 Message-ID: <7063C3E99BE344B2B98EDC0318ED852A@xpjpn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit In-Reply-To: <20090929051929.GL9003@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00920.txt.bz2 Hello Joel, Do you think we have to check correctness of user input for interrupt_sequence? Setting-up debugging environment of Linux device driver by gdb is not a trivial task for the first timer. Connect serial port, validate its connection, modify menu.lst, reboot, re-compile device driver with -g -O0. It took 2 weeks in my case. I recently consults 2 people who set-up Linux device driver debugging environment who failed. The people who debug device driver are not tape monkeys. They prefer flexibility. At the same time, almost only people who touch interrupt_sequence are kernel developers. Therefore, I prefer send_interrupt_sequence () which does not have kernel dependency and has flexibility of user setting. -caz -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com] Sent: Monday, September 28, 2009 10:19 PM To: Caz Yokoyama Cc: 'Pedro Alves'; gdb-patches@sourceware.org Subject: Re: symbolic debug of loadable modules with kgdb light > I know Magic SysRq is the one for Linux kernel. I planned to propose BREAK > for Xen hypervisor if my patch were approved. I don't know what > interrupt_sequence is on other OSes. However, I believe that introducing the > possible variations into gdb is not your intention. You don't want to change > the code when OS changes its interrupt_sequence or supporting new OS. In my opinion, if you have a debugger that works with BREAK, this will help supporting your suggestion to use BREAK. If you want extensibility while at the same time being able to check the value entered by the user, then perhaps the solution is with the use of an XML file, similar to what has been done for the "catch syscall" command. I am not very familiar with this part of the debugger, but other maintainers are. However, I think you're worriying about something that may or may not become an issue. I'm not saying it is a bad thing, but you have something that's very close to acceptable and will work for your current situation (current Linux kernel). Was it Lean Programming that said fix a weakness only when it becomes an issue? With the current proposed user interface, I believe we should be able to expand the implementation to accomodate other various sequences. > >Please let us also know if you'd prefer someone else to review your > patches. > I am new to gdb mailing list. I know nobody who is a maintainer of gdb. What I meant to imply is that, if you think there is a problem with my reviews, I can ask someone else from the group of maintainers to take over this thread. -- Joel