From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36647 invoked by alias); 27 Jul 2017 16:34:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36633 invoked by uid 89); 27 Jul 2017 16:34:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 16:34:24 +0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v6RGYKXG023972 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jul 2017 16:34:20 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v6RGYJtQ031477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jul 2017 16:34:20 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v6RGYJwk007444; Thu, 27 Jul 2017 16:34:19 GMT Received: from [10.159.130.167] (/10.159.130.167) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 27 Jul 2017 09:34:19 -0700 Subject: Re: [PATCH v4] gdb: ADI support To: Yao Qi Cc: gdb-patches@sourceware.org References: <1500424890-112103-1-git-send-email-weimin.pan@oracle.com> <86o9s8pmyg.fsf@gmail.com> <86d18mqgd1.fsf@gmail.com> From: Wei-min Pan Message-ID: <7062f348-98f9-fef6-aa76-02308abf9c01@oracle.com> Date: Thu, 27 Jul 2017 16:34:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <86d18mqgd1.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00425.txt.bz2 On 7/27/2017 4:16 AM, Yao Qi wrote: > Wei-min Pan writes: > >>>> +########################################## >>>> +set newadi "7" >>>> +gdb_test "adi x shmaddr" "" "examine ADI" >>> Can you match the output? >> Here are the results of running this new test: >> > That is not what I mean. Your test leaves the PATTERN > (the 2nd argument) empty, > > gdb_test "adi x shmaddr" "" "examine ADI" > > so it doesn't test much. You need to add PATTERN to match the expected > output from command "adi x shmaddr". The first "adi x shmaddr" command is mainly used to test that the ADI information is available at the address. Its value which can be anything is not tested. The second "examine" command, on the other hand, makes sure the new ADI version tag is being set correctly at the address. > >> % make check TESTS="gdb.arch/sparc64-adi.exp" >> ... >> ... >> >> === gdb tests === >> >> Schedule of variations: >> unix >> >> Running target unix >> Using /usr/share/dejagnu/baseboards/unix.exp as board description file >> for target. >> Using /usr/share/dejagnu/config/unix.exp as generic interface file for >> target. >> Using ~/binutils-gdb/gdb/testsuite/config/unix.exp as >> tool-and-target-specific interface file. >> Running ~/binutils-gdb/gdb/testsuite/gdb.arch/sparc64-adi.exp ... >> >> === gdb Summary === >> >> # of expected passes 7 >> ...