From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15755 invoked by alias); 18 Jan 2017 15:02:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15721 invoked by uid 89); 18 Jan 2017 15:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:79d1596, H*f:sk:2b52597, H*i:sk:2b52597, H*MI:sk:2b52597 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jan 2017 15:01:59 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cTrkL-0002kQ-Jy from Luis_Gustavo@mentor.com ; Wed, 18 Jan 2017 07:01:57 -0800 Received: from [172.30.8.199] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 18 Jan 2017 07:01:54 -0800 Reply-To: Luis Machado Subject: Re: [PATCH 1/6] New function null_stream References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-2-git-send-email-yao.qi@linaro.org> <20170118144506.GM28060@E107787-LIN> <79d15965-fd1c-5cff-54f1-d6b7d2e6b884@codesourcery.com> <2b52597c046b688cca11d55ac12cfb04@polymtl.ca> To: Simon Marchi CC: Yao Qi , From: Luis Machado Message-ID: <70308951-95e4-a628-0a71-1526f2963640@codesourcery.com> Date: Wed, 18 Jan 2017 15:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <2b52597c046b688cca11d55ac12cfb04@polymtl.ca> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00346.txt.bz2 On 01/18/2017 08:57 AM, Simon Marchi wrote: > On 2017-01-18 09:53, Luis Machado wrote: >> We're setting stream to NULL at the top of the function and then >> checking if it is NULL (it obviously is) right after that? Am i >> missing something? > > The "static" :). Oh, that's what i was missing! Can't we have a clearer way of reusing this stream? It looks cryptic this way (at least i think it looks cryptic).