From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9310 invoked by alias); 13 Mar 2019 15:31:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9273 invoked by uid 89); 13 Mar 2019 15:31:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.221.68, HX-Languages-Length:387, H*RU:209.85.221.68 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Mar 2019 15:31:01 +0000 Received: by mail-wr1-f68.google.com with SMTP id g18so2499500wru.3 for ; Wed, 13 Mar 2019 08:31:01 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id h137sm6618288wmg.41.2019.03.13.08.30.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 08:30:59 -0700 (PDT) Subject: Re: [PATCH] Factor out mi_ui_out instantiation logic To: Simon Marchi , gdb-patches@sourceware.org References: <20190313030218.21452-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <7017ba96-406a-d510-2456-a4289e30ecca@redhat.com> Date: Wed, 13 Mar 2019 15:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190313030218.21452-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00269.txt.bz2 On 03/13/2019 03:02 AM, Simon Marchi wrote: > gdb/ChangeLog: > > * mi/mi-out.h (mi_out_new): Change parameter to const char *. > * mi/mi-out.c (mi_out_new): Change parameter to const char *, > instantiate mi_ui_out based on interpreter name. > * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new. LGTM. Thanks, Pedro Alves