From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49598 invoked by alias); 14 Apr 2017 03:39:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49054 invoked by uid 89); 14 Apr 2017 03:38:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Apr 2017 03:38:20 +0000 Received: by simark.ca (Postfix, from userid 33) id B1BFE1E4A2; Thu, 13 Apr 2017 23:38:20 -0400 (EDT) To: Yao Qi Subject: Re: [PATCH 4/9] Remove addr_size field from struct piece_closure X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Apr 2017 03:39:00 -0000 From: Simon Marchi Cc: Andreas Arnez , gdb-patches@sourceware.org In-Reply-To: <86inm8ad1y.fsf@gmail.com> References: <1491586736-21296-1-git-send-email-arnez@linux.vnet.ibm.com> <1491586736-21296-5-git-send-email-arnez@linux.vnet.ibm.com> <86inm8ad1y.fsf@gmail.com> Message-ID: <6fef62cbc51a5ff8f23b92612cf267ac@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00459.txt.bz2 On 2017-04-13 05:10, Yao Qi wrote: > Andreas Arnez writes: > >> The addr_size field in the piece_closure data structure is a relic >> from >> before introducing the typed DWARF stack. It is obsolete now. This >> patch >> removes it. >> >> gdb/ChangeLog: >> >> * dwarf2loc.c (struct piece_closure) : Remove field. >> (allocate_piece_closure): Drop addr_size parameter. >> (dwarf2_evaluate_loc_desc_full): Adjust call to >> allocate_piece_closure. > > LGTM. Since you are planning on making a v2, I think it's better if you check it in right now to get it out of the way (it could be obvious anyway). Simon