From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y3CwAUcRm2laZQUAWB0awg (envelope-from ) for ; Sun, 22 Feb 2026 09:23:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771770182; bh=23sH3+Iss/Aro7bliNmL2UkqSZ92/Ub/KXtg8v6W9SI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CZ02UHr6NhYBnteXrPPaPyQ2hKwdCpCNlt1Uxu7omx/VNc7BBr40SSxB46kNkn9ih MMHC7CqvaUCvMvRCrAsqtvu4dUsEe3yLt+QzBHtgcWHXpWIpwa2BgjH26SX5MICPd8 RwZ+26qqTEd5L7vBBHRdvauRz3BuUHIxgZ/bRtwo= Received: by simark.ca (Postfix, from userid 112) id DF1B41E089; Sun, 22 Feb 2026 09:23:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=CcLqEv9Z; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 417551E089 for ; Sun, 22 Feb 2026 09:23:01 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B12214BA23D3 for ; Sun, 22 Feb 2026 14:22:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B12214BA23D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=CcLqEv9Z Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4646F4BA23C5 for ; Sun, 22 Feb 2026 14:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4646F4BA23C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4646F4BA23C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771770144; cv=none; b=wEBiigYUGoh6+y4qZp8PrWf2+HAHwjddzM4LBfJFU/1p2ACsEdiP7R/wSryuabcKg27OZml+mWYnjBIzi+/CqF+k3BjgvNbas6XbCQgKSTB15HrqL47i0P6jBD29GG+D474vKpIZ7OcwCs0iZccdZOjILc+vzvILvl54qUu3FXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771770144; c=relaxed/simple; bh=23sH3+Iss/Aro7bliNmL2UkqSZ92/Ub/KXtg8v6W9SI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Oh7CJ714IXH9mwSLW7hcXd3FPiYw7PiPCVhlZdIZI9Lnkw8Z/rjWScr+PKJAWz3nRvA2GsYfTkxqu/srtfoeAaQFD1EgEZtJFr7WC3Bj+Ys96l24hJv5pXg/Zy8a/Jh6dlEp32a4w9YFVFfOSS4xaKrAeuO8VielsRhdYJAoG44= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4646F4BA23C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771770142; bh=23sH3+Iss/Aro7bliNmL2UkqSZ92/Ub/KXtg8v6W9SI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CcLqEv9Z+5ppIttU0jA793X88fv2fEeMM7B86Q1uIRxZcBe16hquvjiGsEhhHpRB5 gjPmvrIcbWED4k8BKNDTLdwgNE2OxTFe8qhlSICrud6imtVHnzi9V+hnOwagrEBrsi Uk7OgOm+iyqUTuz9LQAjCuaHXLWGsvF7sdOq/GDc= Received: by simark.ca (Postfix) id BB6891E089; Sun, 22 Feb 2026 09:22:21 -0500 (EST) Message-ID: <6fbf151f-2213-475a-a5d5-08911a4b22bc@simark.ca> Date: Sun, 22 Feb 2026 09:22:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] GDB: Add gdb/arch/aarch64-pauth-linux.h To: Luis , Thiago Jung Bauermann , gdb-patches@sourceware.org Cc: Chris Packham , Tom Tromey References: <20260217060106.1906312-1-thiago.bauermann@linaro.org> <20260217060106.1906312-2-thiago.bauermann@linaro.org> <201211e6-3061-4b7d-8e0c-6a9875922bcd@gmail.com> <8f7b78e6-5f49-4243-8f89-a48ee2884266@simark.ca> <63d2e095-b170-4316-90a8-c62c71c64c40@gmail.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <63d2e095-b170-4316-90a8-c62c71c64c40@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-22 05:06, Luis wrote: > I don´t recall the discussions touching renaming/moving of these > constants. But I see your point. I just don´t think we should block > this series from going in on that particular snag. We should try a > refactoring as a follow on. > This is what I was referring to, from Thiago: Ok. While fixing this, I noticed that gdb/arch/aarch64-gcs-linux.h also contains: /* Feature check for Guarded Control Stack. */ #ifndef HWCAP_GCS #define HWCAP_GCS (1ULL << 32) #endif which can be said to be an implicit dependency on an arch-specific include file (since it relies on such file defining or not HWCAP_GCS). Also, on non-AArch64 systems it relies on them not having by coincidence an unrelated hardware capability bit also named HWCAP_GCS... I fixed this in v2 by renaming the macro to AARCH64_HWCAP_GCS and defining it unconditionally (following the existing example of AARCH64_HWCAP_PACA). From: https://inbox.sourceware.org/gdb-patches/87qzqkx8l1.fsf@linaro.org/T/#mbe0d3d5a2802f4f88abe907874ed44c063666639 I think that was a good idea, and it seems like we went backwards from there? > On the naming, I don´t mind adding an AARCH64 prefix, but I find it > unlikely we will run into a naming collision given BSD uses equivalent > constants. Again, not disputing the matter of what is technically > correct or not. This is already a refactoring / cleanup series, it's not harder to do it right from the start. Simon