From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91181 invoked by alias); 7 Nov 2018 22:41:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91150 invoked by uid 89); 7 Nov 2018 22:41:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*f:sk:404ed12 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 22:41:42 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8688A403F; Wed, 7 Nov 2018 22:41:40 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-54.rdu2.redhat.com [10.10.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AC8E68D2D; Wed, 7 Nov 2018 22:41:39 +0000 (UTC) Subject: Re: Small typo in iconv.m4 To: Hafiz Abid Qadeer , gcc-patches@gcc.gnu.org Cc: gdb-patches@sourceware.org, binutils@sourceware.org References: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <6fa2e271-40d3-7b9c-1056-c180b2f61b98@redhat.com> Date: Wed, 07 Nov 2018 22:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00110.txt.bz2 On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: > Hi All, > I was investigating a character set related problem with windows hosted > GDB and I tracked it down to a typo in iconv.m4. This typo caused > libiconv detection to fail and related support was not built into gdb. > > The problem is with the following line. > CPPFLAGS="$LIBS $INCICONV" > which should have been > CPPFLAGS="$CPPFLAGS $INCICONV" > > OK to commit the attached patch? > > 2018-11-06 Hafiz Abid Qadeer > > * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. > Append $INCICONV to it. > * gcc/configure: Regenerate. > * libcpp/configure: Likewise. > * libstdc++-v3/configure: Likewise. > * intl/configure: Likewise. > > Thanks, > THanks. I wasn't sure if you had commit privs, so I went ahead and installed the patch. Jeff