From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 51B1B3857807 for ; Tue, 25 Aug 2020 14:55:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 51B1B3857807 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 232DBAD0B; Tue, 25 Aug 2020 14:56:07 +0000 (UTC) Subject: Re: [PATCH] gdb/testsuite: fix gdb.base/ui-redirect.exp pattern (gdb/26532) To: Simon Marchi , gdb-patches@sourceware.org References: <20200825132750.15105-1-simon.marchi@efficios.com> <2ee8506c-2464-01a3-efa4-c5ec12786b2e@efficios.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <6f8a87d1-489b-fb00-9f86-4584e0510557@suse.de> Date: Tue, 25 Aug 2020 16:55:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2ee8506c-2464-01a3-efa4-c5ec12786b2e@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 14:55:38 -0000 On 8/25/20 4:49 PM, Simon Marchi wrote: > On 2020-08-25 10:35 a.m., Tom de Vries wrote: >> On 8/25/20 3:27 PM, Simon Marchi wrote: >>> Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the >>> debug output format for `set debug infrun 1`. It broke test >>> gdb.base/ui-redirect.exp, which I missed: >>> >>> FAIL: gdb.base/ui-redirect.exp: debugging: continue >>> >> >> How about the other fail: >> ... >> FAIL: gdb.threads/stepi-random-signal.exp: stepi (no random signal) >> ... >> >> ? > > Oh, I missed your second message. Damn, I updated this test, changed the output format > later and forgot to update the test again.> See patch below. > > > From fc6c77211da34d18c2285347b6e400a3cd055b9f Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Tue, 25 Aug 2020 10:41:56 -0400 > Subject: [PATCH] gdb/testsuite: fix gdb.threads/stepi-random-signal.exp > pattern > > Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the > debug output format for `set debug infrun 1`. The test > gdb.threads/stepi-random-signal.exp uses that debug output, and was > updated, but not correctly. It results in this failure: > > FAIL: gdb.threads/stepi-random-signal.exp: stepi (no random signal) > > Fix it by adjusting the pattern in the test. > Ack, I've tested both patches, and the FAILs are gone. This patch could also use the PR line, not sure if you want to commit it separately. Anyway, LGTM. Thanks, - Tom > gdb/testsuite/ChangeLog: > > * gdb.threads/stepi-random-signal.exp: Update pattern. > > Change-Id: If5fa525e9545e32a286effe6a6184358374bd37c > --- > gdb/testsuite/gdb.threads/stepi-random-signal.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.threads/stepi-random-signal.exp b/gdb/testsuite/gdb.threads/stepi-random-signal.exp > index fa20f38ba61e..9a8b38c2acf5 100644 > --- a/gdb/testsuite/gdb.threads/stepi-random-signal.exp > +++ b/gdb/testsuite/gdb.threads/stepi-random-signal.exp > @@ -87,7 +87,7 @@ set seen 0 > > set test "stepi" > if {[gdb_test_multiple "stepi" "$test" { > - -re "infrun: handle_signal_stop: random signal" { > + -re {\[infrun\] handle_signal_stop: random signal} { > set seen 1 > exp_continue > } >