From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25151 invoked by alias); 5 Aug 2019 18:17:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25143 invoked by uid 89); 5 Aug 2019 18:17:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=FULL X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Aug 2019 18:17:30 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A25C91E4A5; Mon, 5 Aug 2019 14:17:28 -0400 (EDT) Subject: Re: [PATCH] Add block['var'] accessor To: Tom Tromey , Christian Biesinger via gdb-patches Cc: Christian Biesinger References: <20190801223420.234581-1-cbiesinger@google.com> <87y30bit95.fsf@tromey.com> From: Simon Marchi Message-ID: <6f69d3a0-e977-71c3-bcf3-dd619cd4cf99@simark.ca> Date: Mon, 05 Aug 2019 18:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87y30bit95.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00121.txt.bz2 On 2019-08-02 9:36 a.m., Tom Tromey wrote: > Christian> + struct symbol *sym = block_lookup_symbol ( > Christian> + block, name.get(), symbol_name_match_type::FULL, VAR_DOMAIN); > > What about looking up things in other domains? I wonder if it's > possible to, say, have a local type that can be found by iteration over > the block but not by dictionary access. If so, that seems confusing. Just wondering, was this commented responded to? Simon