From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109238 invoked by alias); 30 Aug 2019 19:54:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109230 invoked by uid 89); 30 Aug 2019 19:54:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=screen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 19:54:15 +0000 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E3A87BDCE for ; Fri, 30 Aug 2019 19:54:14 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id 19so3914059wmk.0 for ; Fri, 30 Aug 2019 12:54:13 -0700 (PDT) Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id b26sm7878915wmj.14.2019.08.30.12.54.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2019 12:54:11 -0700 (PDT) Subject: Re: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message To: Sergio Durigan Junior , GDB Patches References: <87ftljah3a.fsf@redhat.com> <20190830195102.8965-1-sergiodj@redhat.com> From: Pedro Alves Message-ID: <6f57653e-e1de-3b86-050b-a4f3ca65ad46@redhat.com> Date: Fri, 30 Aug 2019 19:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190830195102.8965-1-sergiodj@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00663.txt.bz2 On 8/30/19 8:51 PM, Sergio Durigan Junior wrote: > Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html > > This very simple patch removes the "\nError: " suffix from the warning > message printed by nat/fork-inferior.c:trace_start_error. This proved > to just pollute the screen, causing things like: > > Starting program: /usr/bin/true > warning: Could not trace the inferior process. > Error: > warning: ptrace: Permission denied > > This "Error: " string is not useful at all, and can confuse things, > therefore let's just remove it and simplify the resulting messages: > > Starting program: /usr/bin/true > warning: Could not trace the inferior process. > warning: ptrace: Permission denied > > 2019-08-29 Sergio Durigan Junior > > * nat/fork-inferior.c (trace_start_error): Remove "\nError: " > suffix from warning message. OK. Thanks, Pedro Alves