From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qvkZIbxtu2CSaQAAWB0awg (envelope-from ) for ; Sat, 05 Jun 2021 08:27:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 78C8C1F163; Sat, 5 Jun 2021 08:27:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68CD31E01F for ; Sat, 5 Jun 2021 08:27:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B824139BDC00 for ; Sat, 5 Jun 2021 12:27:38 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 9536739BC07F for ; Sat, 5 Jun 2021 12:27:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9536739BC07F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A6AA61FD30; Sat, 5 Jun 2021 12:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622896037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uV1DDnZHP6o0/8sSlrVX78PmqIiQI4rEgAvM1Q6kBi4=; b=mMzFcxvoePp8AsxG5Ba7EDIBee0AcoSt04sUEPGYGnyzgU50W0wi2uVi+3k16ldCmWSyvM oUt/EK5ln//2mUjCU0aeILV4HX2/cqbrr7mQ8nc3sUS9eNA8sj5slT8OcEoF8S3Yz8F467 CwlhPCJAGUTAh4blJNQ20YQ/qs28kyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622896037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uV1DDnZHP6o0/8sSlrVX78PmqIiQI4rEgAvM1Q6kBi4=; b=0F6rCK1qZRWRiBFKqcehs10lMPmZNzekN+HvAZm0fYQ3tSjfikAUSj1ntY4/Kttebj77Ih zAcnAWLweaBB07Cg== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 84B65118DD; Sat, 5 Jun 2021 12:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622896037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uV1DDnZHP6o0/8sSlrVX78PmqIiQI4rEgAvM1Q6kBi4=; b=mMzFcxvoePp8AsxG5Ba7EDIBee0AcoSt04sUEPGYGnyzgU50W0wi2uVi+3k16ldCmWSyvM oUt/EK5ln//2mUjCU0aeILV4HX2/cqbrr7mQ8nc3sUS9eNA8sj5slT8OcEoF8S3Yz8F467 CwlhPCJAGUTAh4blJNQ20YQ/qs28kyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622896037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uV1DDnZHP6o0/8sSlrVX78PmqIiQI4rEgAvM1Q6kBi4=; b=0F6rCK1qZRWRiBFKqcehs10lMPmZNzekN+HvAZm0fYQ3tSjfikAUSj1ntY4/Kttebj77Ih zAcnAWLweaBB07Cg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id NgJvH6Vtu2B2KwAALh3uQQ (envelope-from ); Sat, 05 Jun 2021 12:27:17 +0000 Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant To: Hannes Domani , Hannes Domani via Gdb-patches , Tom Tromey References: <20210526170536.657-1-ssbssa.ref@yahoo.de> <20210526170536.657-1-ssbssa@yahoo.de> <87k0ncp0v4.fsf@tromey.com> <2129329660.4623528.1622725230456@mail.yahoo.com> From: Tom de Vries Message-ID: <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> Date: Sat, 5 Jun 2021 14:27:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <2129329660.4623528.1622725230456@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 6/3/21 3:00 PM, Hannes Domani via Gdb-patches wrote: > Am Mittwoch, 2. Juni 2021, 20:39:58 MESZ hat Tom Tromey Folgendes geschrieben: > >>>>>>> "Hannes" == Hannes Domani via Gdb-patches writes: >> >> Hannes> It was removed (probably by mistake) in >> Hannes> 51e78fc5fa21870d415c52f90b93e3c6ad57be46. >> >> Yes, sorry about that. >> >> Hannes> gdb/ChangeLog: >> >> Hannes> 2021-05-26  Hannes Domani  >> >> Hannes>     * python/py-symbol.c (gdbpy_initialize_symbols): Restore >> Hannes>     gdb.SYMBOL_LABEL_DOMAIN constant. >> >> Hannes> gdb/testsuite/ChangeLog: >> >> Hannes> 2021-05-26  Hannes Domani  >> >> Hannes>     * gdb.python/py-symbol.exp: Test symbol constants. >> >> This is ok.  Thank you. >> >> Hannes> +# Test gdb.Symbol domain categories >> Hannes> +gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \ >> Hannes> +    "0" "test gdb.SYMBOL_UNDEF_DOMAIN" >> Hannes> +gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \ >> Hannes> +    "1" "test gdb.SYMBOL_VAR_DOMAIN" >> >> While we don't want people to rely on the values of these constants, it >> seems harmless in the test suite.  If someone changes one, they can just >> update the test. > > Pushed, thanks. With python 3, I'm running into: ... (gdb) PASS: gdb.python/py-symbol.exp: test symbol destructor python print gdb.SYMBOL_UNDEF_DOMAIN^M File "", line 1^M print gdb.SYMBOL_UNDEF_DOMAIN^M ^^M SyntaxError: Missing parentheses in call to 'print'. Did you mean print(gdb.SYMBOL_UNDEF_DOMAIN)?^M Error while executing Python code.^M (gdb) FAIL: gdb.python/py-symbol.exp: test gdb.SYMBOL_UNDEF_DOMAIN ... Thanks, - Tom