From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21199 invoked by alias); 4 Jan 2006 06:41:30 -0000 Received: (qmail 21186 invoked by uid 22791); 4 Jan 2006 06:41:29 -0000 X-Spam-Check-By: sourceware.org Received: from nproxy.gmail.com (HELO nproxy.gmail.com) (64.233.182.206) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 04 Jan 2006 06:41:27 +0000 Received: by nproxy.gmail.com with SMTP id o63so1000137nfa for ; Tue, 03 Jan 2006 22:41:24 -0800 (PST) Received: by 10.49.51.10 with SMTP id d10mr572165nfk; Tue, 03 Jan 2006 22:41:24 -0800 (PST) Received: by 10.48.229.18 with HTTP; Tue, 3 Jan 2006 22:41:24 -0800 (PST) Message-ID: <6f48278f0601032241j18428d3ay6c3c9df5cb878e8b@mail.gmail.com> Date: Wed, 04 Jan 2006 06:41:00 -0000 From: Jie Zhang To: Jim Blandy Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 3/6: gdb testsuite) Cc: gdb-patches@sources.redhat.com In-Reply-To: <8f2776cb0601032131v584c465djaca0483556409c86@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <43B15FD3.7090404@gmail.com> <8f2776cb0601032131v584c465djaca0483556409c86@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00030.txt.bz2 Hi Jim, Thanks a lot for reviewing these patches! On 1/4/06, Jim Blandy wrote: > On 12/27/05, Jie Zhang wrote: > + set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" > > What's the story behind these -I flags that seem to be sprouting up in > a lot of the cases in asm-source.exp? It seems like they should > either be necessary everywhere, or nowhere. > This is the easiest question for me, so I answer it first. In asm-source.exp, first comes: set asm-flags "" After all target things, there is: if { "${asm-flags}" =3D=3D "" } { set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" set debug-flags "-gstabs" } So if target does not set asm-flags, the debug-flags will be set to "-gstabs", which will override anything target set for it. If any target want to use dwarf2 as debug information, like bfin and others, it needs set asm-flags to the vanilla string to avoid the overriding. Regards, Jie