From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Use std::vector in uploaded_tp
Date: Fri, 30 Mar 2018 21:20:00 -0000 [thread overview]
Message-ID: <6f39ae8c-f738-a281-e66f-d96f75483732@polymtl.ca> (raw)
In-Reply-To: <1521667509-303-1-git-send-email-simon.marchi@ericsson.com>
On 2018-03-21 05:25 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> This patch changes the VEC(char_ptr) fields in uploaded_tp to use
> std::vector<char *>. At first, I wanted to creep in more changes, like
> using std::string, but it was making the patch too big and less focused,
> so I decided to keep it to just that.
>
> It also looks like the strings in those vectors are never free'd. If
> so, we can fix that in another patch.
I pushed this series.
Simon
prev parent reply other threads:[~2018-03-30 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 21:25 Simon Marchi
2018-03-21 21:25 ` [PATCH 3/3] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args Simon Marchi
2018-04-01 16:29 ` Tom Tromey
2018-04-01 18:25 ` Simon Marchi
2018-04-02 2:23 ` Tom Tromey
2018-03-21 21:25 ` [PATCH 2/3] Use std::vector and std::string instead of VEC(char_ptr) in gdbserver tdesc Simon Marchi
2018-03-30 21:20 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f39ae8c-f738-a281-e66f-d96f75483732@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox