From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4CLACozGkmH5PAAAWB0awg (envelope-from ) for ; Mon, 15 Nov 2021 15:43:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 294811F0C1; Mon, 15 Nov 2021 15:43:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C9F871EDEE for ; Mon, 15 Nov 2021 15:43:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 484E03857C42 for ; Mon, 15 Nov 2021 20:43:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 484E03857C42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637009035; bh=x+CMwAajjcO8zEpIwskkUvF/NT+xUsdkiIdtdDzXyiA=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qcvjtl1LBSgDkkvzgPq2VqvLLJ1s95N1EcUhzJRflc4eEhbVqik5fmIKRDWsX4bRy RnesH5e3mFwlv9ae0Q53zggESBnZBHUMv4H9TMTlm9KKZpbZJqSROYsqlUU90KrvjT y1VnahEitveAcFPJQC3sLsX2JG3Gup0wECtl9OMY= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 47DD03857C42 for ; Mon, 15 Nov 2021 20:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47DD03857C42 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AFKgTVr025135; Mon, 15 Nov 2021 20:42:47 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cbxtrr02s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 20:42:46 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AFKcsYh011270; Mon, 15 Nov 2021 20:42:46 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03dal.us.ibm.com with ESMTP id 3ca50aqas3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 20:42:45 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AFKgjCt54460912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Nov 2021 20:42:45 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 067AFB2073; Mon, 15 Nov 2021 20:42:45 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 45459B205F; Mon, 15 Nov 2021 20:42:44 +0000 (GMT) Received: from lexx (unknown [9.160.53.107]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 15 Nov 2021 20:42:44 +0000 (GMT) Message-ID: <6f000cddd5fa3bb69f7321667a3aab83225531e9.camel@vnet.ibm.com> Subject: Re: [PATCH] gdb: fix gdbarch_tdep ODR violation To: Simon Marchi , Luis Machado , Simon Marchi , gdb-patches@sourceware.org, John Baldwin Date: Mon, 15 Nov 2021 14:42:43 -0600 In-Reply-To: References: <20211112204233.4108340-1-simon.marchi@efficios.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-16.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jLhIu-QxWUYvhAaUeFXbo6xIGvefdgnO X-Proofpoint-ORIG-GUID: jLhIu-QxWUYvhAaUeFXbo6xIGvefdgnO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-15_15,2021-11-15_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=762 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 clxscore=1011 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111150103 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: will schmidt via Gdb-patches Reply-To: will schmidt Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 2021-11-15 at 11:29 -0500, Simon Marchi wrote: > On 2021-11-15 5:45 a.m., Luis Machado via Gdb-patches wrote: > > LGTM > > Thanks to you and John for taking a look, I pushed the patch. > > Simon > Hi, I'm now seeing a build failure on powerpc. (specifically ppc64le, but i'm not sure it will matter which powerpc variant). First failure is ... CXX ppc-linux-nat.o ppc-linux-nat.c: In function ‘int ppc_register_u_addr(gdbarch*, int)’: ppc-linux-nat.c:658:22: error: ‘struct gdbarch_tdep’ has no member named ‘ppc_gp0_regnum’ 658 | if (regno >= tdep->ppc_gp0_regnum ... Assorted other no-such-member errors follow. Thanks, -Will