From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18851 invoked by alias); 22 May 2014 17:58:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18834 invoked by uid 89); 22 May 2014 17:58:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1lp0139.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.139) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 22 May 2014 17:58:44 +0000 Received: from BN1BFFO11FD024.protection.gbl (10.58.144.31) by BN1BFFO11HUB038.protection.gbl (10.58.144.185) with Microsoft SMTP Server (TLS) id 15.0.949.9; Thu, 22 May 2014 17:58:40 +0000 Received: from xsj-gw1 (149.199.60.83) by BN1BFFO11FD024.mail.protection.outlook.com (10.58.144.87) with Microsoft SMTP Server id 15.0.949.9 via Frontend Transport; Thu, 22 May 2014 17:58:40 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1WnXGK-0002IK-1K; Thu, 22 May 2014 10:58:40 -0700 From: Ajit Kumar Agarwal To: Joel Brobecker CC: Michael Eager , Michael Eager , "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , "Nagaraju Mekala" Subject: RE: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint Date: Thu, 22 May 2014 17:58:00 -0000 References: <537BC5B9.10601@eagercon.com> <537C5A25.9000003@eagerm.com> <5821f144-e431-4bee-9cd7-33971b5512a3@BN1AFFO11FD019.protection.gbl> <20140521134544.GL22822@adacore.com> In-Reply-To: <20140521134544.GL22822@adacore.com> Content-Type: multipart/mixed; boundary="_002_37378DC5BCD0EE48BA4B082E0B55DFAA25E3531FXAPPVEXMBX01xln_" MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <6ece3192-e76c-42b1-8554-a69c67e29d52@BN1BFFO11FD024.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438001)(199002)(189002)(51704005)(377454003)(377424004)(13464003)(164054003)(512954002)(46102001)(84326002)(81542001)(76482001)(21056001)(2656002)(87936001)(81342001)(71186001)(74316001)(33646001)(70736001)(92726001)(79102001)(92566001)(86362001)(77982001)(20776003)(53416003)(83072002)(85852003)(99396002)(31966008)(74502001)(74662001)(50986999)(76176999)(54356999)(31696002)(99936001)(4396001)(19580405001)(19580395003)(83322001)(44976005)(80022001)(568964001)(64706001)(23106003);DIR:OUT;SFP:;SCL:1;SRVR:BN1BFFO11HUB038;H:xsj-gw1;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Forefront-PRVS: 021975AE46 Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-gw1; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-05/txt/msg00563.txt.bz2 --_002_37378DC5BCD0EE48BA4B082E0B55DFAA25E3531FXAPPVEXMBX01xln_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 3882 Thanks Joel for the review comments. Will make sure to consider your sugge= stions when Submitting the new patches. Based on the feedback, the updated patch is given below. Okay for the upstream? [Patch, microblaze]: Add slr and shr regs =20=20=20=20 This patch add the support of slr and shr regs and also solves the prob= lem related to process_g_packet where the buf_len > 2 * rsa->sizeof_g_packet and throwing the Error that 'g' packet message reply is too long. This = is because the buf_len calculated in the init_remote_state function for microblaze target is based On the sizeof_g_packet and remote_packet_size and the memory_packet_config->size. The sizeof_g_packet is 236 because = the number of reg num is 59 and 2* sizeof_g_packet comes to 472 .With shr a= nd shl entry and the buf_len is 472. This does not match the greater than conditional statement and works fine. Without shr and shl entry,the sizeof_g_packets comes to 57*4 *2 =3D 456. This doesn't match the crit= eria in the process_g_packet function leading to throwing of error message = as " 'g' packet message reply is too long". =20=20=20=20 ChangeLog: 2014-05-20 Ajit Agarwal =20=20=20=20 * gdb/gdbserver/Makefile.in (microblaze-linux.c): New rule. =20=20=20=20 * gdb/microblaze-tdep.c (microblaze_register_names): Added the rshr and rslr register names. =20=20=20=20 * gdb/microblaze-tdep.h (microblaze_reg_num): Addition of field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM. (microblaze_frame_cache): Change in the index of register_offsets. =20=20=20=20 * gdb/regformats/reg-microblaze.dat: New Register data file. =20=20=20=20 Signed-off-by:Ajit Agarwal ajitkum@xilinx.com Thanks & Regards Ajit -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com]=20 Sent: Wednesday, May 21, 2014 7:16 PM To: Ajit Kumar Agarwal Cc: Michael Eager; Michael Eager; gdb-patches@sourceware.org; Vinod Kathail= ; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs and little-endian br= eakpoint > Here is the problem description. The problem is related to=20 > process_g_packet where the buf_len > 2 * rsa->sizeof_g_packet and=20 > throwing the Error that 'g' packet message reply is too long. This is=20 > because the buf_len calculated in the init_remote_state function for=20 > microblaze target is based On the sizeof_g_packet and=20 > remote_packet_size and the memory_packet_config->size. The=20 > sizeof_g_packet is 236 because the number of reg num is 59 and 2*=20 > sizeof_g_packet comes to 472 .With shr and shl entry and the buf_len=20 > is 472. This does not match the greater than conditional statement and=20 > works fine. Without shr and shl entry,the sizeof_g_packets comes to > 57*4 *2 =3D 456. This doesn't match the criteria in the=20 > process_g_packet function leading to throwing of error message as " > 'g' packet message reply is too long". >=20 > This is happening when tar remote machine:1234 command is run in gdb. >=20 > >>>These changes don't appear related. Split independent changes in=20 > >>>to separate patches. >=20 > I will split the changes and send the separate patch with shr and shl=20 > reg changes and the little endian breakpoint support. Thanks, Ajit. FWIW, I agree with Michael. Also, when submitting the new patches, please include the description of th= e problem you are trying to solve in the revision log of your patch. Someth= ing like the description you gave above, for instance. This makes archeology a lot easier for us. The good news when doing that i= s that submitting the patch could be as simple as "git send-email"-ing the = patch; that's what I personally do for my own patches, and it's been a real= time saver. -- Joel --_002_37378DC5BCD0EE48BA4B082E0B55DFAA25E3531FXAPPVEXMBX01xln_ Content-Type: application/octet-stream; name="0001-Patch-microblaze-Add-slr-and-shr-regs.patch" Content-Description: 0001-Patch-microblaze-Add-slr-and-shr-regs.patch Content-Disposition: attachment; filename="0001-Patch-microblaze-Add-slr-and-shr-regs.patch"; size=5022; creation-date="Wed, 21 May 2014 13:37:15 GMT"; modification-date="Thu, 22 May 2014 17:51:27 GMT" Content-Transfer-Encoding: base64 Content-length: 6808 RnJvbSBhOTM5ZTMyZTAwMTJmYjYxMWZjYzc4MzE3NTBkZGQ5MjVlOTcxOGIx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBaml0IEt1bWFyIEFn YXJ3YWwgPGFqaXRrdW1AeGhkc3BkZ251Lihub25lKT4KRGF0ZTogV2VkLCAy MSBNYXkgMjAxNCAxODo1NToyMyArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIFtQ YXRjaCwgbWljcm9ibGF6ZV06IEFkZCBzbHIgYW5kIHNociByZWdzCgpUaGlz IHBhdGNoIGFkZCB0aGUgc3VwcG9ydCBvZiBzbHIgYW5kIHNociByZWdzIGFu ZCBhbHNvIHNvbHZlcyB0aGUgcHJvYmxlbQpyZWxhdGVkIHRvIHByb2Nlc3Nf Z19wYWNrZXQgd2hlcmUgdGhlIGJ1Zl9sZW4gPiAyICogcnNhLT5zaXplb2Zf Z19wYWNrZXQKYW5kIHRocm93aW5nIHRoZSBFcnJvciB0aGF0ICdnJyBwYWNr ZXQgbWVzc2FnZSByZXBseSBpcyB0b28gbG9uZy4gVGhpcyBpcwpiZWNhdXNl IHRoZSBidWZfbGVuIGNhbGN1bGF0ZWQgaW4gdGhlIGluaXRfcmVtb3RlX3N0 YXRlIGZ1bmN0aW9uIGZvcgptaWNyb2JsYXplIHRhcmdldCBpcyBiYXNlZCBP biB0aGUgc2l6ZW9mX2dfcGFja2V0IGFuZCByZW1vdGVfcGFja2V0X3NpemUK YW5kIHRoZSBtZW1vcnlfcGFja2V0X2NvbmZpZy0+c2l6ZS4gVGhlIHNpemVv Zl9nX3BhY2tldCBpcyAyMzYgYmVjYXVzZSB0aGUKbnVtYmVyIG9mIHJlZyBu dW0gaXMgNTkgYW5kIDIqIHNpemVvZl9nX3BhY2tldCBjb21lcyB0byA0NzIg LldpdGggc2hyIGFuZApzaGwgZW50cnkgYW5kIHRoZSBidWZfbGVuIGlzIDQ3 Mi4gVGhpcyBkb2VzIG5vdCBtYXRjaCB0aGUgZ3JlYXRlciB0aGFuCmNvbmRp dGlvbmFsIHN0YXRlbWVudCAgYW5kIHdvcmtzIGZpbmUuIFdpdGhvdXQgc2hy IGFuZCBzaGwgZW50cnksdGhlCnNpemVvZl9nX3BhY2tldHMgY29tZXMgdG8g NTcqNCAqMiA9IDQ1Ni4gIFRoaXMgZG9lc24ndCBtYXRjaCB0aGUgY3JpdGVy aWEKaW4gdGhlIHByb2Nlc3NfZ19wYWNrZXQgZnVuY3Rpb24gIGxlYWRpbmcg dG8gdGhyb3dpbmcgb2YgZXJyb3IgbWVzc2FnZSBhcwoiICdnJyBwYWNrZXQg bWVzc2FnZSByZXBseSBpcyB0b28gbG9uZyIuCgpDaGFuZ2VMb2c6CjIwMTQt MDUtMjAgQWppdCBBZ2Fyd2FsIDxhaml0a3VtQHhpbGlueC5jb20+CgoJKiBn ZGIvZ2Ric2VydmVyL01ha2VmaWxlLmluIChtaWNyb2JsYXplLWxpbnV4LmMp OiBOZXcgcnVsZS4KCgkqIGdkYi9taWNyb2JsYXplLXRkZXAuYyAobWljcm9i bGF6ZV9yZWdpc3Rlcl9uYW1lcyk6IEFkZGVkCgl0aGUgcnNociBhbmQgcnNs ciByZWdpc3RlciBuYW1lcy4KCgkqIGdkYi9taWNyb2JsYXplLXRkZXAuaCAo bWljcm9ibGF6ZV9yZWdfbnVtKTogQWRkaXRpb24gb2YKCWZpZWxkIE1JQ1JP QkxBWkVfU0xSX1JFR05VTSBhbmQgTUlDUk9CTEFaRV9TSFJfUkVHTlVNLgoJ KG1pY3JvYmxhemVfZnJhbWVfY2FjaGUpOiBDaGFuZ2UgaW4gdGhlIGluZGV4 IG9mCglyZWdpc3Rlcl9vZmZzZXRzLgoKCSogZ2RiL3JlZ2Zvcm1hdHMvcmVn LW1pY3JvYmxhemUuZGF0OiBOZXcgUmVnaXN0ZXIgZGF0YSBmaWxlLgoKU2ln bmVkLW9mZi1ieTpBaml0IEFnYXJ3YWwgYWppdGt1bUB4aWxpbnguY29tCi0t LQogZ2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbiAgICAgICAgIHwgICAgNSAr KystCiBnZGIvbWljcm9ibGF6ZS10ZGVwLmMgICAgICAgICAgICAgfCAgICAz ICstCiBnZGIvbWljcm9ibGF6ZS10ZGVwLmggICAgICAgICAgICAgfCAgICA2 ICsrKy0KIGdkYi9yZWdmb3JtYXRzL3JlZy1taWNyb2JsYXplLmRhdCB8ICAg NDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogNCBm aWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdkYi9yZWdmb3JtYXRzL3JlZy1taWNy b2JsYXplLmRhdAoKZGlmZiAtLWdpdCBhL2dkYi9nZGJzZXJ2ZXIvTWFrZWZp bGUuaW4gYi9nZGIvZ2Ric2VydmVyL01ha2VmaWxlLmluCmluZGV4IGY3NzNm YTIuLjI0NTQwMDMgMTAwNjQ0Ci0tLSBhL2dkYi9nZGJzZXJ2ZXIvTWFrZWZp bGUuaW4KKysrIGIvZ2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbgpAQCAtMzQ4 LDcgKzM0OCw4IEBAIGNsZWFuOgogCXJtIC1mIGFtZDY0LWF2eC5jIGFtZDY0 LWF2eC1saW51eC5jCiAJcm0gLWYgYW1kNjQtbXB4LmMgYW1kNjQtbXB4LWxp bnV4LmMKIAlybSAtZiBhbWQ2NC1hdng1MTIuYyBhbWQ2NC1hdng1MTItbGlu dXguYwotCXJtIC1mIGkzODYtbW14LmMgaTM4Ni1tbXgtbGludXguYworCXJt IC1mIGkzODYtbW14LmMgaTM4Ni1tbXgtbGludXguYyAKKwlybSAtZiBtaWNy b2JsYXplLWxpbnV4LmMKIAlybSAtZiB4MzIuYyB4MzItbGludXguYwogCXJt IC1mIHgzMi1hdnguYyB4MzItYXZ4LWxpbnV4LmMKIAlybSAtZiB4MzItYXZ4 NTEyLmMgeDMyLWF2eDUxMi1saW51eC5jCkBAIC02MTQsNiArNjE1LDggQEAg cmVnLWNmLmMgOiAkKHNyY2RpcikvLi4vcmVnZm9ybWF0cy9yZWctY2YuZGF0 ICQocmVnZGF0X3NoKQogCSQoU0hFTEwpICQocmVnZGF0X3NoKSAkKHNyY2Rp cikvLi4vcmVnZm9ybWF0cy9yZWctY2YuZGF0IHJlZy1jZi5jCiBtaXBzLWxp bnV4LmMgOiAkKHNyY2RpcikvLi4vcmVnZm9ybWF0cy9taXBzLWxpbnV4LmRh dCAkKHJlZ2RhdF9zaCkKIAkkKFNIRUxMKSAkKHJlZ2RhdF9zaCkgJChzcmNk aXIpLy4uL3JlZ2Zvcm1hdHMvbWlwcy1saW51eC5kYXQgbWlwcy1saW51eC5j CittaWNyb2JsYXplLWxpbnV4LmMgOiAkKHNyY2RpcikvLi4vcmVnZm9ybWF0 cy9yZWctbWljcm9ibGF6ZS5kYXQgJChyZWdkYXRfc2gpCisJJChTSEVMTCkg JChyZWdkYXRfc2gpICQoc3JjZGlyKS8uLi9yZWdmb3JtYXRzL3JlZy1taWNy b2JsYXplLmRhdCBtaXBzLWxpbnV4LmMKIG1pcHMtZHNwLWxpbnV4LmMgOiAk KHNyY2RpcikvLi4vcmVnZm9ybWF0cy9taXBzLWRzcC1saW51eC5kYXQgJChy ZWdkYXRfc2gpCiAJJChTSEVMTCkgJChyZWdkYXRfc2gpICQoc3JjZGlyKS8u Li9yZWdmb3JtYXRzL21pcHMtZHNwLWxpbnV4LmRhdCBtaXBzLWRzcC1saW51 eC5jCiBtaXBzNjQtbGludXguYyA6ICQoc3JjZGlyKS8uLi9yZWdmb3JtYXRz L21pcHM2NC1saW51eC5kYXQgJChyZWdkYXRfc2gpCmRpZmYgLS1naXQgYS9n ZGIvbWljcm9ibGF6ZS10ZGVwLmMgYi9nZGIvbWljcm9ibGF6ZS10ZGVwLmMK aW5kZXggMTRjMWI1Mi4uNGQ2MzkwOSAxMDA2NDQKLS0tIGEvZ2RiL21pY3Jv YmxhemUtdGRlcC5jCisrKyBiL2dkYi9taWNyb2JsYXplLXRkZXAuYwpAQCAt NzMsNyArNzMsOCBAQCBzdGF0aWMgY29uc3QgY2hhciAqbWljcm9ibGF6ZV9y ZWdpc3Rlcl9uYW1lc1tdID0KICAgInJwYyIsICAicm1zciIsICJyZWFyIiwg InJlc3IiLCAicmZzciIsICJyYnRyIiwKICAgInJwdnIwIiwgInJwdnIxIiwg InJwdnIyIiwgInJwdnIzIiwgInJwdnI0IiwgInJwdnI1IiwgInJwdnI2IiwK ICAgInJwdnI3IiwgInJwdnI4IiwgInJwdnI5IiwgInJwdnIxMCIsICJycHZy MTEiLAotICAicmVkciIsICJycGlkIiwgInJ6cHIiLCAicnRsYngiLCAicnRs YnN4IiwgInJ0bGJsbyIsICJydGxiaGkiCisgICJyZWRyIiwgInJwaWQiLCAi cnpwciIsICJydGxieCIsICJydGxic3giLCAicnRsYmxvIiwgInJ0bGJoaSIs CisgICJyc2xyIiwgInJzaHIiCiB9OwogCiAjZGVmaW5lIE1JQ1JPQkxBWkVf TlVNX1JFR1MgQVJSQVlfU0laRSAobWljcm9ibGF6ZV9yZWdpc3Rlcl9uYW1l cykKZGlmZiAtLWdpdCBhL2dkYi9taWNyb2JsYXplLXRkZXAuaCBiL2dkYi9t aWNyb2JsYXplLXRkZXAuaAppbmRleCBhNTMyMDkyLi5mN2FjZmQ2IDEwMDY0 NAotLS0gYS9nZGIvbWljcm9ibGF6ZS10ZGVwLmgKKysrIGIvZ2RiL21pY3Jv YmxhemUtdGRlcC5oCkBAIC00Miw3ICs0Miw3IEBAIHN0cnVjdCBtaWNyb2Js YXplX2ZyYW1lX2NhY2hlCiAgIGludCBmcF9yZWdudW07CiAKICAgLyogT2Zm c2V0cyB0byBzYXZlZCByZWdpc3RlcnMuICAqLwotICBpbnQgcmVnaXN0ZXJf b2Zmc2V0c1s1N107CS8qIE11c3QgbWF0Y2ggTUlDUk9CTEFaRV9OVU1fUkVH Uy4gICovCisgIGludCByZWdpc3Rlcl9vZmZzZXRzWzU5XTsJLyogTXVzdCBt YXRjaCBNSUNST0JMQVpFX05VTV9SRUdTLiAgKi8KIAogICAvKiBUYWJsZSBv ZiBzYXZlZCByZWdpc3RlcnMuICAqLwogICBzdHJ1Y3QgdHJhZF9mcmFtZV9z YXZlZF9yZWcgKnNhdmVkX3JlZ3M7CkBAIC0xMDcsNyArMTA3LDkgQEAgZW51 bSBtaWNyb2JsYXplX3JlZ251bQogICBNSUNST0JMQVpFX1JUTEJYX1JFR05V TSwKICAgTUlDUk9CTEFaRV9SVExCU1hfUkVHTlVNLAogICBNSUNST0JMQVpF X1JUTEJMT19SRUdOVU0sCi0gIE1JQ1JPQkxBWkVfUlRMQkhJX1JFR05VTQor ICBNSUNST0JMQVpFX1JUTEJISV9SRUdOVU0sCisgIE1JQ1JPQkxBWkVfU0xS X1JFR05VTSwKKyAgTUlDUk9CTEFaRV9TSFJfUkVHTlVNCiB9OwogCiAvKiBB bGwgcmVnaXN0ZXJzIGFyZSAzMiBiaXRzLiAgKi8KZGlmZiAtLWdpdCBhL2dk Yi9yZWdmb3JtYXRzL3JlZy1taWNyb2JsYXplLmRhdCBiL2dkYi9yZWdmb3Jt YXRzL3JlZy1taWNyb2JsYXplLmRhdApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi45MzZiYzQ0Ci0tLSAvZGV2L251bGwKKysrIGIvZ2Ri L3JlZ2Zvcm1hdHMvcmVnLW1pY3JvYmxhemUuZGF0CkBAIC0wLDAgKzEsNDEg QEAKK25hbWU6bWljcm9ibGF6ZSAKK2V4cGVkaXRlOnIxLHBjIAorMzI6cjAg CiszMjpyMSAKKzMyOnIyIAorMzI6cjMgCiszMjpyNCAKKzMyOnI1IAorMzI6 cjYgCiszMjpyNyAKKzMyOnI4IAorMzI6cjkgCiszMjpyMTAgCiszMjpyMTEg CiszMjpyMTIgCiszMjpyMTMgCiszMjpyMTQgCiszMjpyMTUgCiszMjpyMTYg CiszMjpyMTcgCiszMjpyMTggCiszMjpyMTkgCiszMjpyMjAgCiszMjpyMjEg CiszMjpyMjIgCiszMjpyMjMgCiszMjpyMjQgCiszMjpyMjUgCiszMjpyMjYg CiszMjpyMjcgCiszMjpyMjggCiszMjpyMjkgCiszMjpyMzAgCiszMjpyMzEg CiszMjpwYyAKKzMyOm1zciAKKzMyOmVhciAKKzMyOmVzciAKKzMyOmZzciAK KzMyOnNscgorMzI6c2hyCi0tIAoxLjcuMQoK --_002_37378DC5BCD0EE48BA4B082E0B55DFAA25E3531FXAPPVEXMBX01xln_--