From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37366 invoked by alias); 16 Nov 2017 01:53:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37354 invoked by uid 89); 16 Nov 2017 01:53:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=Receiving, keith, Keith, H*u:6.1 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 01:53:47 +0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vAG1rifW010534 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 16 Nov 2017 01:53:45 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vAG1risS008185 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 16 Nov 2017 01:53:44 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vAG1rhZU011361 for ; Thu, 16 Nov 2017 01:53:43 GMT Received: from [10.159.249.24] (/10.159.249.24) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Nov 2017 17:53:43 -0800 Subject: Re: [PING][PATCH PR gdb/18071] TLS variables can't be resolved on aarch64-linux-gnu To: "gdb-patches@sourceware.org" References: <1509636764-46111-1-git-send-email-weimin.pan@oracle.com> From: Wei-min Pan Message-ID: <6eadd01b-098c-ca82-b41a-4303f0f6aa0a@oracle.com> Date: Thu, 16 Nov 2017 01:53:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509636764-46111-1-git-send-email-weimin.pan@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00293.txt.bz2 On 11/2/2017 8:32 AM, Weimin Pan wrote: > Running the test case with upstream gdb shows two failures: > > (1) Receiving different error messages when printing TLS variable before > program runs - because the ARM compiler does not emit dwarf attribute > DW_AT_location for TLS, the result is expected and the baseline may > need to be changed for aarch64. > > (2) Using "info address" command on C++ static TLS object resulted in > "symbol unresolved" error - below is a snippet from the test case: > > class K { > public: > static __thread int another_thread_local; > }; > > __thread int K::another_thread_local; > > (gdb) info address K::another_thread_local > Symbol "K::another_thread_local" is unresolved. > > This patch contains fix for (2). > > Function info_address_command() handles the "info address" command and > calls lookup_minimal_symbol_and_objfile() to find sym's symbol entry in > mininal symbol table if SYMBOL_COMPUTED_OPS (sym) is false. Problem is > that function lookup_minimal_symbol_and_objfile() only looked up an > objfile's minsym ordinary hash table, not its demangled hash table, which > was the reason why the C++ name was not found. > > The fix is to call lookup_minimal_symbol(), which already looks up entries > in both minsym's hash tables, to find names when traversing the object file > list in lookup_minimal_symbol_and_objfile(). > > Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions. > --- > gdb/ChangeLog | 5 +++++ > gdb/minsyms.c | 17 +++-------------- > 2 files changed, 8 insertions(+), 14 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 4b292e0..2f630bc 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2017-11-01 Weimin Pan > + > + * minsyms.c (lookup_minimal_symbol_and_objfile): Use > + lookup_minimal_symbol() to find symbol entry. > + > 2017-10-27 Keith Seitz > > * breakpoint.c (print_breakpoint_location): Use the symbol saved > diff --git a/gdb/minsyms.c b/gdb/minsyms.c > index 37edbd8..4edd8b1 100644 > --- a/gdb/minsyms.c > +++ b/gdb/minsyms.c > @@ -881,23 +881,12 @@ lookup_minimal_symbol_and_objfile (const char *name) > { > struct bound_minimal_symbol result; > struct objfile *objfile; > - unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE; > > ALL_OBJFILES (objfile) > { > - struct minimal_symbol *msym; > - > - for (msym = objfile->per_bfd->msymbol_hash[hash]; > - msym != NULL; > - msym = msym->hash_next) > - { > - if (strcmp (MSYMBOL_LINKAGE_NAME (msym), name) == 0) > - { > - result.minsym = msym; > - result.objfile = objfile; > - return result; > - } > - } > + result = lookup_minimal_symbol (name, NULL, objfile); > + if (result.minsym != NULL) > + return result; > } > > memset (&result, 0, sizeof (result));