From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /OLNOpLFKWSWfyEAWB0awg (envelope-from ) for ; Sun, 02 Apr 2023 14:12:34 -0400 Received: by simark.ca (Postfix, from userid 112) id E9E381E15D; Sun, 2 Apr 2023 14:12:34 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=uFfq4lLX; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A31201E110 for ; Sun, 2 Apr 2023 14:12:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E225385841A for ; Sun, 2 Apr 2023 18:12:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E225385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680459153; bh=QphnoviqSbk7d6tmh6qrAjYeeznYTQ2hp2OaILjCUzk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=uFfq4lLX+sUrzPn1kTc7irvEiBoJLGVdVyThUkVlTdbOJRXVNKW/H1x7fEo2Jksa4 fyr4FykyxyD3XWQ8/n9DYGrh0zke6TTJCz6qI+77kMBn0qClcmpMxbLEkSfkcoiohD 9PJauCsJ235VxAxP98k8/YC0aIbUE1b1FeOHDGK0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E95413858C50 for ; Sun, 2 Apr 2023 18:12:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E95413858C50 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 332IC5im026833 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 2 Apr 2023 14:12:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 332IC5im026833 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 39FFA1E110; Sun, 2 Apr 2023 14:12:05 -0400 (EDT) Message-ID: <6e95e552-4170-7a20-a992-3a1f2082d58c@polymtl.ca> Date: Sun, 2 Apr 2023 14:12:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] gdb: remove unused parameters in print_doc_of_command, apropos_cmd Content-Language: en-US To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20230401193240.1619282-1-simon.marchi@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 2 Apr 2023 18:12:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 4/2/23 07:43, Philippe Waroquiers wrote: > On Sat, 2023-04-01 at 15:32 -0400, Simon Marchi via Gdb-patches wrote: >> I noticed the prefix parameter was unused in print_doc_of_command. And >> when removing it, it becomes unused in apropos_cmd. >> >> Sending as non-obvious, in case somebody can spot if this is a mistake, >> and it should actually be used. > > > I think that the prefix arguments were removed as part of > 2f822da535ba9b159174d02d7114b4fc4f7c8818 > > Likely these 2 prefix args felt through the cracks. Ok, thanks for checking, pushed. Simon