From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>, Zied Guermazi <zied.guermazi@trande.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE
Date: Mon, 2 May 2022 17:50:41 +0100 [thread overview]
Message-ID: <6e8148d5-bba1-86e2-313c-b9e99042874c@palves.net> (raw)
In-Reply-To: <87sfprkhy6.fsf@tromey.com>
On 2022-05-02 17:38, Tom Tromey wrote:
>>>>>> "Zied" == Zied Guermazi <zied.guermazi@trande.de> writes:
>
> Zied> PAGE_SIZE is not defined in all build configurations, e.g cross compiling
> Zied> for aarch64 GNU/Linux machine. This patch gets the value at runtime using
> Zied> posix call sysconf (_SC_PAGESIZE)
>
> Thanks. I think this is ok.
Please don't merge it yet. Andreas' question is quite pertinent -- this file in only built on
x86 hosts. The premise of the patch doesn't seems strange offhand. Is the Aarch64 port
going to start using linux-btrace.c? That isn't clear.
next prev parent reply other threads:[~2022-05-02 16:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 12:16 [PATCH v4 0/1] " Zied Guermazi
2022-04-30 12:16 ` [PATCH 1/1] " Zied Guermazi
2022-04-30 12:29 ` Andreas Schwab
2022-04-30 12:32 ` Zied Guermazi
2022-04-30 12:52 ` Andreas Schwab
2022-04-30 12:58 ` Zied Guermazi
2022-04-30 13:03 ` Andreas Schwab
2022-04-30 13:25 ` Zied Guermazi
2022-04-30 13:33 ` Andreas Schwab
2022-05-02 16:46 ` Pedro Alves
2022-05-02 18:01 ` Zied Guermazi
2022-05-02 18:55 ` Pedro Alves
2022-05-02 19:16 ` Zied Guermazi
2022-05-02 16:38 ` Tom Tromey
2022-05-02 16:50 ` Pedro Alves [this message]
2022-05-02 17:04 ` Tom Tromey
2022-05-02 17:08 ` Pedro Alves
-- strict thread matches above, loose matches on Subject: below --
2022-04-24 21:15 [PATCH 0/1] btrace: " Zied Guermazi
2022-04-24 21:15 ` [PATCH 1/1] " Zied Guermazi
2022-04-25 5:03 ` Metzger, Markus T via Gdb-patches
2022-04-25 7:02 ` Zied Guermazi
2022-04-25 7:36 ` Metzger, Markus T via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8148d5-bba1-86e2-313c-b9e99042874c@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=zied.guermazi@trande.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox