From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ANJBGYGZLmUOXjAAWB0awg (envelope-from ) for ; Tue, 17 Oct 2023 10:26:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1697552769; bh=b8JC27emy+9BiR4k/O1G02mSvgqln37ZxfAlNMIHVGo=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=A/4aAypfhrU8uywdQFf9sx515gCB+XKINuJgk+Y62iDLCqFvHj24DcqUbXcioXAZ+ NVHwIGqdE0lk4ItpjjPPglW3FFh7H5WJlu8xAw0KL6giqijBw0eIgaa8TOhK8NO07Z N1Z8QMv7W3NiXFMCI4HG1BcJAofHabk7rJGlNtFk= Received: by simark.ca (Postfix, from userid 112) id 637E71E0C1; Tue, 17 Oct 2023 10:26:09 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=B+YZR/8w; dkim-atps=neutral Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50C8D1E00F for ; Tue, 17 Oct 2023 10:26:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CFB7C3857029 for ; Tue, 17 Oct 2023 14:26:06 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1A2A93858005 for ; Tue, 17 Oct 2023 14:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A2A93858005 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A2A93858005 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697552705; cv=none; b=oNJ8mORLB/8k72sXHiNXDr6p3Ig9t2ADSghbW0HsPXiRr0RpnKeojbEO2B16WDlz//NKumW+f5qb2ETXM4q/OeusaWXsEjAEJCYZUM66ZrhwczebS2MUyOJ96ZUoAencnlhGgD1b2gsSY+OOggiI/A0KmfxLTRa1eZ6AFeTsCoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697552705; c=relaxed/simple; bh=b8JC27emy+9BiR4k/O1G02mSvgqln37ZxfAlNMIHVGo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IZED/Haxq+cTwYxxCcIA2RS2P6hwiKmOUG9UBZdqO5/vQMWgXU+WaGS0SsMxyD5zoISpbBKcyb2hEkWBWCYCEr0oSVFIHMRk5hwF8Mmr2OppfgFDzVi6x9G2P1lVd9hecuEbHGXG04B42CRRo1is0dzpx4xmXEukLWyncO1pI4I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1697552703; bh=b8JC27emy+9BiR4k/O1G02mSvgqln37ZxfAlNMIHVGo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=B+YZR/8whM049Y8c9DF4juWARdDfkyzgw0u5MX8LEoA2DIghI7tQMwBVnmF0mdvWQ id+NTQw9QktbUltm3HbqYM5dq7jcpbh0eNJ/OWzodDaVLnuiq/pm9tRvijUncuL+S/ +a3UNBe/7hqKzLpGaT4ZjR8UQnaiAiETB+YmqdZk= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5C6DD1E00F; Tue, 17 Oct 2023 10:25:03 -0400 (EDT) Message-ID: <6e3b93f0-f9b1-4e92-aa8b-65ee0d56ebc1@simark.ca> Date: Tue, 17 Oct 2023 10:25:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp Content-Language: fr To: Lancelot Six , gdb-patches@sourceware.org References: <20231017111629.307261-1-lancelot.six@amd.com> From: Simon Marchi In-Reply-To: <20231017111629.307261-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 10/17/23 07:16, Lancelot Six wrote: > The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread" > command, but this is incorrect. If "continue" is given an argument, it > sets the ignore count of the breakpoint the thread stopped at. > > For this testcase it does not really matter since the breakpoint is not > meant to be hit anymore, so whatever the ignore count is won't influence > the outcome of the test. It is worth fixing nevertheless. > > While at changing it, switch to using "continue&" to consume the GDB > prompt right away. This makes the following pattern matching more > reliable. I don't understand the "more reliable" part, can you explain? Simon