From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126770 invoked by alias); 18 Apr 2017 11:33:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126738 invoked by uid 89); 18 Apr 2017 11:33:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=continuing, H*Ad:U*palves, pedro, Pedro X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 11:33:35 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE9A280F90; Tue, 18 Apr 2017 11:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EE9A280F90 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EE9A280F90 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A5F75C89D; Tue, 18 Apr 2017 11:33:35 +0000 (UTC) Subject: Re: [PATCH v2] PR threads/20743: Don't attempt to suspend or resume exited threads. To: John Baldwin , gdb-patches@sourceware.org References: <20170404173258.6512-1-jhb@FreeBSD.org> From: Pedro Alves Message-ID: <6e38199d-e3ec-a69d-70cd-b2754327ce6f@redhat.com> Date: Tue, 18 Apr 2017 11:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170404173258.6512-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00504.txt.bz2 On 04/04/2017 06:32 PM, John Baldwin wrote: > When resuming a native FreeBSD process, ignore exited threads when > suspending/resuming individual threads prior to continuing the process. > > gdb/ChangeLog: > > PR threads/20743 > * fbsd-nat.c (resume_one_thread_cb): Remove. > (resume_all_threads_cb): Remove. > (fbsd_resume): Use ALL_NON_EXITED_THREADS instead of > iterate_over_threads. LGTM. OK for master and 8.0. Thanks, Pedro Alves