Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

Sergio Durigan Junior
2018-09-12T17:59:10Z

On Wednesday, September 12 2018, Pedro Alves wrote:

> On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote:
>
>> The most simple fix for this problem is to move 'is_regular_file' to
>> 'filestuff.c', which is not used by IPA. This ends up making the
>> files more logically organized as well, since 'is_regular_file' is a
>> file operation.
>>
>> No regressions found.
>>
>> gdb/ChangeLog:
>> 2018-09-12 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * common/common-utils.c: Don't include '<sys/stat.h>'.
>> (is_regular_file): Move to...
>> * common/filestuff.c (is_regular_file): ... here.
>> * common/common-utils.h (is_regular_file): Move to...
>> * common/filestuff.h (is_regular_file): ... here.
>
> OK.

Thanks, pushed.

3c025cfe5efc44eb4dfb03b53dca28e75096dd1e

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible