Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

Joel Brobecker
2018-09-14T22:09:46Z

Hello Romain,

> > Me too. I can backport it to 8.2 if wanted.
>
> Yes please for the upcoming 8.2.1.

Once a release has been made off a give branch, there are a couple
of additional conditions before we can backport that change to
that branch:

- The patch needs to be safe, and you need approval from a Global
Maintainer to do so;

I looked at the patch, and although I was nervous about
the removal of the <stat.h> #include at first, I checked
the contents of the file, and I am reasonably certain that
there isn't any other code that might needed on some obscure
system. So you have my OK for the patch to be backported to
the gdb-8.2-branch.

- And the commit should have a corresponding GDB PR number
(https://sourceware.org/bugzilla/); the PR number acts as
a reference for "what's changed" in each corrective release,
so the clearer the explanation in the description, the better.

If you are the one motivated for the backport, it would be
helpful if you could take care of creating the PR. Sergio
offered to then backport it for you, but I can also help
with that.

Thank you,
--
Joel