Re: PATCH: 3/6 [2nd try]: Add AVX support (i386 changes)

Daniel Jacobowitz
2010-03-27T15:30:31Z

On Sat, Mar 27, 2010 at 03:54:56PM +0100, Mark Kettenis wrote:
> Yes, we have done that in the past, but I think we should stop adding
> #defines like that.

I disagree. The values are available in the kernel and glibc headers,
sure. But it takes years before a new define in linux/ptrace.h is
widely available, and it is not uncommon for new kernels to enter use
faster than that. This way, if someone builds a new GDB with AVX
support, and installs a new kernel with AVX support, they don't come
to us and ask why AVX support isn't in their GDB.

[I agree with everything else in Mark's review.]

--
Daniel Jacobowitz
CodeSourcery