Re: PATCH: 6/6 [2nd try]: Add AVX support (gdbserver changes)

H.J. Lu
2010-03-28T19:31:52Z

On Sun, Mar 28, 2010 at 9:38 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> On Sat, Mar 27, 2010 at 06:11:31PM -0700, H.J. Lu wrote:
>> I just follow the current format where SSE register set is marked with
>> EXTENDED_REGS for i386 and FP_REGS for x86-64. I don't mind
>> changing it to either of them for both i386 and x86-64. Just let me
>> know which one I should use.
>
> The only reason they're separate is that there was an FP_REGS already.
> It doesn't make any difference to the implementation.  I suggest
> EXTENDED_REGS unconditionally.

I will make the change.

>> Yes, I have tested them. The logic is in x86_linux_process_qsupported
>> which will set XML target to AVX if AVX is supported.
>
> Then you don't need to change USE_XML at all.
>
> Your goal is not to turn off support for "XML".  Your goal is to not
> report the AVX register description.  Before all your patches,
> gdbserver would have reported a tiny target description that
> contained the OSABI (e.g. "<osabi>GNU/Linux</osabi>").  That goes in
> gdbserver_xmltarget using the "@" prefix that this function checks
> for.
>
> I suggest building such an older gdbserver, to see what it returns.
>
>> > I think it'll work if you remove use_xml, and leave USE_XML alone.  If
>> > GDB does not support XML, you can adjust gdbserver_xmltarget to report
>> > just the architecture and OSABI the way it did before you added
>> > register XML files.
>> >
>>
>> I don't know how gdbserver_xmltarget should be set if gdb doesn't support
>> XML. My current approach is to turn off XML support at run-time even if
>> USE_XML is 1 when gdb doesn't support XML.
>
> Look at what USE_XML controls.  You do not need to turn off this block
> of code.

I will make the change.

Thanks.

--
H.J.