Re: PATCH: Cache types from target description

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Feb 9, 2010 at 10:47 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 9 Feb 2010 07:45:13 -0800
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>> Cc: GDB <gdb-patches@sourceware.org>,         Mark Kettenis <mark.kettenis@xs4all.nl>
>>
>> Here is the updated patch. I fixed i386_eflags and documented them.
>> OK to install?
>
> The doco part is okay, but please fix the following 2 minor issues
> before committing:
>
>> 2010-02-09  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>       * gdb.texinfo: Add i387_ext, i386_eflags and i386_mxcsr.
>
> Please state the name of the node in which you are making the change
> (in parens, as if it were a function).  You can find it by looking
> back from the locus of the change for a line that begins with
> "@node".
>
>> +@item i386_eflags
>> +32bit EFLAGS register used by x86.
>> +
>> +@item i386_mxcsr
>> +32bit MXCSR register used by x86.
>
> It would look prettier in print if you use @sc{eflags} and @sc{mxcsr}
> instead of up-casing them in the Texinfo sources.
>

This is the doc patch I am checking in. I will wait for OK on the other part.

Thanks.


-- 
H.J.
---
2010-02-09  H.J. Lu  <hongjiu.lu@intel.com>

	* gdb.texinfo (Predefined Target Types): Add i387_ext,
	i386_eflags and i386_mxcsr.

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index b31cfed..81c0b6b 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -32749,6 +32749,15 @@ Double precision IEEE floating point.
 @item arm_fpa_ext
 The 12-byte extended precision format used by ARM FPA registers.

+@item i387_ext
+The 10-byte extended precision format used by x87 registers.
+
+@item i386_eflags
+32bit @sc{eflags} register used by x86.
+
+@item i386_mxcsr
+32bit @sc{mxcsr} register used by x86.
+
 @end table

 @node Standard Target Features