From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17140 invoked by alias); 8 Feb 2010 19:13:09 -0000 Received: (qmail 17128 invoked by uid 22791); 8 Feb 2010 19:13:08 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f223.google.com (HELO mail-ew0-f223.google.com) (209.85.219.223) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 19:13:02 +0000 Received: by ewy23 with SMTP id 23so254081ewy.4 for ; Mon, 08 Feb 2010 11:13:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.87.134 with SMTP id y6mr1585752wee.20.1265656380029; Mon, 08 Feb 2010 11:13:00 -0800 (PST) In-Reply-To: <83d40fefpm.fsf@gnu.org> References: <20100208153337.GA25531@lucon.org> <83d40fefpm.fsf@gnu.org> Date: Mon, 08 Feb 2010 19:13:00 -0000 Message-ID: <6dc9ffc81002081113g2fa1ffb7kb0927b35a73f156f@mail.gmail.com> Subject: Re: PATCH: Document i386 target features From: "H.J. Lu" To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00217.txt.bz2 On Mon, Feb 8, 2010 at 10:37 AM, Eli Zaretskii wrote: >> Date: Mon, 8 Feb 2010 07:33:37 -0800 >> From: "H.J. Lu" >> >> Here is the patch to document i386 target features for i386 XML files >> I checked in. =A0OK to install? > > Thanks, I have a few comments: > >> +@cindex target descriptions, I386 features > > Index entries are supposed to be mostly in lower case. =A0Would it be > okay to use "i386" instead of I386 here? > >> +targets. =A0It should contain registers @samp{eax} through @samp{edi} >> +plus @samp{eip} for i386 and @samp{rax} through @samp{r15} plus >> +@samp{rip} for amd64, @samp{eflags}, @samp{cs}, @samp{ss}, @samp{ds}, >> +@samp{es}, @samp{fs}, @samp{gs}, registers @samp{st0} through @samp{st7= }, >> +@samp{fctrl}, @samp{fstat}, @samp{ftag}, @samp{fiseg}, @samp{fioff}, >> +@samp{foseg}, @samp{fooff} and @samp{fop}. > > This list is very long, and makes the sentence long and hard to > grasp. =A0I think it would be more palatable as an itemized list, like > so: > > =A0It should contain the following registers: > > =A0@itemize @minus > =A0@item > =A0@samp{eax} through @samp{edi} and @samp{eip} for i386 > =A0@item > =A0@samp{rax} through @samp{r15} plus @samp{rip} for amd64 > =A0@item > =A0@samp{eflags} > =A0@item > =A0@samp{cs}, @samp{ss}, @samp{ds}, @samp{es}, @samp{fs}, @samp{gs} > =A0... > =A0@end itemize > > (I grouped related registers together to make the list shorter). > > Btw, is it "contain the following registers" or "describe the > following registers"? > >> +They may be i386 or amd64 depending on the target. > > Who are "they" here? > Thanks for your comments. This patch generates: .4.2 i386 Features ------------------- The `org.gnu.gdb.i386.core' feature is required for i386/amd64 targets. It should describe the following registers: `eax' through `edi' plus `eip' for i386 - `rax' through `r15' plus `rip' for amd64 - `eflags', `cs', `ss', `ds', `es', `fs', `gs' - `st0' through `st7' - `fctrl', `fstat', `ftag', `fiseg', `fioff', `foseg', `fooff' and `fop' The register sets may be different, depending on the target. ... Will it be OK to install? Thanks. --=20 H.J. -- diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index f01a720..0b17685 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -32796,6 +32796,7 @@ registers using the capitalization used in the description. @menu * ARM Features:: +* i386 Features:: * MIPS Features:: * M68K Features:: * PowerPC Features:: @@ -32831,6 +32832,43 @@ quad-precision registers from pairs of double-precision registers. If this feature is present, @samp{org.gnu.gdb.arm.vfp} must also be present and include 32 double-precision registers. +@node i386 Features +@subsection i386 Features +@cindex target descriptions, i386 features + +The @samp{org.gnu.gdb.i386.core} feature is required for i386/amd64 +targets. It should describe the following registers: + +@itemize @minus +@samp{eax} through @samp{edi} plus @samp{eip} for i386 +@item +@samp{rax} through @samp{r15} plus @samp{rip} for amd64 +@item +@samp{eflags}, @samp{cs}, @samp{ss}, @samp{ds}, @samp{es}, +@samp{fs}, @samp{gs} +@item +@samp{st0} through @samp{st7} +@item +@samp{fctrl}, @samp{fstat}, @samp{ftag}, @samp{fiseg}, @samp{fioff}, +@samp{foseg}, @samp{fooff} and @samp{fop} +@end itemize + +The register sets may be different, depending on the target. + +The @samp{org.gnu.gdb.i386.sse} feature is required. It should +describe registers: + +@itemize @minus +@samp{xmm0} through @samp{xmm7} for i386 +@item +@samp{xmm0} through @samp{xmm15} for amd64 +@item +@samp{mxcsr} +@end itemize + +The @samp{org.gnu.gdb.i386.linux} feature is optional. It should +describe a single register, @samp{orig_eax}. + @node MIPS Features @subsection MIPS Features @cindex target descriptions, MIPS features