From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70029-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28017 invoked by alias); 7 Feb 2010 21:55:47 -0000
Received: (qmail 28009 invoked by uid 22791); 7 Feb 2010 21:55:46 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.144)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Feb 2010 21:55:42 +0000
Received: by ey-out-1920.google.com with SMTP id 13so697991eye.0         for <gdb-patches@sourceware.org>; Sun, 07 Feb 2010 13:55:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.216.90.14 with SMTP id d14mr1441656wef.30.1265579740041; Sun,  	07 Feb 2010 13:55:40 -0800 (PST)
In-Reply-To: <20100207214956.GA3528@caradoc.them.org>
References: <20100204235952.GA27284@lucon.org> 	 <20100205000052.GA27361@lucon.org> 	 <20100207214956.GA3528@caradoc.them.org>
Date: Sun, 07 Feb 2010 21:55:00 -0000
Message-ID: <6dc9ffc81002071355h7f89ad5bxd54d9c75dc35a64a@mail.gmail.com>
Subject: Re: PATCH: Add x86 xml files
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00188.txt.bz2

On Sun, Feb 7, 2010 at 1:50 PM, Daniel Jacobowitz <dan@codesourcery.com> wr=
ote:
> On Thu, Feb 04, 2010 at 04:00:52PM -0800, H.J. Lu wrote:
>> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
>> +<feature name=3D"org.gnu.gdb.i386.core">
>
> In addition to Mark's comments:
>
> * The new features will need to be documented in the manual. =A0I'd
> recommend doing that along with the XML files.

I will do that.

> * I can't remember exactly why there are some previously existing
> features with the same name and two possible contents. =A0It seems like
> a better idea to call one of these org.gnu.gdb.x86_64.* (or x86-64 or
> amd64 or whatever).

That is done on purpose so that i386-tdep.c can have

---
  /* Get the x86 target description from INFO.  We support both
     32bit and 64bit if BFD64 is defined.  */
  tdesc =3D info.target_desc;
  if (! tdesc_has_registers (tdesc))
    {
      if (info.bfd_arch_info->bits_per_word =3D=3D 32)
        tdesc =3D tdesc_i386;
      else
#ifdef BFD64
        tdesc =3D tdesc_x86_64;
#else
        return NULL;
#endif
    }

  gdb_assert (tdesc_has_registers (tdesc));

  /* Get core registers.  */
  feature_core =3D tdesc_find_feature (tdesc, "org.gnu.gdb.i386.core");
  if (feature_core =3D=3D NULL)
    return NULL;
---

to support both 32bit and 64bit, avoiding unnecessary complication and
code duplication. That is how it is done for PPC/RS6000.

> Otherwise, it seems fine to me.
>

Thanks.

--=20
H.J.