From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9629 invoked by alias); 4 Feb 2010 16:55:30 -0000 Received: (qmail 9620 invoked by uid 22791); 4 Feb 2010 16:55:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 16:55:22 +0000 Received: by wwb29 with SMTP id 29so299339wwb.0 for ; Thu, 04 Feb 2010 08:55:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.178.9 with SMTP id e9mr814990wem.195.1265302520140; Thu, 04 Feb 2010 08:55:20 -0800 (PST) In-Reply-To: <20100204160416.GB14962@caradoc.them.org> References: <20100204154910.GA2593@lucon.org> <20100204160416.GB14962@caradoc.them.org> Date: Thu, 04 Feb 2010 16:55:00 -0000 Message-ID: <6dc9ffc81002040854h6d88e085x4026d5a8320eeee7@mail.gmail.com> Subject: Re: PATCH: Generate set_tdesc_osabi for valid OSABI From: "H.J. Lu" To: GDB Content-Type: multipart/mixed; boundary=0016368336e83f1609047ec933b3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00118.txt.bz2 --0016368336e83f1609047ec933b3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 622 On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz wr= ote: > On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote: >> 2010-02-04 =A0H.J. Lu =A0 >> >> =A0 =A0 =A0 * target-descriptions.c (maint_print_c_tdesc_cmd): Generate >> =A0 =A0 =A0 set_tdesc_osabi for valid OSABI. > > This patch would require regenerating the board files after changing > the enum. =A0If we have to hard-code the value, there should be a > warning to only add new items to the end of the enum unless > regenerating the files. > Good point. How about using OSABI string instead? Thanks. --=20 H.J. --0016368336e83f1609047ec933b3 Content-Type: text/plain; charset=US-ASCII; name="gdb-tdesc-2.patch" Content-Disposition: attachment; filename="gdb-tdesc-2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g59seytx0 Content-length: 1814 MjAxMC0wMi0wNCAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogdGFyZ2V0LWRlc2NyaXB0aW9ucy5jOiBJbmNsdWRlICJvc2FiaS5oIi4K CShtYWludF9wcmludF9jX3RkZXNjX2NtZCk6IEdlbmVyYXRlIHNldF90ZGVz Y19vc2FiaSBmb3IgdmFsaWQKCU9TQUJJLgoKZGlmZiAtLWdpdCBhL2dkYi90 YXJnZXQtZGVzY3JpcHRpb25zLmMgYi9nZGIvdGFyZ2V0LWRlc2NyaXB0aW9u cy5jCmluZGV4IDcyMGYwYzcuLjIyMzcxZWQgMTAwNjQ0Ci0tLSBhL2dkYi90 YXJnZXQtZGVzY3JpcHRpb25zLmMKKysrIGIvZ2RiL3RhcmdldC1kZXNjcmlw dGlvbnMuYwpAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgInZlYy5oIgog I2luY2x1ZGUgInhtbC1zdXBwb3J0LmgiCiAjaW5jbHVkZSAieG1sLXRkZXNj LmgiCisjaW5jbHVkZSAib3NhYmkuaCIKIAogI2luY2x1ZGUgImdkYl9hc3Nl cnQuaCIKICNpbmNsdWRlICJnZGJfb2JzdGFjay5oIgpAQCAtMTQwNiw2ICsx NDA3LDcgQEAgbWFpbnRfcHJpbnRfY190ZGVzY19jbWQgKGNoYXIgKmFyZ3Ms IGludCBmcm9tX3R0eSkKICAgcHJpbnRmX3VuZmlsdGVyZWQgKCIvKiBUSElT IEZJTEUgSVMgR0VORVJBVEVELiAgT3JpZ2luYWw6ICVzICovXG5cbiIsCiAJ CSAgICAgZmlsZW5hbWUpOwogICBwcmludGZfdW5maWx0ZXJlZCAoIiNpbmNs dWRlIFwiZGVmcy5oXCJcbiIpOworICBwcmludGZfdW5maWx0ZXJlZCAoIiNp bmNsdWRlIFwib3NhYmkuaFwiXG4iKTsKICAgcHJpbnRmX3VuZmlsdGVyZWQg KCIjaW5jbHVkZSBcInRhcmdldC1kZXNjcmlwdGlvbnMuaFwiXG4iKTsKICAg cHJpbnRmX3VuZmlsdGVyZWQgKCJcbiIpOwogCkBAIC0xNDI3LDYgKzE0Mjks MTUgQEAgbWFpbnRfcHJpbnRfY190ZGVzY19jbWQgKGNoYXIgKmFyZ3MsIGlu dCBmcm9tX3R0eSkKICAgICAgIHByaW50Zl91bmZpbHRlcmVkICgiXG4iKTsK ICAgICB9CiAKKyAgaWYgKHRkZXNjX29zYWJpICh0ZGVzYykgPiBHREJfT1NB QklfVU5LTk9XTgorICAgICAgJiYgdGRlc2Nfb3NhYmkgKHRkZXNjKSA8IEdE Ql9PU0FCSV9JTlZBTElEKQorICAgIHsKKyAgICAgIHByaW50Zl91bmZpbHRl cmVkCisJKCIgIHNldF90ZGVzY19vc2FiaSAocmVzdWx0LCBvc2FiaV9mcm9t X3RkZXNjX3N0cmluZyAoXCIlc1wiKSk7XG4iLAorCSBnZGJhcmNoX29zYWJp X25hbWUgKHRkZXNjX29zYWJpICh0ZGVzYykpKTsKKyAgICAgIHByaW50Zl91 bmZpbHRlcmVkICgiXG4iKTsKKyAgICB9CisKICAgZm9yIChpeCA9IDA7IFZF Q19pdGVyYXRlIChhcmNoX3AsIHRkZXNjLT5jb21wYXRpYmxlLCBpeCwgY29t cGF0aWJsZSk7CiAgICAgICAgaXgrKykKICAgICB7Cg== --0016368336e83f1609047ec933b3--