From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22210 invoked by alias); 3 Feb 2010 18:31:24 -0000 Received: (qmail 22200 invoked by uid 22791); 3 Feb 2010 18:31:23 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SARE_SUB_OBFU_Q1,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f223.google.com (HELO mail-ew0-f223.google.com) (209.85.219.223) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Feb 2010 18:31:16 +0000 Received: by ewy23 with SMTP id 23so296301ewy.4 for ; Wed, 03 Feb 2010 10:31:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.89.130 with SMTP id c2mr2310760wef.44.1265221873888; Wed, 03 Feb 2010 10:31:13 -0800 (PST) In-Reply-To: <20100203175604.GA12046@caradoc.them.org> References: <20100203040339.GA24984@lucon.org> <20100203135848.GA27938@caradoc.them.org> <6dc9ffc81002030605k6eadda3me45828f7c8c6a362@mail.gmail.com> <20100203142202.GB28951@caradoc.them.org> <6dc9ffc81002030634wd2976e5t2a42b639c455b850@mail.gmail.com> <20100203144626.GA31389@caradoc.them.org> <6dc9ffc81002030708n413c1784g3979207a08cdd9c7@mail.gmail.com> <20100203152350.GA1580@caradoc.them.org> <6dc9ffc81002030844h3d6cc2b5ye67c79d52defdce5@mail.gmail.com> <20100203175604.GA12046@caradoc.them.org> Date: Wed, 03 Feb 2010 18:31:00 -0000 Message-ID: <6dc9ffc81002031031h6d023489tc39f052db10537db@mail.gmail.com> Subject: Re: RFC: Support target specific qSupported From: "H.J. Lu" To: "H.J. Lu" , GDB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00085.txt.bz2 On Wed, Feb 3, 2010 at 9:56 AM, Daniel Jacobowitz wr= ote: > On Wed, Feb 03, 2010 at 08:44:03AM -0800, H.J. Lu wrote: >> @@ -566,6 +569,9 @@ init_remote_state (struct gdbarch *gdbarch) >> =A0 =A0 =A0 =A0rs->buf =3D xrealloc (rs->buf, rs->buf_size); >> =A0 =A0 =A0} >> >> + =A0/* Record our GDBARCH. =A0*/ >> + =A0rs->gdbarch =3D gdbarch; >> + >> =A0 =A0return rsa; >> =A0} >> > > Sorry, I didn't notice this before. =A0Is target_gdbarch available at > this point? =A0That's the one I'd expect. > Yes, I can use target_gdbarch. I checked in this patch to remove gdbarch from remote_state. Thanks. --=20 H.J. --diff --git a/gdb/ChangeLog b/gdb/ChangeLog index af536a7..ade4aa0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2010-02-03 H.J. Lu + * remote.c (remote_state): Remove gdbarch. + (init_remote_state): Don't set gdbarch. + (remote_query_supported): Pass target_gdbarch instead of + rs->gdbarch to gdbarch_qsupported. + +2010-02-03 H.J. Lu + * gdbarch.sh: Add qsupported. * gdbarch.c: Regenerated. diff --git a/gdb/remote.c b/gdb/remote.c index 2c3dfdb..709e424 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -327,9 +327,6 @@ struct remote_state /* Nonzero if the user has pressed Ctrl-C, but the target hasn't responded to that. */ int ctrlc_pending_p; - - /* GDBARCH associated with this target. */ - struct gdbarch *gdbarch; }; /* Private data that we'll store in (struct thread_info)->private. */ @@ -569,9 +566,6 @@ init_remote_state (struct gdbarch *gdbarch) rs->buf =3D xrealloc (rs->buf, rs->buf_size); } - /* Record our GDBARCH. */ - rs->gdbarch =3D gdbarch; - return rsa; } @@ -3481,7 +3475,7 @@ remote_query_supported (void) rs->buf[0] =3D 0; if (remote_protocol_packets[PACKET_qSupported].support !=3D PACKET_DISAB= LE) { - const char *qsupported =3D gdbarch_qsupported (rs->gdbarch); + const char *qsupported =3D gdbarch_qsupported (target_gdbarch); if (qsupported) { char *q;