From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1517 invoked by alias); 3 Feb 2010 15:08:36 -0000 Received: (qmail 1495 invoked by uid 22791); 3 Feb 2010 15:08:33 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SARE_SUB_OBFU_Q1,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-fx0-f209.google.com (HELO mail-fx0-f209.google.com) (209.85.220.209) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Feb 2010 15:08:29 +0000 Received: by fxm1 with SMTP id 1so1533821fxm.4 for ; Wed, 03 Feb 2010 07:08:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.90.195 with SMTP id e45mr3586437wef.189.1265209706175; Wed, 03 Feb 2010 07:08:26 -0800 (PST) In-Reply-To: <20100203144626.GA31389@caradoc.them.org> References: <20100203040339.GA24984@lucon.org> <20100203135848.GA27938@caradoc.them.org> <6dc9ffc81002030605k6eadda3me45828f7c8c6a362@mail.gmail.com> <20100203142202.GB28951@caradoc.them.org> <6dc9ffc81002030634wd2976e5t2a42b639c455b850@mail.gmail.com> <20100203144626.GA31389@caradoc.them.org> Date: Wed, 03 Feb 2010 15:08:00 -0000 Message-ID: <6dc9ffc81002030708n413c1784g3979207a08cdd9c7@mail.gmail.com> Subject: Re: RFC: Support target specific qSupported From: "H.J. Lu" To: "H.J. Lu" , GDB Content-Type: multipart/mixed; boundary=0016e6dab1001a5c6f047eb3974a X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00074.txt.bz2 --0016e6dab1001a5c6f047eb3974a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1534 On Wed, Feb 3, 2010 at 6:46 AM, Daniel Jacobowitz wr= ote: > On Wed, Feb 03, 2010 at 06:34:14AM -0800, H.J. Lu wrote: >> We have our own remote gdb stub, which needs to talk to both old gdb, >> which only understands SSE g/G packet, and new gdb, which understands >> AVX g/G packet. Does the target description support negotiation so >> that old gdb and new remote gdb stub can use SSE g/G packet? > > The goal of target descriptions is to not need negotiation. > Everything is controlled by the target. =A0But with older GDBs, because > x86 did not get target-described register support right away, there's > a problem. It is not a trivial to implement target-described register support for x86. But I think it is a good thing to do. > I suggest adding something to the GDB-side qSupported packet saying > that AVX is OK. =A0You don't need anything on the stub side of the > qSupported reply; you just need to reply to qXfer:features. > How about this patch? It allows a target to add a field to qSupported. Thanks. --=20 H.J. --- 2010-02-03 H.J. Lu * gdbarch.c (gdbarch): Add qsupported. (startup_gdbarch): Likewise. (gdbarch_alloc): Likewise. (verify_gdbarch): Likewise. (gdbarch_dump): Likewise. (gdbarch_qsupported): New. (set_gdbarch_qsupported): Likewise. * gdbarch.h (gdbarch_qsupported): New. (set_gdbarch_qsupported): Likewise. * remote.c (remote_state): Add gdbarch. (init_remote_state): Set gdbarch. (remote_query_supported): Support gdbarch_qsupported. --0016e6dab1001a5c6f047eb3974a Content-Type: text/plain; charset=US-ASCII; name="gdb-qsupported-2.patch" Content-Disposition: attachment; filename="gdb-qsupported-2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g5893xua0 Content-length: 6898 MjAxMC0wMi0wMyAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogZ2RiYXJjaC5jIChnZGJhcmNoKTogQWRkIHFzdXBwb3J0ZWQuCgkoc3Rh cnR1cF9nZGJhcmNoKTogTGlrZXdpc2UuCgkoZ2RiYXJjaF9hbGxvYyk6IExp a2V3aXNlLgoJKHZlcmlmeV9nZGJhcmNoKTogTGlrZXdpc2UuCgkoZ2RiYXJj aF9kdW1wKTogTGlrZXdpc2UuCgkoZ2RiYXJjaF9xc3VwcG9ydGVkKTogTmV3 LgoJKHNldF9nZGJhcmNoX3FzdXBwb3J0ZWQpOiBMaWtld2lzZS4KCgkqIGdk YmFyY2guaCAoZ2RiYXJjaF9xc3VwcG9ydGVkKTogTmV3LgoJKHNldF9nZGJh cmNoX3FzdXBwb3J0ZWQpOiBMaWtld2lzZS4KCgkqIHJlbW90ZS5jIChyZW1v dGVfc3RhdGUpOiBBZGQgZ2RiYXJjaC4KCShpbml0X3JlbW90ZV9zdGF0ZSk6 IFNldCBnZGJhcmNoLgoJKHJlbW90ZV9xdWVyeV9zdXBwb3J0ZWQpOiBTdXBw b3J0IGdkYmFyY2hfcXN1cHBvcnRlZC4KCmRpZmYgLS1naXQgYS9nZGIvZ2Ri YXJjaC5jIGIvZ2RiL2dkYmFyY2guYwppbmRleCA2NDQ4ZmMzLi5mNTRhMTgx IDEwMDY0NAotLS0gYS9nZGIvZ2RiYXJjaC5jCisrKyBiL2dkYi9nZGJhcmNo LmMKQEAgLTI1Miw2ICsyNTIsNyBAQCBzdHJ1Y3QgZ2RiYXJjaAogICBpbnQg aGFzX2dsb2JhbF9icmVha3BvaW50czsKICAgZ2RiYXJjaF9oYXNfc2hhcmVk X2FkZHJlc3Nfc3BhY2VfZnR5cGUgKmhhc19zaGFyZWRfYWRkcmVzc19zcGFj ZTsKICAgZ2RiYXJjaF9mYXN0X3RyYWNlcG9pbnRfdmFsaWRfYXRfZnR5cGUg KmZhc3RfdHJhY2Vwb2ludF92YWxpZF9hdDsKKyAgY29uc3QgY2hhciAqcXN1 cHBvcnRlZDsKIH07CiAKIApAQCAtMzk1LDYgKzM5Niw3IEBAIHN0cnVjdCBn ZGJhcmNoIHN0YXJ0dXBfZ2RiYXJjaCA9CiAgIDAsICAvKiBoYXNfZ2xvYmFs X2JyZWFrcG9pbnRzICovCiAgIGRlZmF1bHRfaGFzX3NoYXJlZF9hZGRyZXNz X3NwYWNlLCAgLyogaGFzX3NoYXJlZF9hZGRyZXNzX3NwYWNlICovCiAgIGRl ZmF1bHRfZmFzdF90cmFjZXBvaW50X3ZhbGlkX2F0LCAgLyogZmFzdF90cmFj ZXBvaW50X3ZhbGlkX2F0ICovCisgIDAsICAvKiBxc3VwcG9ydGVkICovCiAg IC8qIHN0YXJ0dXBfZ2RiYXJjaCgpICovCiB9OwogCkBAIC00ODEsNiArNDgz LDcgQEAgZ2RiYXJjaF9hbGxvYyAoY29uc3Qgc3RydWN0IGdkYmFyY2hfaW5m byAqaW5mbywKICAgZ2RiYXJjaC0+dGFyZ2V0X3NpZ25hbF90b19ob3N0ID0g ZGVmYXVsdF90YXJnZXRfc2lnbmFsX3RvX2hvc3Q7CiAgIGdkYmFyY2gtPmhh c19zaGFyZWRfYWRkcmVzc19zcGFjZSA9IGRlZmF1bHRfaGFzX3NoYXJlZF9h ZGRyZXNzX3NwYWNlOwogICBnZGJhcmNoLT5mYXN0X3RyYWNlcG9pbnRfdmFs aWRfYXQgPSBkZWZhdWx0X2Zhc3RfdHJhY2Vwb2ludF92YWxpZF9hdDsKKyAg Z2RiYXJjaC0+cXN1cHBvcnRlZCA9IE5VTEw7CiAgIC8qIGdkYmFyY2hfYWxs b2MoKSAqLwogCiAgIHJldHVybiBnZGJhcmNoOwpAQCAtNjYxLDYgKzY2NCw3 IEBAIHZlcmlmeV9nZGJhcmNoIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCkK ICAgLyogU2tpcCB2ZXJpZnkgb2YgaGFzX2dsb2JhbF9icmVha3BvaW50cywg aW52YWxpZF9wID09IDAgKi8KICAgLyogU2tpcCB2ZXJpZnkgb2YgaGFzX3No YXJlZF9hZGRyZXNzX3NwYWNlLCBpbnZhbGlkX3AgPT0gMCAqLwogICAvKiBT a2lwIHZlcmlmeSBvZiBmYXN0X3RyYWNlcG9pbnRfdmFsaWRfYXQsIGludmFs aWRfcCA9PSAwICovCisgIC8qIFNraXAgdmVyaWZ5IG9mIHFzdXBwb3RlZCwg aW52YWxpZF9wID09IDAgKi8KICAgYnVmID0gdWlfZmlsZV94c3RyZHVwIChs b2csICZsZW5ndGgpOwogICBtYWtlX2NsZWFudXAgKHhmcmVlLCBidWYpOwog ICBpZiAobGVuZ3RoID4gMCkKQEAgLTExODQsNiArMTE4OCw5IEBAIGdkYmFy Y2hfZHVtcCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB1aV9m aWxlICpmaWxlKQogICBmcHJpbnRmX3VuZmlsdGVyZWQgKGZpbGUsCiAgICAg ICAgICAgICAgICAgICAgICAgImdkYmFyY2hfZHVtcDogd3JpdGVfcGMgPSA8 JXM+XG4iLAogICAgICAgICAgICAgICAgICAgICAgIGhvc3RfYWRkcmVzc190 b19zdHJpbmcgKGdkYmFyY2gtPndyaXRlX3BjKSk7CisgIGZwcmludGZfdW5m aWx0ZXJlZCAoZmlsZSwKKyAgICAgICAgICAgICAgICAgICAgICAiZ2RiYXJj aF9kdW1wOiBxc3VwcG9ydGVkID0gPCVzPlxuIiwKKwkJICAgICAgZ2RiYXJj aC0+cXN1cHBvcnRlZCk7CiAgIGlmIChnZGJhcmNoLT5kdW1wX3RkZXAgIT0g TlVMTCkKICAgICBnZGJhcmNoLT5kdW1wX3RkZXAgKGdkYmFyY2gsIGZpbGUp OwogfQpAQCAtMzU3Niw2ICszNTgzLDIyIEBAIHNldF9nZGJhcmNoX2Zhc3Rf dHJhY2Vwb2ludF92YWxpZF9hdCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gs CiAgIGdkYmFyY2gtPmZhc3RfdHJhY2Vwb2ludF92YWxpZF9hdCA9IGZhc3Rf dHJhY2Vwb2ludF92YWxpZF9hdDsKIH0KIAorY29uc3QgY2hhciAqCitnZGJh cmNoX3FzdXBwb3J0ZWQgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoKQorewor ICBnZGJfYXNzZXJ0IChnZGJhcmNoICE9IE5VTEwpOworICBnZGJfYXNzZXJ0 IChnZGJhcmNoLT5xc3VwcG9ydGVkICE9IE5VTEwpOworICBpZiAoZ2RiYXJj aF9kZWJ1ZyA+PSAyKQorICAgIGZwcmludGZfdW5maWx0ZXJlZCAoZ2RiX3N0 ZGxvZywgImdkYmFyY2hfcXN1cHBvcnRlZCBjYWxsZWRcbiIpOworICByZXR1 cm4gZ2RiYXJjaC0+cXN1cHBvcnRlZDsKK30KKwordm9pZAorc2V0X2dkYmFy Y2hfcXN1cHBvcnRlZCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsCisJCQlj b25zdCBjaGFyICpxc3VwcG9ydGVkKQoreworICBnZGJhcmNoLT5xc3VwcG9y dGVkID0gcXN1cHBvcnRlZDsKK30KIAogLyogS2VlcCBhIHJlZ2lzdHJ5IG9m IHBlci1hcmNoaXRlY3R1cmUgZGF0YS1wb2ludGVycyByZXF1aXJlZCBieSBH REIKICAgIG1vZHVsZXMuICovCmRpZmYgLS1naXQgYS9nZGIvZ2RiYXJjaC5o IGIvZ2RiL2dkYmFyY2guaAppbmRleCA2NjFkMzRiLi5lNzdmMDI3IDEwMDY0 NAotLS0gYS9nZGIvZ2RiYXJjaC5oCisrKyBiL2dkYi9nZGJhcmNoLmgKQEAg LTkyMyw2ICs5MjMsMTIgQEAgdHlwZWRlZiBpbnQgKGdkYmFyY2hfZmFzdF90 cmFjZXBvaW50X3ZhbGlkX2F0X2Z0eXBlKSAoc3RydWN0IGdkYmFyY2ggKmdk YmFyY2gsIEMKIGV4dGVybiBpbnQgZ2RiYXJjaF9mYXN0X3RyYWNlcG9pbnRf dmFsaWRfYXQgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBDT1JFX0FERFIg YWRkciwgaW50ICppc2l6ZSwgY2hhciAqKm1zZyk7CiBleHRlcm4gdm9pZCBz ZXRfZ2RiYXJjaF9mYXN0X3RyYWNlcG9pbnRfdmFsaWRfYXQgKHN0cnVjdCBn ZGJhcmNoICpnZGJhcmNoLCBnZGJhcmNoX2Zhc3RfdHJhY2Vwb2ludF92YWxp ZF9hdF9mdHlwZSAqZmFzdF90cmFjZXBvaW50X3ZhbGlkX2F0KTsKIAorLyog Tm90IE5VTEwgaWYgYSB0YXJnZXQgaGFzIGFkZGl0b25hbCBmaWVsZCBmb3Ig cVN1cHBvcnRlZC4gICovCisKK2V4dGVybiBjb25zdCBjaGFyICpnZGJhcmNo X3FzdXBwb3J0ZWQgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoKTsKK2V4dGVy biB2b2lkIHNldF9nZGJhcmNoX3FzdXBwb3J0ZWQgKHN0cnVjdCBnZGJhcmNo ICpnZGJhcmNoLAorCQkJCSAgICBjb25zdCBjaGFyICpxc3VwcG9ydGVkKTsK KwogLyogRGVmaW5pdGlvbiBmb3IgYW4gdW5rbm93biBzeXNjYWxsLCB1c2Vk IGJhc2ljYWxseSBpbiBlcnJvci1jYXNlcy4gICovCiAjZGVmaW5lIFVOS05P V05fU1lTQ0FMTCAoLTEpCiAKZGlmZiAtLWdpdCBhL2dkYi9yZW1vdGUuYyBi L2dkYi9yZW1vdGUuYwppbmRleCBiZjc1NjhjLi5lMDkxZDRiIDEwMDY0NAot LS0gYS9nZGIvcmVtb3RlLmMKKysrIGIvZ2RiL3JlbW90ZS5jCkBAIC0zMjcs NiArMzI3LDkgQEAgc3RydWN0IHJlbW90ZV9zdGF0ZQogICAvKiBOb256ZXJv IGlmIHRoZSB1c2VyIGhhcyBwcmVzc2VkIEN0cmwtQywgYnV0IHRoZSB0YXJn ZXQgaGFzbid0CiAgICAgIHJlc3BvbmRlZCB0byB0aGF0LiAgKi8KICAgaW50 IGN0cmxjX3BlbmRpbmdfcDsKKworICAvKiBHREJBUkNIIGFzc29jaWF0ZWQg d2l0aCB0aGlzIHRhcmdldC4gICovCisgIHN0cnVjdCBnZGJhcmNoICpnZGJh cmNoOwogfTsKIAogLyogUHJpdmF0ZSBkYXRhIHRoYXQgd2UnbGwgc3RvcmUg aW4gKHN0cnVjdCB0aHJlYWRfaW5mbyktPnByaXZhdGUuICAqLwpAQCAtNTY2 LDYgKzU2OSw5IEBAIGluaXRfcmVtb3RlX3N0YXRlIChzdHJ1Y3QgZ2RiYXJj aCAqZ2RiYXJjaCkKICAgICAgIHJzLT5idWYgPSB4cmVhbGxvYyAocnMtPmJ1 ZiwgcnMtPmJ1Zl9zaXplKTsKICAgICB9CiAKKyAgLyogUmVjb3JkIG91ciBH REJBUkNILiAgKi8KKyAgcnMtPmdkYmFyY2ggPSBnZGJhcmNoOworCiAgIHJl dHVybiByc2E7CiB9CiAKQEAgLTM0NzUsMTAgKzM0ODEsMjQgQEAgcmVtb3Rl X3F1ZXJ5X3N1cHBvcnRlZCAodm9pZCkKICAgcnMtPmJ1ZlswXSA9IDA7CiAg IGlmIChyZW1vdGVfcHJvdG9jb2xfcGFja2V0c1tQQUNLRVRfcVN1cHBvcnRl ZF0uc3VwcG9ydCAhPSBQQUNLRVRfRElTQUJMRSkKICAgICB7Ci0gICAgICBp ZiAocnMtPmV4dGVuZGVkKQotCXB1dHBrdCAoInFTdXBwb3J0ZWQ6bXVsdGlw cm9jZXNzKyIpOworICAgICAgY29uc3QgY2hhciAqcXN1cHBvcnRlZCA9IGdk YmFyY2hfcXN1cHBvcnRlZCAocnMtPmdkYmFyY2gpOworICAgICAgaWYgKHFz dXBwb3J0ZWQpCisJeworCSAgY2hhciAqcTsKKwkgIGlmIChycy0+ZXh0ZW5k ZWQpCisJICAgIHEgPSBjb25jYXQgKCJxU3VwcG9ydGVkOm11bHRpcHJvY2Vz cys7IiwgcXN1cHBvcnRlZCwgTlVMTCk7CisJICBlbHNlCisJICAgIHEgPSBj b25jYXQgKCJxU3VwcG9ydGVkOiIsIHFzdXBwb3J0ZWQsIE5VTEwpOworCSAg cHV0cGt0IChxKTsKKwkgIGZyZWUgKHEpOworCX0KICAgICAgIGVsc2UKLQlw dXRwa3QgKCJxU3VwcG9ydGVkIik7CisJeworCSAgaWYgKHJzLT5leHRlbmRl ZCkKKwkgICAgcHV0cGt0ICgicVN1cHBvcnRlZDptdWx0aXByb2Nlc3MrIik7 CisJICBlbHNlCisJICAgIHB1dHBrdCAoInFTdXBwb3J0ZWQiKTsKKwl9CiAK ICAgICAgIGdldHBrdCAoJnJzLT5idWYsICZycy0+YnVmX3NpemUsIDApOwog Cg== --0016e6dab1001a5c6f047eb3974a--