From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62234-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15283 invoked by alias); 17 Mar 2009 23:59:37 -0000
Received: (qmail 15267 invoked by uid 22791); 17 Mar 2009 23:59:36 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from yw-out-1718.google.com (HELO yw-out-1718.google.com) (74.125.46.156)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Mar 2009 23:59:29 +0000
Received: by yw-out-1718.google.com with SMTP id 9so174728ywk.48         for <multiple recipients>; Tue, 17 Mar 2009 16:59:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.3.7 with SMTP id f7mr226574wfi.92.1237334366214; Tue, 17  	Mar 2009 16:59:26 -0700 (PDT)
In-Reply-To: <005001c9a757$db6bacb0$92430610$@u-strasbg.fr>
References: <005001c9a757$db6bacb0$92430610$@u-strasbg.fr>
Date: Wed, 18 Mar 2009 00:08:00 -0000
Message-ID: <6dc9ffc80903171659t2319301ey2b78f39aa4ae1d7c@mail.gmail.com>
Subject: Re: [RFA] fix bfd multi-arch compilation failure
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00344.txt.bz2

On Tue, Mar 17, 2009 at 4:26 PM, Pierre Muller <muller@ics.u-strasbg.fr> wr=
ote:
> Hi,
> I tried to do a compilation of
> gdb with --enable-targets=3Dall --enable-64-bits-bfd
> on OpenSolaris 2008.11.
>
> I found two problems in bfd directory,
> related to uses of alloca without
> including <alloca.h>
>
> I added
> #include <alloca.h>
> garded by #ifdef HAVE_ALLOCA_H
> as I suppose that on some systems
> alloca is builtin and thus does not require any header.
>
>
> Is this OK to check in?
>
>
> Pierre Muller
> Pascal language support maintainer for GDB
>
>
>
> ChangeLog entry:
>
> 2009-03-18 =A0Pierre Muller =A0<muller@ics.u-strasbg.fr>
>
> =A0 =A0 =A0 =A0* elf32-m68hc1x.c: Add alloca header.
> =A0 =A0 =A0 =A0* xsym.c: Ditto.
>
>
> Index: bfd/elf32-m68hc1x.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/bfd/elf32-m68hc1x.c,v
> retrieving revision 1.33
> diff -u -p -r1.33 elf32-m68hc1x.c
> --- bfd/elf32-m68hc1x.c 12 Mar 2008 08:36:59 -0000 =A0 =A0 =A01.33
> +++ bfd/elf32-m68hc1x.c 17 Mar 2009 23:18:58 -0000
> @@ -20,6 +20,9 @@
> =A0 =A0Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
> =A0 =A0MA 02110-1301, USA. =A0*/
>
> +#ifdef HAVE_ALLOCA_H
> +#include <alloca.h>
> +#endif
> =A0#include "sysdep.h"
> =A0#include "bfd.h"
> =A0#include "bfdlink.h"

That is wrong. Please see how it is handled in elf64-hppa.c.


--=20
H.J.