From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113870 invoked by alias); 11 Jun 2017 17:27:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113754 invoked by uid 89); 11 Jun 2017 17:27:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Jun 2017 17:27:11 +0000 Received: by simark.ca (Postfix, from userid 33) id A50051E4D7; Sun, 11 Jun 2017 13:27:13 -0400 (EDT) To: Orgad Shaneh Subject: Re: [PATCH] Fix python compatibility with old gdb versions X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 11 Jun 2017 17:27:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: References: Message-ID: <6db93f9feb8494733acc678ed145b4fc@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00262.txt.bz2 On 2017-06-11 15:55, Orgad Shaneh wrote: > On Wed, Mar 8, 2017 at 10:23 AM, Orgad Shaneh wrote: >> >> Type.name was introduced in GDB 7.9. >> --- >> gdb/python/lib/gdb/printing.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/python/lib/gdb/printing.py >> b/gdb/python/lib/gdb/printing.py >> index 181701c719..106da4ac8b 100644 >> --- a/gdb/python/lib/gdb/printing.py >> +++ b/gdb/python/lib/gdb/printing.py >> @@ -205,7 +205,7 @@ class >> RegexpCollectionPrettyPrinter(PrettyPrinter): >> >> # Get the type name. >> typename = gdb.types.get_basic_type(val.type).tag >> - if not typename: >> + if not typename and hasattr(val.type, "name"): >> typename = val.type.name >> if not typename: >> return None >> -- >> 2.12.0.windows.1 > > ping? > > - Orgad Hi Orgad, Thanks for submitting this, and sorry for the wait. Could you provide a little bit of context to help others understand what's wrong? Can you give some details on how to reproduce the problem? Make sure to add it to the commit message. Also, please include a ChangeLog entry in your commit message, more details here: https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog If anything is not clear, please ask. Thanks, Simon