Re: [RFA 11/13] Remove unused variables from gdbserver

Pedro Alves
2018-07-16T14:16:26Z

On 07/14/2018 03:47 AM, Simon Marchi wrote:
> On 2018-07-12 04:52 PM, Tom Tromey wrote:
>> This removes a few unused variables from gdbserver.
>>
>> The x86-tdesc.h change is a bit unusual for this series. This file
>> was not defining the multiple-include guard symbol, so I've added that
>> here. Also, it is hard to determine when i386_expedite_regs will be
>> needed, so this patch simply marks it ATTRIBUTE_UNUSED.
>
> That sounds reasonable to me, LGTM.

To me too, but I'd suggest adding a comment, something around:

/* The "expedite" registers for x86 targets. Since whether the
variable is used depends on host/configuration, we mark
it ATTRIBUTE_UNUSED to keep it simple here. */

Thanks,
Pedro Alves