Re: [RFA 01/13] Simple unused variable removals

Pedro Alves
2018-07-16T13:33:31Z

On 07/14/2018 01:40 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4,
> Simon> - 4, byte_order);
>
> Simon> I wondered this was a bug (should that variable really be used), but I
> Simon> wouldn't know without some quite extensive research... so all-in-all, LGTM.
>
> Yes, this one was on the bubble and I almost put it in its own patch...
> I can't recall offhand if there were others like this.

I skimmed the patch and it looks good to me to, and, that bit
also gave me pause. I was wondering whether we should replace
it with a comment, saying that we're skipping 4 bytes which hold
the entry's size. That might save someone some time in case the size
turns out to be needed. (I have no idea where the structure being
extracted is documented, for example.)

Thanks,
Pedro Alves