Re: [RFA 01/13] Simple unused variable removals

Simon Marchi
2018-07-14T01:15:54Z

On 2018-07-12 04:51 PM, Tom Tromey wrote:
> This patch holds all the straightforward unused variable deletions.

I've looked at this patch and I didn't find anything that looked wrong
to my eyes. In some cases, such as:

--- a/gdb/spu-tdep.c
+++ b/gdb/spu-tdep.c
@@ -1820,8 +1820,6 @@ spu_get_overlay_table (struct objfile *objfile)
{
CORE_ADDR vma = extract_unsigned_integer (ovly_table + 16*i + 0,
4, byte_order);
- CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4,
- 4, byte_order);
CORE_ADDR pos = extract_unsigned_integer (ovly_table + 16*i + 8,
4, byte_order);
CORE_ADDR buf = extract_unsigned_integer (ovly_table + 16*i + 12,

I wondered this was a bug (should that variable really be used), but I
wouldn't know without some quite extensive research... so all-in-all, LGTM.

Simon