[RFA 00/13] Add -Wunused-variable

Tom Tromey
2018-07-12T20:52:32Z

An earlier thread pointed out the desirability of -Wunused-variable.
This series adds this to the build.

In a couple of spots I found it expedient to use ATTRIBUTE_UNUSED, but
mostly I avoided this. I also examined the other existing uses of
ATTRIBUTE_UNUSED to make sure they seemed ok. They did to me.

This series would not have been possible without Simon, who reduce the
needed configure test to a manageable size.

-Wunused-variable caught a couple real bugs. See patch #8 and patch #9.

Tested by the buildbot.

Tom