Re: [RFA 08/13] Fix ravenscar-thread.c to use arch_ops

Simon Marchi
2018-07-14T01:25:18Z

On 2018-07-12 04:52 PM, Tom Tromey wrote:
> The change to turn target ops into methods accidentally introduced a
> bug in ravenscar-thread.c, changing some calls that were using
> "arch_ops" to use the target beneath.
>
> This patch changes ravenscar-thread.c to use these variables where
> appropriate.
>
> gdb/ChangeLog
> 2018-07-12 Tom Tromey <tom@tromey.com>
>
> * ravenscar-thread.c (ravenscar_thread_target::store_registers):
> Use arch_ops.
> (ravenscar_thread_target::prepare_to_store): Likewise.
> ---
> gdb/ChangeLog | 6 ++++++
> gdb/ravenscar-thread.c | 4 ++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ravenscar-thread.c b/gdb/ravenscar-thread.c
> index 8bd31a5a725..e60fad87466 100644
> --- a/gdb/ravenscar-thread.c
> +++ b/gdb/ravenscar-thread.c
> @@ -442,7 +442,7 @@ ravenscar_thread_target::store_registers (struct regcache *regcache,
> struct ravenscar_arch_ops *arch_ops
> = gdbarch_ravenscar_ops (gdbarch);
>
> - beneath ()->store_registers (regcache, regnum);
> + arch_ops->to_store_registers (regcache, regnum);
> }
> else
> beneath ()->store_registers (regcache, regnum);
> @@ -461,7 +461,7 @@ ravenscar_thread_target::prepare_to_store (struct regcache *regcache)
> struct ravenscar_arch_ops *arch_ops
> = gdbarch_ravenscar_ops (gdbarch);
>
> - beneath ()->prepare_to_store (regcache);
> + arch_ops->to_prepare_to_store (regcache);
> }
> else
> beneath ()->prepare_to_store (regcache);
>

It looks obvious to me, but let's ping Pedro just to be sure.

Simon