From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DJ2rMo/VEmBPdAAAWB0awg (envelope-from ) for ; Thu, 28 Jan 2021 10:17:35 -0500 Received: by simark.ca (Postfix, from userid 112) id C6FE61EF80; Thu, 28 Jan 2021 10:17:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D1011E945 for ; Thu, 28 Jan 2021 10:17:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 200C23851416; Thu, 28 Jan 2021 15:17:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 200C23851416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611847055; bh=Z1pE1FPmaMER17feXfGxNE4LScnzyKxxsYl5leGsgu0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=C3gxFuUft7OnqEtdV9bK0Q1vxnCr5mfX2rUDjW/qxbtcvSYLqbGEZNaqitNoU962p pZxRRt+2WDS0NqUAbOQ0WrG3Tnn5G6qi/KECOhpphK/mpXn4oaFBexClTmQp4WdDxk PtuOD1y6yndg8CaYGobq2f9PQtfY6hC25YaVvJb0= Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by sourceware.org (Postfix) with ESMTPS id BF9C439AC853 for ; Thu, 28 Jan 2021 15:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF9C439AC853 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Boi7e1gJt4SyKKL79J39h+PQequDJGutsyqk+t8XN15GAkpCG1ITC5AY/zUlyge8D25Yr/X2Jcg6VJPuxQZV0gP180UeD0UA5ldNVKrxj0ye5UlW5JRQUH2nuj1Mhz5ZjHl/OroiX73RNPtK/2dn3dXzwxiwxLmF7PNbnABhHKRWzMwSoazm6VdOhmLuSEuhwHmPP2mK1R3neG1qztYBIxxYWhLPy6nSxzgApUsh2MTn+RzjYp/Qu8DqxofyWCv8kRloeQrI2/b7CodidfYexP8xZSZ9juCtPhrOYr9btUV4LfYqnHJXIafTyWm9k4Y5fuxGMdBMZ/TpoTZ0Jmey5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1pE1FPmaMER17feXfGxNE4LScnzyKxxsYl5leGsgu0=; b=DYVFtDBNOZld+8DLE5kG54uShMSoDcCWtUt920Tw5TCnl67R8Ia+NhFbveFCIryNUBe+jAmHoV20yehQKF6xei6aCK/qqwdvBFiatxP2qxOi3o2EoLR7FwBVdQmxfm/0iLXDU2+8PLrJ+wP0eI+0osyHThbLp9Sz2RWTf5lfn8jpX4d/7FUu22WZeUOath1r3SuYPqcsCDMqBg99IRoZDP3Mqv8nkt4mOMZbt3bqXHhL4lrJjs2gNUTzWcDfR46FNul6guWvasqy7mUqtrr3HoQPFYgAuswy8pz4w5cKpX+vIgP8C7yV/BMTVZuaRIQLr/VTGoeeT6jVENHFqceumQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3673.namprd12.prod.outlook.com (2603:10b6:5:1c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Thu, 28 Jan 2021 15:17:30 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3763.019; Thu, 28 Jan 2021 15:17:30 +0000 Subject: Re: [PATCH 01/13] gdb/dwarf: change read_loclist_index complaints into errors To: Simon Marchi , gdb-patches@sourceware.org References: <20210120053925.142862-1-simon.marchi@polymtl.ca> <20210120053925.142862-2-simon.marchi@polymtl.ca> Message-ID: <6d8498e3-8580-e537-d5b4-4dcb041bb7a9@amd.com> Date: Thu, 28 Jan 2021 15:17:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 In-Reply-To: <20210120053925.142862-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:cf:c92a:a445:6f68] X-ClientProxiedBy: AM0PR06CA0112.eurprd06.prod.outlook.com (2603:10a6:208:ab::17) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:cf:c92a:a445:6f68] (2a00:23c7:5a85:6801:cf:c92a:a445:6f68) by AM0PR06CA0112.eurprd06.prod.outlook.com (2603:10a6:208:ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16 via Frontend Transport; Thu, 28 Jan 2021 15:17:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6388d2c6-3c24-4162-54e4-08d8c39fd408 X-MS-TrafficTypeDiagnostic: DM6PR12MB3673: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jCDzaKVTH6If42pE5Kzi8z5wlcmYFigf4MaSy+6t4fqBfQR4YLfx7/oQz0CCNQ9KRSy76L70Y4q8J9E4d0Lxiss8pNMkRNlU2au3dHgnqueGjx1jMO0Zs2vQTIHWjZcapNKzdi3bDQtxYPAAg5bBtYV4KvmJKVKHLi0i+cxYQyeZr0R9Qg3Vnw7MYcTC3x3tVleerwbt99v5FVh5+MA9q14oaETiSzNf5SXwEiAqFimNK2cu0RN6WC/v/0q8ej7k3J45pWARezQ1uEteyPjwsqiwsUlBQFbPd+qeJha0l2RfLbfZXf70AFrdbAvhFVUAXI8i292q8/ioYgC6kyohErQDJ7oUUt/2tOzDnwEimY4k8I7aUbZe++KbzSaAwygYmZsliCGLrnwsG0UStd+w1kIsuIBkwpra52a9gLGXQrkeLL4E76cGOO9TWIgZsqyavl9m/QTv5eD7ppj3rU70l5ruQSAL4rPJ2o21yYCuOH0h8bKVAFGmmn064uCmAwZQ4CEF20ijMIyV1v/tLzkRVV+7x1yWMTA5vZfTC1Gj78j7nv7WdK9fPKeJ1/JFTDoiM6Q9vogPenOg7nWQlYCDZB7J4KewLpS3dDiXryqOVNk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(4326008)(6486002)(4744005)(6666004)(31696002)(8936002)(2906002)(36756003)(83380400001)(86362001)(8676002)(5660300002)(66946007)(478600001)(66476007)(31686004)(2616005)(316002)(66556008)(52116002)(16526019)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cG4rSWd6NWFpSTl0STJPV3V1SGhyWVZZbzlXVS9GYXNTemRoeVJ6Z2ExQzF0?= =?utf-8?B?OW5hSTJmTjd6MHFBc1B2NWVBam83WVZoTlk4NHR3NElISDVmQVgybkQ4SVdx?= =?utf-8?B?dFRreU95Z3VSZWVUcFc4Z1FSU2J2Tit3eWV0dG10TStVWUZsU0F1eFhYWmxl?= =?utf-8?B?QTQ1TGxnTUZldXNIYkt6WWxFekpGMmlkWVFxK25MZnFPNVlFNjhSTzVLWXdi?= =?utf-8?B?YWV3Z25xY3pHUXRNeUtvS2ZNN1htcTRsVTJDcDhoemtFR1l3TFBhSitTcEts?= =?utf-8?B?TFRsQmxhai9JVWppTSs0czZhSWhEc29qbGJmTklFanI0M2dTOG9yZGkvNjBo?= =?utf-8?B?MmxMM0dNM0cyTFdKN3puanA5SW9OMEhoaWFwS3hFRVIrcjVhVUl2eEw0ZHVp?= =?utf-8?B?WTVKd2gwYVoyVndxZmtCandYVDhlYThybGFrUDUwV3hVcC8waW13SHQ5MHNY?= =?utf-8?B?dDdXeVUyWVh1ZWVwZXROUEE5QWJHNFJNWE5PbUN6c3kxTW5iQXQ4M3hxM244?= =?utf-8?B?aVVhUlF1TzRjVnN0RVlweXRSbU85RzJiTTlIdVVxK2laVXdSVWQyaUFiYzBv?= =?utf-8?B?YldvQ2pkbFNxZDM5V0RZajE2OVhham1nTGtHcmRod0RQdUZRdmlqY0dDK0oz?= =?utf-8?B?Mk1VOEZUZXpzYTduWlROcFVVR21FVUxtVHhsZzRiK2RKNFJ3MDB6ZkhoRUsy?= =?utf-8?B?cGlhSkVwOEh6Z2h3Sk1IK2JUOFl5YXNtVE03TklRanFmMCs3d2tyMGRpWW5J?= =?utf-8?B?WlU5bzlRK1pCUEVKWnJ4S0txS3JpUjNiYWkrZmIvUHlYeHhEcTEzNkFFMWYz?= =?utf-8?B?SXFYazRjaFN2T1JlVGE2Q3ZNOWw5R1lYbzJZQThkS2F2WGtOS1lKNmZLQk5J?= =?utf-8?B?YjZGeC9UTTVsWGt1YW5mN1d5Q3U4ZUwzNFMraGJidEVDTHlFNUR6MDhtVExi?= =?utf-8?B?WmRKMVpRN3JCcFQwRXJVdzhlRStXdU45dEZ3NDZDL2hnRHlmRFk3TDZqbUpW?= =?utf-8?B?U3Nld1NJQ1JkQ0lFZXFHUGs3Qm5FbWdsU1VJU1d6MDlYZEdkTkRTVTZkRkhi?= =?utf-8?B?c20vVVZHdDJzYXppRVA4bGhjUkdEMFl3VDcrSmVDdzk2QWFhUGNoQkFqckM3?= =?utf-8?B?ZE5wTTBjcERZRHZqbTBHK3hYMHJFbTBqMW82WDU0ZzZ4R21OaWRaLzRDNGo2?= =?utf-8?B?UVlmUUNqUGJVTUd0cnJmS0ttRVBJblIwZW9vMFkxK0RFMko0ZHpZYlhJQjF1?= =?utf-8?B?aTVrZ08yZ0RNajU3ZHlhcGpTcXp4aE9xQ2xOOEFDcFVEZ29tSStOY3BybFVo?= =?utf-8?B?UUJJMHdRY2NOVm9MS3BmN25xanpJNzNHOEZLeUhsZkpSeFAxdEdlUzFPUlhp?= =?utf-8?B?MHVuVDVzNWJ1NTI2MStva1BuUEFST1VzY2FiQXROMGU3Z3dpamgxMzZIamRl?= =?utf-8?B?VnVlbVFFL2k5Wk9IL21RMWdBRDQ4WjQ1VGhETEdPUGx6YkUrdy9QR3lTMmd0?= =?utf-8?Q?Uty4OBv1MB8ltNWFF3y1heps7zc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6388d2c6-3c24-4162-54e4-08d8c39fd408 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2021 15:17:30.2934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9dPLTZtxi7VLS9jKR3bCC8qygGmJn7v1D23Vja1KnsNeSBWREzeexorNeGWAp6d/CnIHxB9P9coxHu/NdJOYDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3673 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Simon Marchi > > Unlike read_rnglists_index, read_loclist_index uses complaints when it > detects an inconsistency (a DW_FORM_loclistx value without a > .debug_loclists section or an offset outside of the section). I really > think they should be errors, since there's no point in continuing if > this situation happens, we will likely segfault or read garbage. > Makes sense. Although unless I misunderstand something, isn't the difference here that the error will actually throw an exception and therefore stop reading of the compilation unit if not the whole object file debug information? If this is the case, then considering the difference in usage between the two, having a wrong loclist information can still provide a correct line table information, but having a wrong rnglist information in my mind creates a more serious issue. On the other hand, how much can one trust in the information correctness if either of those are wrong.