Re: [PATCH 1/2] gdb: don't return an exited thread from any_non_exited_thread_of_inferior

[Simon Marchi <simon.marchi@efficios.com>]

On 9/21/26 6:22 AM, Matthieu Longo wrote:
> On 17/09/2026 21:16, Simon Marchi wrote:
>> any_non_exited_thread_of_inferior prefers to return the selected thread:
>>
>>   /* Prefer the current thread, if there's one.  */
>>   if (inf == current_inferior () && inferior_ptid != null_ptid)
>>     return inferior_thread ();
>>
>> ... but the selected thread can be an exited thread.  This can happen in
>> non-stop when the selected thread exits, in which case it is kept around
>> but marked as exited (see thread_info::deletable).
>>
>> Check the current thread's state before returning it, and fall through
>> to the existing loop otherwise.
>>
>> Note that we also have any_live_thread_of_inferior, which is similar but
>> differs in subtle ways.  We should probably check if we can merge them
>> at some point.
>>
>> Change-Id: I620ee200037c6a3fd3d59b96f16750d6b962c724
> 
> For my curiosity, what is this Change-Id for ?
> I saw several ones in the git history, but I have no idea why it is there.
> 
> Matthieu

It's a Gerrit change id, added by the Gerrit hook.  That's because I use
Gerrit to track patches when I develop them.  Having the Change-Id in
the upstream commits makes it so that Gerrit auto-closes the changes
when I pull origin/master into Gerrit's master branch, so it helps me
with tracking what I have pending.

Simon