From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id AA05B3840C10 for ; Tue, 19 May 2020 17:44:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA05B3840C10 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-YoTuHuDWMrmTouWVmZfSqQ-1; Tue, 19 May 2020 13:44:13 -0400 X-MC-Unique: YoTuHuDWMrmTouWVmZfSqQ-1 Received: by mail-wr1-f70.google.com with SMTP id w9so161569wrr.3 for ; Tue, 19 May 2020 10:44:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3QNyRgqTXtOaJnHsCZu+7KUoz3jwZ7SlDL6Yi5KCTaY=; b=IRPYnpI7AZctAy5kknePnVL3ARbu7ZqKA8+JPUvEY/UVh8iDLcbH2ctWlEdtQH4sX5 NlAoaPIRgkcrMA65OWhCE3svV59yBbdKis/q2ZozBTLR+IP5iTNQRvmzHzIL6w/BgVTe rbstGYohZDVef136jO43Gpqjg5pbK9z2a9FE3XMTcdNTB51ucr7Tmihw4UmgledRQmk/ bWn6jdqWyM31TBc+zbOKnuPS127umxykx2LcoMGnoONAz2bgJxbQCefFo9XkcLuvlSoq FYSp6gA9JUK7/8K9erv77f3A36mHZv8ESO6IxRjLM3T0C86ZUyV1ZoU7dCVQvWOZWBUG Wcxw== X-Gm-Message-State: AOAM532ut3Mnc2YNgbI+h0RZVYHlL5HKEjfylBTJGaL6qgsies6EfI3Y 7fWo9/+bLEf50IydajRJNZq5QaVy339x7/OdQWMovAB4PBKfoh23+esJsj9bRqLSwoxUvPkYOpF 3cRAS0G4vvBXKp4hyeP9Hhw== X-Received: by 2002:a1c:4e0a:: with SMTP id g10mr517553wmh.75.1589910252431; Tue, 19 May 2020 10:44:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk1ha3TQcn+cheDwsj8JAUTqmX0AiwCQReD3H66WdKdjGR/p0uemEl32wNO9lJksNx4mFzKA== X-Received: by 2002:a1c:4e0a:: with SMTP id g10mr517531wmh.75.1589910252158; Tue, 19 May 2020 10:44:12 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a15sm145107wrw.56.2020.05.19.10.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 10:44:11 -0700 (PDT) Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs To: Tom Tromey , Pedro Alves via Gdb-patches , Philippe Waroquiers References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <87tv0b7vy0.fsf@tromey.com> From: Pedro Alves Message-ID: <6d669d00-236a-cede-5c5e-3d65d3ee5a53@redhat.com> Date: Tue, 19 May 2020 18:44:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87tv0b7vy0.fsf@tromey.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 17:44:16 -0000 On 5/19/20 5:04 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves via Gdb-patches writes: > > Pedro> On 5/17/20 7:04 PM, Pedro Alves via Gdb-patches wrote: >>> The patch makes GDB first try exec-file-mismatch validation via build >>> IDs, and then if that isn't possible, fallback to validating using the >>> old method of comparing filenames. I'd argue that we should remove >>> the filename validation for causing too many false positives, though. > > Agreed. > > Pedro> Here's an updated version that removes the filename comparison. > Pedro> I've kept the structure of the code the same, in case we > Pedro> add some form of fallback later on. > > It makes sense to me. > I read these patches and they look good to me. Thanks all for the reviews and discussions. I've merged this now. Pedro Alves