From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qLBZKkmDsl+jXwAAWB0awg (envelope-from ) for ; Mon, 16 Nov 2020 08:48:57 -0500 Received: by simark.ca (Postfix, from userid 112) id AAE341F08B; Mon, 16 Nov 2020 08:48:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 45C441E58F for ; Mon, 16 Nov 2020 08:48:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7CDD3851C24; Mon, 16 Nov 2020 13:48:56 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id BAC34385EC57 for ; Mon, 16 Nov 2020 13:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BAC34385EC57 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CA49AAC23; Mon, 16 Nov 2020 13:48:53 +0000 (UTC) To: "Aktemur, Tankut Baris" , Pedro Alves , Simon Marchi , "gdb-patches@sourceware.org" References: <20200708233125.1030-1-pedro@palves.net> <20200708233125.1030-4-pedro@palves.net> <58a4020f-fbbb-611f-eb23-c1b3fa25d4f2@simark.ca> <39ad8351-3f99-1162-4d2f-b5dbee5756f8@simark.ca> <47b34393-3833-bb85-84dc-9a8bde3e1a77@palves.net> <3293dbc2-922a-8589-dbc7-75ebd5a26175@simark.ca> <7e4c3794-99fa-72fb-21be-26e0787495fc@palves.net> From: Tom de Vries Subject: Re: [PATCH] Fix frame cycle detection (Re: [PATCH 3/3] Make scoped_restore_current_thread's cdtors exception free (RFC)) Message-ID: <6d50a9a2-5c37-9709-9c51-a2161c517b35@suse.de> Date: Mon, 16 Nov 2020 14:48:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/9/20 3:05 PM, Aktemur, Tankut Baris via Gdb-patches wrote: > On Saturday, October 31, 2020 3:35 PM, Pedro Alves wrote: >> On 10/30/20 11:32 AM, Pedro Alves wrote: >>> Hi! >>> >>> On 10/30/20 7:44 AM, Aktemur, Tankut Baris wrote: >>> >>>> Hi Pedro, >>>> >>>> This patch created the regression below: >>>> >>>> Breakpoint 1, 0x00000000004012bb in eh2 (/gdb-up/gdb/frame.c:641: internal-error: >> frame_id get_frame_id(frame_info*): Assertion `stashed' failed. >>>> A problem internal to GDB has been detected, >>>> further debugging may prove unreliable. >>>> Quit this debugging session? (y or n) FAIL: gdb.base/eh_return.exp: hit breakpoint (GDB >> internal error) >>> >>> Hmm, sorry about that. It passes for me on the machine I was >>> running tests on, so I missed it. I can reproduce it on a F27 machine. >>> I'll take a better look. >>> >> >> Here's a fix. See explanation within. > > Thanks. This fixed the regression. > I can also confirm that this fixes the FAIL for me. Glad I committed that test-case :) Thanks, - Tom