From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11033 invoked by alias); 30 Nov 2016 20:47:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11020 invoked by uid 89); 30 Nov 2016 20:47:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1488 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 20:47:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC31361E4A; Wed, 30 Nov 2016 20:47:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUKlKX9013209; Wed, 30 Nov 2016 15:47:20 -0500 Subject: Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple To: Luis Machado , gdb-patches@sourceware.org References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: <6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com> Date: Wed, 30 Nov 2016 20:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg01022.txt.bz2 On 11/25/2016 08:54 PM, Luis Machado wrote: > This fixes offender testcases that have test names starting with uppercase > when using gdb_test_multiple in a multi-line construct. > > gdb/testsuite/ChangeLog > 2016-11-25 Luis Machado > > Fix test names starting with uppercase throughout the files. > > * gdb/testsuite/gdb.cp/gdb2495.exp Drop "gdb/testsuite/", and LGTM, but ... > --- > gdb/testsuite/gdb.cp/gdb2495.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp > index dff5977..7e4dfa8 100644 > --- a/gdb/testsuite/gdb.cp/gdb2495.exp > +++ b/gdb/testsuite/gdb.cp/gdb2495.exp > @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \ > > # Turn off this new behaviour. > gdb_test_multiple "set unwind-on-terminating-exception off" \ > - "Turn unwind-on-terminating-exception off" { > + "turn unwind-on-terminating-exception off" { > -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"} > timeout {fail "(timeout) set unwind-on-terminating-exception off"} > } ... I think this could just be: gdb_test "set unwind-on-terminating-exception off" "" ? I'd end up fixing two extra things: - note the typo in the pass case: "unwiNN" - odd "(timeout)" print position. timeout handling it not necessary at all with gdb_test_multiple, even. Thanks, Pedro Alves