From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25798 invoked by alias); 3 Apr 2019 21:00:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25787 invoked by uid 89); 3 Apr 2019 21:00:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=yours, day, HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 21:00:44 +0000 Received: by mail-wr1-f66.google.com with SMTP id t17so596811wrw.13 for ; Wed, 03 Apr 2019 14:00:44 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a11sm15278405wmm.35.2019.04.03.14.00.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 14:00:41 -0700 (PDT) Subject: Re: [RFC] Sort #includes in gdb To: Tom Tromey References: <87fttfmnpq.fsf@tromey.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <875zs1csim.fsf@tromey.com> <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com> <87mul626ji.fsf@tromey.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <6d046c9d-6b59-19ff-279a-437a11bb3761@redhat.com> Date: Wed, 03 Apr 2019 21:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87mul626ji.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-04/txt/msg00064.txt.bz2 On 04/03/2019 09:11 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> On 03/29/2019 09:05 PM, Simon Marchi wrote: >>> >>> I don't think I've mentioned it, but I really like this change.  I don't like the mental weight of having to choose where to add my include in an unorganized list :). > > Pedro> Me too. I'm waiting for this to land before touching the "namespace gdb" > Pedro> work again, since a not-insignificant part of that work revolves around > Pedro> moving "#include"s in the middle of files to the top of the file. > > This patch doesn't touch those includes -- it only touches the ones at > the top of a file. If you want to land yours first, it's no trouble for > me. The change is just running a script. > > On irc the other day, Simon had the idea that I could land the patch in > pieces: say, convert [a-f]*, test that, check it in. I modified my > script to let me do this and the first batch went through. So, if you'd > really rather this go first, let me know and I can do it that way. It > may take a few days to get it all in. Nope, please don't hold up for me. I don't have things ready enough. I meant more that I'm waiting to rebase on top of your work before continuing with the work of cleaning up the branch to bring it to mergeable state. Thanks, Pedro Alves